Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Daniel Pfeifer
CMake
Commits
33805595
Commit
33805595
authored
Jan 06, 2017
by
Daniel Pfeifer
Browse files
cmCommand: remove FinalPass from interface
parent
1226f967
Changes
2
Hide whitespace changes
Inline
Side-by-side
Source/cmCommand.h
View file @
33805595
...
...
@@ -61,19 +61,6 @@ public:
virtual
bool
InitialPass
(
std
::
vector
<
std
::
string
>
const
&
args
,
cmExecutionStatus
&
)
=
0
;
/**
* This is called at the end after all the information
* specified by the command is accumulated. Most commands do
* not implement this method. At this point, reading and
* writing to the cache can be done.
*/
virtual
void
FinalPass
()
{}
/**
* Does this command have a final pass? Query after InitialPass.
*/
virtual
bool
HasFinalPass
()
const
{
return
false
;
}
/**
* This is a virtual constructor for the command.
*/
...
...
Source/cmMakefile.cxx
View file @
33805595
...
...
@@ -7,7 +7,6 @@
#include
<algorithm>
#include
<assert.h>
#include
<ctype.h>
#include
<memory>
#include
<sstream>
#include
<stdlib.h>
#include
<string.h>
...
...
@@ -248,20 +247,6 @@ private:
cmMakefile
*
Makefile
;
};
class
cmFinalPassAction
{
public:
cmFinalPassAction
(
cmCommand
*
command
)
:
Command
(
command
)
{
}
void
operator
()(
cmMakefile
&
)
{
this
->
Command
->
FinalPass
();
}
private:
std
::
shared_ptr
<
cmCommand
>
Command
;
};
bool
cmMakefile
::
ExecuteCommand
(
const
cmListFileFunction
&
lff
,
cmExecutionStatus
&
status
)
{
...
...
@@ -304,9 +289,6 @@ bool cmMakefile::ExecuteCommand(const cmListFileFunction& lff,
if
(
this
->
GetCMakeInstance
()
->
GetWorkingMode
()
!=
cmake
::
NORMAL_MODE
)
{
cmSystemTools
::
SetFatalErrorOccured
();
}
}
else
if
(
pcmd
->
HasFinalPass
())
{
// use the command
this
->
AddFinalAction
(
cmFinalPassAction
(
pcmd
.
release
()));
}
}
}
else
{
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment