Commit 33805595 authored by Daniel Pfeifer's avatar Daniel Pfeifer
Browse files

cmCommand: remove FinalPass from interface

parent 1226f967
...@@ -61,19 +61,6 @@ public: ...@@ -61,19 +61,6 @@ public:
virtual bool InitialPass(std::vector<std::string> const& args, virtual bool InitialPass(std::vector<std::string> const& args,
cmExecutionStatus&) = 0; cmExecutionStatus&) = 0;
/**
* This is called at the end after all the information
* specified by the command is accumulated. Most commands do
* not implement this method. At this point, reading and
* writing to the cache can be done.
*/
virtual void FinalPass() {}
/**
* Does this command have a final pass? Query after InitialPass.
*/
virtual bool HasFinalPass() const { return false; }
/** /**
* This is a virtual constructor for the command. * This is a virtual constructor for the command.
*/ */
......
...@@ -7,7 +7,6 @@ ...@@ -7,7 +7,6 @@
#include <algorithm> #include <algorithm>
#include <assert.h> #include <assert.h>
#include <ctype.h> #include <ctype.h>
#include <memory>
#include <sstream> #include <sstream>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
...@@ -248,20 +247,6 @@ private: ...@@ -248,20 +247,6 @@ private:
cmMakefile* Makefile; cmMakefile* Makefile;
}; };
class cmFinalPassAction
{
public:
cmFinalPassAction(cmCommand* command)
: Command(command)
{
}
void operator()(cmMakefile&) { this->Command->FinalPass(); }
private:
std::shared_ptr<cmCommand> Command;
};
bool cmMakefile::ExecuteCommand(const cmListFileFunction& lff, bool cmMakefile::ExecuteCommand(const cmListFileFunction& lff,
cmExecutionStatus& status) cmExecutionStatus& status)
{ {
...@@ -304,9 +289,6 @@ bool cmMakefile::ExecuteCommand(const cmListFileFunction& lff, ...@@ -304,9 +289,6 @@ bool cmMakefile::ExecuteCommand(const cmListFileFunction& lff,
if (this->GetCMakeInstance()->GetWorkingMode() != cmake::NORMAL_MODE) { if (this->GetCMakeInstance()->GetWorkingMode() != cmake::NORMAL_MODE) {
cmSystemTools::SetFatalErrorOccured(); cmSystemTools::SetFatalErrorOccured();
} }
} else if (pcmd->HasFinalPass()) {
// use the command
this->AddFinalAction(cmFinalPassAction(pcmd.release()));
} }
} }
} else { } else {
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment