- Aug 24, 2020
-
-
Robert Maynard authored
Fixes #20953
-
- Aug 20, 2020
-
-
-
47abe5f2 FindMPI: Fix regression in pthread guard Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
Raul Tambre <raul@tambre.ee>
Merge-request: !5147 -
983cb0c8 gitlab-ci: Update Windows builds to MSVC 19.27 Acked-by:
-
f4373fed Tests: Fix RunCMake.try_compile test for C standards with MSVC 19.27 Acked-by:
-
Fix a regression with MPI and CUDA<10.2 that did let `-pthread` flags slip to nvcc again. In commit b725a190 (FindMPI: Deny -fexceptions from NVCC, 2020-07-02, v3.18.0-rc4~12^2) we accidentally forgot to use the variable containing the replacement result. Fixes: #21108
-
- Aug 19, 2020
-
-
Brad King authored
-
-
71532474 ExternalProject: Stop configure target from always appearing out-of-date c0b7198a ExternalProject: Stop patch target from always appearing out-of-date Acked-by:
-
3937536d llvm-rc: Fix quoting of path to cmake in CMAKE_RC_COMPILE_OBJECT Acked-by:
-
72822e26 FindPython: enhance robustness of version extraction from library name Acked-by:
-
Brad King authored
6896e509 CMakeFindBinUtils: Always consider plain binutils when not cross-compiling Acked-by:
-
- Aug 18, 2020
-
-
When the installation path to cmake includes spaces, the `<CMAKE_COMMAND>` is required to have proper quotation of the cmake call. Fixes: #21095
-
-
Craig Scott authored
When updates are disconnected, don't depend on skip-update because that target is always considered out of date. Depend directly on the patch target instead because it already depends on the appropriate target regardless of whether updates are disconnected or not. This in turn means nothing depends on the skip-update target, so it has also been removed. Relates: #21086
-
Craig Scott authored
The skip-update target is always considered out-of-date. The change in 7249ba96 (ExternalProject: Enforce that patch depends on update, 2020-04-03) made the patch target depend on skip-update, which in turn made it always out of date too. The patch command should only be re-run if the download needs to be performed again where updates are disconnected. Fixes: #21086
-
Marc Chevrier authored
Fixes: #21105
-
- Aug 12, 2020
-
-
e7fe0b24 FindRuby: Add documentation for deprecated variables Acked-by:
-
Since commit e672db62 (FindRuby: Rename variables to match case of module name, 2020-03-11, v3.18.0-rc1~546^2), the upper-case-prefixed variable names are for compatibility only but still exist. Put them back in the documentation. Issue: #21064
-
f7347f28 MSVC: Record support for C11 and c_restrict Acked-by:
-
951640f1 FindPython: manage SOABI for all Python versions Acked-by:
-
- Aug 11, 2020
-
-
778ea72b gitlab-ci: add 'cmake' tag to all jobs Acked-by:
-
Brad King authored
This will give us more granular control over which runners accept jobs for CMake.
-
MSVC >=19.27 supports a C11 switch. The `c_restrict` feature has also been implemented. Fixes: #21069
-
e038107e FindHDF5: fix compiler detection when HL is disabled Acked-by:
-
70ce1ad6 PCH: Avoid Apple-specific architecture flags on other platforms Acked-by:
-
5b5be348 Help: Add 3.18.2 release note about AUTOMOC_PATH_PREFIX default change db659e18 Merge branch 'backport-3.17-automoc-path-prefix-off' e503fbe3 Merge branch 'backport-3.16-automoc-path-prefix-off' 4c33b305 Autogen: Turn off moc path prefix generation by default 56510b7d Merge branch 'backport-test-FindPkgConfig-isolate-env' into release-3.17 effc9a10 Merge branch 'backport-3.17-automoc_timestamp_deps' into release-3.17 507fecd7 Merge branch 'ninja-multi-rsp-remove-path' into release-3.17 Acked-by:
-
Marc Chevrier authored
Fixes: #21070
-
- Aug 10, 2020
-
-
Brad King authored
Since commit f593b354 (PCH: Add support for multi architecture iOS projects, 2020-04-02, v3.18.0-rc1~414^2) the `OSX_ARCHITECTURES` target property (and corresponding `CMAKE_OSX_ARCHITECTURES` variable) affects flags on non-Apple platforms by accident. Add a missing condition to avoid this. Fixes: #21072
-
A valid HDF5 installation with the "high level" extensions not configured will *fail* to be correctly detected by CMake since commit d9e39f3f (FindHDF5: check that compiler wrapper can compile a minimal program, 2020-02-10, v3.18.0-rc1~744^2~1): ``` /.../hdf5/cmake_hdf5_test.c:2:10: fatal error: 'hdf5_hl.h' file not found ``` This does not stop the configuration but does prevent flags and libraries from being recognized.
-
98844ec9 FPHSA: detect inclusion between find modules Acked-by:
Logan Barnes <barneslt63@gmail.com> Merge-request: !5107
-
97d581b2 Xcode: Explicitly turn off signing in try_compile projects Acked-by:
-
69597441 FindRuby: Restore compatibility variable RUBY_INCLUDE_PATH Acked-by:
-
a92d3845 FindPython: ensure user's policies are respected Acked-by:
Henry Schreiner <henryschreineriii@gmail.com> Merge-request: !5098
-
-
Brad King authored
-
8b129826 Merge branch 'backport-test-FindPkgConfig-isolate-env' 4c939b0d Tests: Isolate RunCMake.FindPkgConfig from caller environment 20eeb40a Tests: Isolate RunCMake.FindPkgConfig from caller environment Acked-by:
-
Brad King authored
-
Change the default value of `CMAKE_AUTOMOC_PATH_PREFIX` to `OFF` to restore compatibility with behavior of CMake 3.15 and below. C++ source files that are generated by Qt's meta object compiler (moc) include the header file that was passed as input argument to moc. This is usually a path relative to the source directory, for example #include "../../source/dir/myobject.h" That is problematic for reproducible builds as described in #18815. To cope with that, the target property AUTOMOC_PATH_PREFIX was introduced in CMake 3.16 by commit d018d27c (Autogen: Add moc path prefix generation (AUTOMOC_PATH_PREFIX), 2019-09-13, v3.16.0-rc1~94^2~4). The property is default-initialized from the variable `CMAKE_AUTOMOC_PATH_PREFIX`, which defaults to `ON`. If this property is ON, and myobject.h is located in an include directory of the target, moc-generated C++ files include the file without the "path prefix": #include "myobject.h" This behavior, however, can break projects that have equally named header files in different include directories. As "not breaking existing projects" trumps "have reproducible builds by default" we change the default of `CMAKE_AUTOMOC_PATH_PREFIX` to `OFF`. Also, it is now possible to pass `-DCMAKE_AUTOMOC_PATH_PREFIX=ON` on the CMake command line. Before, it was overridden in `CMakeGenericSystem`. Fixes: #20598 Issue: #18815 -
-
