Skip to content

ExternalProject: Prevent patch and configure from always being out-of-date

Craig Scott requested to merge craig.scott/cmake:ep-patch-skip-update-dep into master

When updates are disconnected, the patch and configure targets were depending on the skip-update target. !4565 (merged) added the dependency for patch, whereas the dependency for configure has existed since the update disconnected feature was first added by 3f606fa7 for CMake 3.2. The skip-update target is always considered out-of-date. This means the patch and configure steps always get re-executed. Patch should depend directly on download instead and the configure target can just always depend directly on patch only. The skip-update target is then redundant and can be removed.

Fixes: #21086 (closed)
Backport: release

Edited by Craig Scott

Merge request reports