- Jul 26, 2021
-
-
08131e83 Tests: Clean up Ninja Multi-Config test from cb777dd8 Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !6383
-
e5ec0e52 AUTOUIC: Fix generating of dependency rules for UI header files Acked-by:
-
4bda0337 AutoGen: Fix needless compilation of mocs_compilation.cpp Acked-by:
-
ba6d1947 Help: Add cross-references between test output size ctest variables cdde9e5a Help: Improve wording and cross-referencing for ctest JUnit output Acked-by:
-
Craig Scott authored
-
- Jul 25, 2021
-
-
Craig Scott authored
-
- Jul 23, 2021
-
-
Kyle Edwards authored
-
Jörg Bornemann authored
For an AUTOMOC'ed target foo, when depfiles are used, there are the following dependencies: foo_autogen -> foo_autogen/timestamp foo_autogen/mocs_compilation.cpp -> foo_autogen/timestamp The first is used to trigger AUTOGEN. The second erroneously triggers a recompilation of mocs_compilation.cpp when any source file of target foo is touched. Remove the latter dependency and replace it with an order-only dependency from foo_autogen/mocs_compilation.cpp to foo_autogen_timestamp_deps. That is achieved by making mocs_compilation.cpp or its per-configuration variants byproduct(s) of the timestamp file. Fixes: #22338
-
d61bc424 GNU: Correct C23 flags Acked-by:
-
cb777dd8 Ninja Multi-Config: Restore TARGET_OBJECTS support in cross-configs 83c82722 cmGeneratorExpressionNode: Factor out local variable for global generator Acked-by:
-
078ba4b2 Swift: Update test case to try CMP0126 NEW behavior Acked-by:
-
Alexey Edelev authored
We could not rely on .ui files when generating the ninja rules for the generated UI header files. .ui files might be added to the target sources but never processed by AUTOUIC afterward, since UI header files are never included in a source code. Instead of adding dependency rules based on the .ui files, this approach scans non-generated source files for includes of the UI header files, as AUTOUIC does. This gives the consistent set of UI header files at configure time, that could be used to generate byproducts rules for the AUTOUIC. Also, the path to the generated UI header file depends not on the .ui file location but on the include line is used in source files. Fixes: #16776
-
5b9bfe73 IAR: Moved search logic to BinUtils. Acked-by:
-
Jean-Marc Hengen authored
The search logic for the IAR linker, librarian and related tools is moved from `Modules/Compiler/IAR-FindBinUtils.cmake` to `Modules/CMakeFindBinUtils.cmake` by introducing an new elseif block for the IAR toolchain. The search logic was refactored to omit repeating itself. Fixes: #22425
-
- Jul 21, 2021
-
-
Raul Tambre authoredNon-final forms aren't supported yet, unlike C++23. Seems I might've gotten confused due to that when I added these. Fixes #22453.
-
Brad King authored
Since commit 2ae72ef7 (Xcode: Enable multi-arch TARGET_OBJECTS genex in [INTERFACE_]LINK_LIBRARIES, 2021-05-26, v3.21.0-rc1~126^2) the TARGET_OBJECTS genex, when referenced for linking, is now evaluated with EvaluateForBuildsystem enabled. This causes the object file paths to be computed with a buildsystem-specific placeholder for the configuration. This is normally fine because the placeholder will be evaluated by the native buildsystem tool using the proper configuration. However, the Ninja Multi-Config generator's `${CONFIGURATION}` placeholder may not have the correct value for cross-config object files. Switch back to using the per-config location of each object file for this generator. Fixes: #22436
-
-
c7a8c9c8 cmMessenger: Revert to non-color messages on Windows Acked-by:
-
d777ca12 CMakeDependentOption: Revert "Allow parentheses in the depends string" Acked-by:
-
144be54d try_compile: Propagate CMP0126 to the generated test project Acked-by:
-
- Jul 20, 2021
-
-
Brad King authored
-
Brad King authored
Since commit 0a0a0f8a (cmMessenger: Color messages to terminal by type, 2021-05-18, v3.21.0-rc1~146^2) the message output no longer goes through our custom streambuf on Windows that converts output encoding. This can cause messages to be printed with the wrong encoding in a Windows Console. It also causes messages to have a mix of LF and CRLF newlines because `stderr` converts LF to CRLF but our custom streambuf does not. Revert to using just `cerr` for messages on Windows. Another approach will be needed to achieve color output on Windows later. Fixes: #22444
-
-
09bc0785 Help: Document CMAKE_EXECUTABLE_SUFFIX_<LANG> explicitly 05a3bafe Compiler/IAR: Avoid clobbering CMAKE_EXECUTABLE_SUFFIX Acked-by:
-
1c66012f Compiler/IAR: search for both IAR's binaries * and *.exe Acked-by:
-
-
-
-
f75610d4 CMakeDetermineCompilerId: Fix CMAKE_EXECUTABLE_FORMAT in CMP0126 NEW behavior Acked-by:
-
9cebdbec AUTOUIC: Fix cyclic dependency between generated UI headers and timestamp Acked-by:
-
7b5fa0f7 Help: Make policy CMP0126 wording more accurate c4bc250f Help: Explain policy CMP0125 in more detail 6d5f74fc Help: Clarify wording of CMP0124 Acked-by:
-
Brad King authored
Set policy CMP0126 to the value used in the calling project. It may affect toolchain file behavior.
-
8d1944c6 Help: Expand details for file(COPY_FILE) c8ea8861 Help: Re-order file() sub-commands in Filesystem section b5a96716 Help: Clarify which project() call PROJECT_IS_TOP_LEVEL is for 8be7694d Help: Fix trivial typo Acked-by:
-
- Jul 19, 2021
-
-
Craig Scott authored
-
Craig Scott authored
The file(COPY_FILE) sub-command is closely related to the file(COPY) sub-command. Move the former to just before the latter for improved continuity. The file(RENAME) sub-command is also somewhat related to file(COPY_FILE), so it was also moved to keep it just before file(COPY_FILE). The file(MAKE_DIRECTORY) sub-command was also moved to just before the file(REMOVE) and file(REMOVE_RECURSE) sub-commands to keep them together and improve logical flow of operations.
-
Brad King authored
Setting `CMAKE_EXECUTABLE_FORMAT` as a normal variable is unnecessary because setting it as a cache entry already makes the value visible to the calling scope. Fixes: #22433
-
Once the generated UI headers are created by UIC they also are involved into processing in next run on ninja. Autogen adds `ui_*.h` files to the deps file `ui_*.h` and this cause timestamp start depend on `ui_*.h`. Meanwhile `ui_*.h` depend on timestamp because of the explicit rules added by commit 1265c65b (AUTOUIC: Collect ui header files for Ninja generator, 2021-02-18, v3.21.0-rc1~600^2). Avoid adding `ui_*.h` to deps file at second ninja run. Fixes: #16776
-
aa874dc6 CMakePresets.json: Fix expansion issue with empty binaryDir Acked-by:
-
3ddd7f35 enable_language: Fix test for working compiler with CMP0126 NEW behavior Acked-by:
-
1aba3a83 libuv: Fix building with mingw toolchains for ARM/AArch64 Acked-by:
-
