Skip to content

Fix overload virtual warnings

Jean-Christophe Fillion-Robin requested to merge jcfr/qttesting:fix-overload-virtual-warning into master

This PR fixes warnings like the following ones introduced by ddf024ca (CheckFeature)

Note that after integrating !6 (merged) and !5 (merged) , all tests pass.

In file included from /home/jcfr/Projects/Slicer/Libs/MRML/Widgets/qMRMLCheckableNodeComboBoxEventPlayer.h:25:0,
                 from /home/jcfr/Projects/Slicer/Base/QTGUI/qSlicerApplication.cxx:82:
/home/jcfr/Projects/Slicer-Release/CTK-build/QtTesting/pqWidgetEventPlayer.h:60:16: warning: ‘virtual bool pqWidgetEventPlayer::playEvent(QObject*, const QString&, const QString&, bool&)’ was hidden [-Woverloaded-virtual]
   virtual bool playEvent(
                ^
In file included from /home/jcfr/Projects/Slicer-Release/CTK-build/QtTesting/pqTreeViewEventPlayer.h:35:0,
                 from /home/jcfr/Projects/Slicer/Libs/MRML/Widgets/qMRMLTreeViewEventPlayer.h:25,
                 from /home/jcfr/Projects/Slicer/Base/QTGUI/qSlicerApplication.cxx:85:
/home/jcfr/Projects/Slicer-Release/CTK-build/QtTesting/pqAbstractItemViewEventPlayerBase.h:51:8: warning:   by ‘virtual bool pqAbstractItemViewEventPlayerBase::playEvent(QObject*, const QString&, const QString&, int, bool&)’ [-Woverloaded-virtual]
   bool playEvent(QObject* object, const QString& command,
        ^
In file included from /home/jcfr/Projects/Slicer/Libs/MRML/Widgets/qMRMLNodeComboBoxEventTranslator.h:28:0,
                 from /home/jcfr/Projects/Slicer/Base/QTGUI/qSlicerApplication.cxx:84:
/home/jcfr/Projects/Slicer-Release/CTK-build/QtTesting/pqWidgetEventTranslator.h:62:16: warning: ‘virtual bool pqWidgetEventTranslator::translateEvent(QObject*, QEvent*, int, bool&)’ was hidden [-Woverloaded-virtual]
   virtual bool translateEvent(QObject* object, QEvent* event, int eventType, bool& error);
                ^
In file included from /home/jcfr/Projects/Slicer/Base/QTGUI/qSlicerApplication.cxx:84:0:
/home/jcfr/Projects/Slicer/Libs/MRML/Widgets/qMRMLNodeComboBoxEventTranslator.h:43:16: warning:   by ‘virtual bool qMRMLNodeComboBoxEventTranslator::translateEvent(QObject*, QEvent*, bool&)’ [-Woverloaded-virtual]
   virtual bool translateEvent(QObject *Object, QEvent *Event, bool &Error);
                ^

Merge request reports