vtkSMRenderViewProxy: select GeometryRepresentation for composite data (rework)

Composite datasets may not have leaf datasets at the time of their creation, hence knowing whether there is a suitable representation for them in a RenderView is not known at the time the representation type is queried. This can lead to all kinds of problems, such as #21381 (closed), #21293 (closed), and #21041 (closed).

Implemented a mostly good workaround where a GeometryRepresentation will be created for composite datasets. This may be incorrect for when the composite dataset will be populated with vtkTable leaves, for instance, but that could happen in previous versions of ParaView if you grouped geometry datasets with the Group Datasets filter and later changed the inputs of the filter to only vtkTables (a rare case). Further work may be needed to resolve that issue. The worst that can happen with this change is that a representation that doesn't show anything for vtkTables will be created in a RenderView.

Backport: release

assigned to @julien.fausty

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

mentioned in merge request !5898 (merged)

added 1 commit

• bef7c11d - fix(warning): shadowing of dataInformation variable

Compare with previous version

Errors:

• commit bef7c11d is not allowed because the following files are not formatted according to the 'clang-format' check: Remoting/Views/vtkSMRenderViewProxy.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

Errors:

• commit bef7c11d is not allowed because the following files are not formatted according to the 'clang-format' check: Remoting/Views/vtkSMRenderViewProxy.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

Do: reformat

This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

added 1 commit

• 5f32574d - fix(warning): shadowing of dataInformation variable

Compare with previous version

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

@cory.quammen @mwestphal please review

Two fixes are included compared with !5898 (merged):

• a first fix concerning the vtkPVDataInformation of empty composite data sets in parallel
• a second fix concerning a shadowing warning for the dataInformation variable

Each has its own commit

This fix is specific to the render view, what is the behavior when using the spreadsheet view or a chart view ?

mentioned in issue #21557

LGTM

+1

resolved all threads