Brad King authored 4 years ago and Kitware Robot committed 4 years ago

41700ca4 SystemTools: Fix FileIsExecutable on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !179

Since commit 66724af8 (SystemTools: Teach FindProgram to find
non-readable programs, 2020-04-04), `FindProgram` uses the new
`FileIsExecutable` method.  On Windows this changed the check
from `GetFileAttributesW` to `_waccess`, but the latter returns
success even for Windows Store stubs like

  %USERPROFILE%\AppData\Local\Microsoft\WindowsApps\python.exe

Since the goal of the original change was to fix executable
permissions checks on UNIX-like platforms, simply restore the
old check code on Windows.

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

66724af8 SystemTools: Teach FindProgram to find non-readable programs

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !175

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

e3989b18 SystemTools: Restore GetCurrentWorkingDirectory slash conversion on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !176

Since commit 019afb6e (SystemTools: Drop GetCurrentWorkingDirectory
'collapse' argument, 2020-04-03) the return value of this method uses
backslashes.  Restore conversion to forward slashes.

Vladimir authored 4 years ago and Brad King committed 4 years ago

This commit fixes FindProgram failing to detect executable without
read bit set. find_program internally uses SystemTools::FileExists which
calls access(R_OK) instead of access(X_OK).
Replacing SystemTools::FileExists with SystemTools::TestFileAccess fixes
this issue.

Fine example of such program is sudo.

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

c35a377f SystemTools: Refactor CollapseFullPath to call getcwd only when needed
019afb6e SystemTools: Drop GetCurrentWorkingDirectory 'collapse' argument
313b2f7a SystemTools: Make SystemToolsStatic singleton private to implementation file

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !174

Many calls to the one-argument `CollapseFullPath` variant already have
an absolute path and just need to collapse it.  Avoid calling `getcwd`
if the result is not needed because it can be an expensive syscall.

The result of `getcwd` is always an absolute canonical path and does not
need to be collapsed.

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

4b537c59 Tests: Handle that root users on linux can always write to files

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !173

Robert Maynard authored 4 years ago and Brad King committed 4 years ago

It is common when running software from a container setup such
as docker that the user is root. Because of this, some permission
checks are pointless as the root user ( uid=0 ) can always do
things such as write to files.

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

0085096e avoid std::string::find() to check for prefix
e3c051e2 SystemTools: create directories with the right permissions on Un*x
bc9a4256 avoid inefficient usage of std::string::substr()
420c3b04 call std::string::clear() instead of assigning ""
8b1a29e1 optimize SystemToolsParseRegistryKey()

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !172

Use compare() instead which will terminate faster if things don't match.

Avoid several memory allocations.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

25b61c12 Directory: make it move constructible and assignable

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !171

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

6621b069 STYLE: Use range-based loops from C++11
cc8fc323 STYLE: Use auto for variable type matches the type of the initializer
91429382 PERF: emplace_back method results in potentially more efficient code
6d20e7c9 STYLE: Prefer = default to explicitly trivial implementations
d07092a0 STYLE: Use default member initialization
4c7f64eb COMP: Prefer const member functions
acc916ed COMP: Prefer const pointer when value does not change
7be4043f STYLE: Prefer c++11 'using' to 'typedef'
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !169

C++11 Range based for loops can be used in

Used as a more readable equivalent to the traditional for loop operating over a
range of values, such as all elements in a container, in the forward direction..

Range based loopes are more explicit for only computing the
end location once for containers.

This check is responsible for using the auto type specifier for variable
declarations to improve code readability and maintainability.

The auto type specifier will only be introduced in situations where the
variable type matches the type of the initializer expression. In other words
auto should deduce the same type that was originally spelled in the source

The check flags insertions to an STL-style container done by calling the
push_back method with an explicitly-constructed temporary of the container
element type. In this case, the corresponding emplace_back method results in
less verbose and potentially more efficient code.

This check replaces default bodies of special member functions with
= default;. The explicitly defaulted function declarations enable more
opportunities in optimization, because the compiler might treat
explicitly defaulted functions as trivial.

Additionally, the C++11 use of = default more clearly expreses the
intent for the special member functions.

Converts a default constructor’s member initializers into the new
default member initializers in C++11. Other member initializers that match the
default member initializer are removed. This can reduce repeated code or allow
use of ‘= default’.

Finds non-static member functions that can be made const because the functions
don’t use this in a non-const way.

This check tries to annotate methods according to logical constness (not
physical constness). Therefore, it will suggest to add a const qualifier to a
non-const method only if this method does something that is already possible
though the public interface on a const pointer to the object:

reading a public member variable calling a public const-qualified member
function returning const-qualified this passing const-qualified this as a
parameter.  This check will also suggest to add a const qualifier to a
non-const method if this method uses private data and functions in a limited
number of ways where logical constness and physical constness coincide:
 - reading a member variable of builtin type
Specifically, this check will not suggest to add a const to a non-const
method if the method reads a private member variable of pointer type because
that allows to modify the pointee which might not preserve logical constness.
For the same reason, it does not allow to call private member functions or
member functions on private member variables.

In addition, this check ignores functions that
 - are declared virtual
 - contain a const_cast
 - are templated or part of a class template
 - have an empty body
 - do not (implicitly) use this at all (see readability-convert-member-functions-to-static).

The check finds function parameters of a pointer type that could be changed to
point to a constant type instead.

When const is used properly, many mistakes can be avoided. Advantages when
using const properly:
 - prevent unintentional modification of data;
 - get additional warnings such as using uninitialized data;
 - make it easier for developers to see possible side effects.

This check is not strict about constness, it only warns when the constness will
make the function interface safer.

The check converts the usage of typedef with using keyword.

cd ${BLDDIR}
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,modernize-use-using  -header-filter=.* -fix
# https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-using.html

The emptiness of a container should be checked using the empty() method
instead of the size() method. It is not guaranteed that size() is a
constant-time function, and it is generally more efficient and also
shows clearer intent to use empty(). Furthermore some containers may
implement the empty() method but not implement the size() method. Using
empty() whenever possible makes it easier to switch to another container
in the future.

cd
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,readability-container-size-empty  -header-filter=.* -fix

Enforce consistency in large projects, where it often happens that a definition
of function is refactored, changing the parameter names, but its declaration in
header file is not updated. With this check, we can easily find and correct
such inconsistencies, keeping declaration and definition always in sync.

Unnamed parameters are allowed and are not taken into account when comparing
function declarations

Enforce consistency in large projects, where it often happens that a definition
of function is refactored, changing the parameter names, but its declaration in
header file is not updated. With this check, we can easily find and correct
such inconsistencies, keeping declaration and definition always in sync.

Unnamed parameters are allowed and are not taken into account when comparing
function declarations

Finds and replaces integer literals which are cast to bool.

cd ${BLDDIR}
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,modernize-use-bool-literals  -header-filter=.* -fix

The check converts the usage of null pointer constants (eg. NULL, 0) to
use the new C++11 nullptr keyword.

cd
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,modernize-use-nullptr  -header-filter=.* -fix

Find and remove redundant void argument lists.