The check finds function parameters of a pointer type that could be changed to
point to a constant type instead.

When const is used properly, many mistakes can be avoided. Advantages when
using const properly:
 - prevent unintentional modification of data;
 - get additional warnings such as using uninitialized data;
 - make it easier for developers to see possible side effects.

This check is not strict about constness, it only warns when the constness will
make the function interface safer.

Kitware Robot authored 6 years ago and Brad King committed 6 years ago

Run the `clang-format.bash` script to update all our C and C++ code to a
new style defined by `.clang-format`.  Use `clang-format` version 6.0.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.

Kitware Robot authored 8 years ago and Brad King committed 8 years ago

Run the `clang-format.bash` script to update all our C and C++ code to a new
style defined by `.clang-format`.  Use `clang-format` version 3.8.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.

Change-Id: Ie3aedc03bfe5c3999d4a077fafb8c6f3bbffc5c5

Per-source copyright/license notice headers that spell out copyright holder
names and years are hard to maintain and often out-of-date or plain wrong.
Precise contributor information is already maintained automatically by the
version control tool.  Ultimately it is the receiver of a file who is
responsible for determining its licensing status, and per-source notices are
merely a convenience.  Therefore it is simpler and more accurate for
each source to have a generic notice of the license name and references to
more detailed information on copyright holders and full license terms.

Our `Copyright.txt` file now contains a list of Contributors whose names
appeared source-level copyright notices.  It also references version control
history for more precise information.  Therefore we no longer need to spell
out the list of Contributors in each source file notice.

Replace KWSys per-source copyright/license notice headers with a short
description of the license and links to `Copyright.txt` and online
information available from "https://cmake.org/licensing#kwsys".

Run the `filter-notices.bash` script to perform the replacements mechanically.
Manually fix up the shebang line in one file.

Change-Id: I8497f7c868664dcf54a8608ab302ad93c860b334

The clang-format tool sorts `#include` lines within contiguous blocks.
Separate blocks with blank lines and sort the include lines within them
so that clang-format does not re-order anything.

Change-Id: I96d6828f470b9a234464972172d46afab322487c

The shell escaping APIs are very specific to CMake and are not used by
other KWSys clients.  They are moving to CMake proper, so drop them from
KWSys.

Change-Id: I422c76f6515d51a352e112828533d6e3fd1a5440

Enable to add extra single quote used by some Watcom tools.

Change-Id: I257bafd1c09c02642e0d793caf7461454bc4b04a

Revert commit: CMake: quote ':' in Windows NMake Makefiles (#9963) -- it was not the right fix and caused mucho other problemo

This converts the KWSys license to a pure 3-clause OSI-approved BSD
License.  We drop the previous license clause requiring modified
versions to be plainly marked.  We also update the KWSys copyright to
cover the full development time range.

This fixes KWSys's unix-style command-line parsing to interpret
backslash escapes inside single-quoted strings.

Add System_Parse_CommandForUnix to the KWSys System interface as a
utility to parse a unix-style command line.  Move the existing
implementation out of ProcessUNIX.  Add a flags argument reserved for
future use in providing additional behavior.

On Windows the KWSys System package generates escapes for command-line
arguments.  This fix enables quoting of the empty string as an argument.
This also adds a test to pass an empty argument to a custom command.

BUG: Fix kwsysSystem_Shell_GetArgumentForWindows to reset the windows trailing backslash count to zero when a make variable reference is encountered.

ENH: Improved escaping in kwsys/System.  Added escape of % for NMake.  Added escape of ; for the VS IDE.

ENH: Added more special unix shell characters that require quoting.  Added escaping of % as %% for shells inside mingw32-make.

ENH: Adding Shell_Flag_EchoWindows option to setup escapes for arguments to the native echo command in a shell.  This special case is needed to avoid adding quotes when passing text to echo in a native windows shell which does no command line parsing at all.

ENH: Re-implemented command line argument shell quoting to support several platforms with one code base.

BUG: Windows_ShellArgument: need to escape if the string contains one of a set of special characters as well as spaces.  Moved test for needing escapes to a separate method kwsysSystemWindowsShellArgumentNeedsEscape.

ENH: Adding 'System' component of C sources to hold system tools written in C.  Moved windows shell command line argument escaping code to kwsysSystem_Windows_ShellArgument and kwsysSystem_Windows_ShellArgumentSize.