The check finds function parameters of a pointer type that could be changed to
point to a constant type instead.

When const is used properly, many mistakes can be avoided. Advantages when
using const properly:
 - prevent unintentional modification of data;
 - get additional warnings such as using uninitialized data;
 - make it easier for developers to see possible side effects.

This check is not strict about constness, it only warns when the constness will
make the function interface safer.

The check converts the usage of typedef with using keyword.

cd ${BLDDIR}
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,modernize-use-using  -header-filter=.* -fix
# https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-using.html

The emptiness of a container should be checked using the empty() method
instead of the size() method. It is not guaranteed that size() is a
constant-time function, and it is generally more efficient and also
shows clearer intent to use empty(). Furthermore some containers may
implement the empty() method but not implement the size() method. Using
empty() whenever possible makes it easier to switch to another container
in the future.

cd
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,readability-container-size-empty  -header-filter=.* -fix

Enforce consistency in large projects, where it often happens that a definition
of function is refactored, changing the parameter names, but its declaration in
header file is not updated. With this check, we can easily find and correct
such inconsistencies, keeping declaration and definition always in sync.

Unnamed parameters are allowed and are not taken into account when comparing
function declarations

Enforce consistency in large projects, where it often happens that a definition
of function is refactored, changing the parameter names, but its declaration in
header file is not updated. With this check, we can easily find and correct
such inconsistencies, keeping declaration and definition always in sync.

Unnamed parameters are allowed and are not taken into account when comparing
function declarations

Finds and replaces integer literals which are cast to bool.

cd ${BLDDIR}
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,modernize-use-bool-literals  -header-filter=.* -fix

The check converts the usage of null pointer constants (eg. NULL, 0) to
use the new C++11 nullptr keyword.

cd
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,modernize-use-nullptr  -header-filter=.* -fix

Find and remove redundant void argument lists.

Ancient CMake versions required upper-case commands.  Later command names
became case-insensitive.  Now the preferred style is lower-case.

EXECUTABLE_OUTPUT_PATH is the old executable location variable.

The target property RUNTIME_OUTPUT_DIRECTORY supercedes this variable
for a target if it is set. Executable targets are otherwise placed in
this directory.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

a1a261ac CMake: Fix psapi lib name on case-sensitive fs

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !170

Julien Schueller authored 5 years ago and Brad King committed 5 years ago

Fix another place missed by commit c3acc96d (CMake: Fix psapi lib name
on case-sensitive fs, 2020-02-13).

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

acee32bd Adding DecodeUrl and GetFilePathFromURI methods

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Michael Migliore <michael.migliore@kitware.com>
Acked-by: Joachim Pouderoux <joachim.pouderoux@kitware.com>
Merge-request: !164

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

44eaaa6e Terminal: Add st-256color to VT100 color support whitelist

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !168

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

ea77593a SystemTools: CopyFileIfDifferent: Fix endless recursion

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !167

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

c3acc96d CMake: Fix psapi lib name on case-sensitive fs

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !166

Fixes detection of GetProcessMemoryInfo on MinGW

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

c2420a42 SystemTools: Revert "CopyFileIfDifferent: Ensure that source is a file"

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !165

The change in commit 573713fa (SystemTools: CopyFileIfDifferent: Ensure
that source is a file, 2020-02-11) breaks existing behavior w.r.t.
symbolic links.  Revert it pending further investigation.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

573713fa SystemTools: CopyFileIfDifferent: Ensure that source is a file

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !163

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

2581cfd1 SystemTools: Update EnableMSVCDebugHook to simulate "Retry"

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !159

Update our report handler to pretend that the user pressed "Retry".
This will continue with what would have happened if there were no
debug hook, such as actually abort()ing the process.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

dfd0521e Terminal: Support GNU make's TTY notification environment variable

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !158

Paul Smith authored 5 years ago and Brad King committed 5 years ago

Starting with release 4.0, GNU make provides for collecting recipe
output and printing it all at once after the recipe is complete, as
well as ensuring that only one rule is printing output at a time.
This allows parallel builds without mangled output.

However, it means that programs run by make do not have a TTY for
their stdout or stderr: make is collecting this.

GNU make 4.1 and above will set an environment variable MAKE_TERMOUT
to a non-empty value if make believes that after it's done collecting
stdout, the results will be displayed on a TTY.

This patch teaches KWsys to check that environment variable and if
set, proceed as if output is going to a TTY.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

a5248df0 CTestCustom: Suppress PGI Community Edition compiler license warnings
b019deea RegularExpression: Suppress VS 2013 warning C4351

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !157

These are not useful in nightly testing results.

The compiler warns on use of `{}` initialization of array members:

    warning C4351: new behavior: elements of array '...' will be
                   default initialized

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

680ab6d2 FStream: Expose is_open publicly
0492cad3 SystemTools: Remove redundant ToWindowsExtendedPath calls

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !155

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

cdd52ce1 RegularExpression: Initialize RegularExpressionMatch arrays fully

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !156

The `RegularExpressionMatch` class added by commit cff58f07
(RegularExpression: New RegularExpressionMatch class, 2017-12-04) has
members with array-of-pointer types.  Use uniform initialization
syntax to initialize all array elements on construction.

This fixes a Clang scan-build 7 warning:

```
RegularExpression.hxx:138:23: warning: The left operand of '==' is a garbage value
  if (this->startp[n] == nullptr) {
      ~~~~~~~~~~~~~~~ ^
```

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

569a1aed Encoding: Add ToWindowsExtendedPath support for wide string

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !153

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

46c55893 Replaced several 0, NULL, and KWSYS_NULLPTR with nullptr
419aaa35 Fixed -Wunused-macros warnings
750da75a Fixed 64 to 32 bit truncation warning by casting
30de8e17 Fixed -Wsign-conversion warnings by adding casts
4de1241f Fixed -Wextra-semi-stmt warning

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !152