The check finds function parameters of a pointer type that could be changed to
point to a constant type instead.

When const is used properly, many mistakes can be avoided. Advantages when
using const properly:
 - prevent unintentional modification of data;
 - get additional warnings such as using uninitialized data;
 - make it easier for developers to see possible side effects.

This check is not strict about constness, it only warns when the constness will
make the function interface safer.

Kitware Robot authored 6 years ago and Brad King committed 6 years ago

Run the `clang-format.bash` script to update all our C and C++ code to a
new style defined by `.clang-format`.  Use `clang-format` version 6.0.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.

+ fix documentation of method name
+ fix some source comment typos

While a process is running, it is possible for other processes such as
NTP to alter the system clock in large jumps.

To make the measurement of how long a process has taken to run
impervious to such large jumps it is helpful to use a monotonic clock.
This is a clock that takes an arbitrary starting point that does not
change.

clock_gettime() is a POSIX method that implements this clock. This is
not available on all platforms, so this commit adds a check for its
presence. If the monotonic timer is available, use that in
kwsysProcessTimeGetCurrent(), otherwise falls back to previous
non-monotonic behaviour.

Some systems / tools don't play nicely with how select is used here.

Adam Weisi authored 7 years ago and Brad King committed 7 years ago

When running a pipeline of child processes, provide clients a way
to get individual results.

Kitware Robot authored 8 years ago and Brad King committed 8 years ago

Run the `clang-format.bash` script to update all our C and C++ code to a new
style defined by `.clang-format`.  Use `clang-format` version 3.8.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.

Change-Id: Ie3aedc03bfe5c3999d4a077fafb8c6f3bbffc5c5

Per-source copyright/license notice headers that spell out copyright holder
names and years are hard to maintain and often out-of-date or plain wrong.
Precise contributor information is already maintained automatically by the
version control tool.  Ultimately it is the receiver of a file who is
responsible for determining its licensing status, and per-source notices are
merely a convenience.  Therefore it is simpler and more accurate for
each source to have a generic notice of the license name and references to
more detailed information on copyright holders and full license terms.

Our `Copyright.txt` file now contains a list of Contributors whose names
appeared source-level copyright notices.  It also references version control
history for more precise information.  Therefore we no longer need to spell
out the list of Contributors in each source file notice.

Replace KWSys per-source copyright/license notice headers with a short
description of the license and links to `Copyright.txt` and online
information available from "https://cmake.org/licensing#kwsys".

Run the `filter-notices.bash` script to perform the replacements mechanically.
Manually fix up the shebang line in one file.

Change-Id: I8497f7c868664dcf54a8608ab302ad93c860b334

The clang-format tool sorts `#include` lines within contiguous blocks.
Separate blocks with blank lines and sort the include lines within them
so that clang-format does not re-order anything.

Change-Id: I96d6828f470b9a234464972172d46afab322487c

Zack Galbreath authored 9 years ago and Brad King committed 9 years ago

Change-Id: I7d588cb060ea17ed4221c55b866cbbebab983e3c

Zack Galbreath authored 9 years ago and Brad King committed 9 years ago

Recompute `TimeoutTime` after `Timeout` changes so that one may modify
the timeout of a process after it has started running by calling the
normal `kwsysProcess_SetTimeout` method.

Change-Id: I460a02d0d3c5f107b844abb56e39f5c844e7e3fb

The ICC frontend on OSX is clang, and therefore the "__clang__" define exists,
but it doesn't support the clang diagnostic pragma syntax.

Change-Id: I6947bd22c77af8066b85a6b00be7cf6019e7d06e

Dmitry Marakasov authored 9 years ago and Brad King committed 9 years ago

Microseconds range from 0 to 999999, so 1000000 is an overflow which
should be processed as well.

Change-Id: I59873504987d6aa416e87aa7f5cd208983217ace

James Johnston authored 9 years ago and Brad King committed 9 years ago

kwsysProcess leaked a file descriptor every time a process would start.
This was causing exhaustion of available file descriptors on some
operating systems (e.g. Mac OS X).

Change-Id: I78eed0755f9766065c36460ffab468b2d7d1df12

James Johnston authored 9 years ago and Brad King committed 9 years ago

kwsysProcess_SetOption now allows you to specify a new
kwsysProcess_Option_CreateProcessGroup option, which creates the
process in a new process group (Windows/UNIX) and a new session
(UNIX).  Child process groups receive signals separately from their
parents.  This allowed for the introduction of the new
kwsysProcess_Interrupt function, which allows one to safely request
the child process in its own group to terminate.  The Ctrl+C handler
also manually sends that signal to child process groups, since it's
no longer automatic.

Change-Id: Id0a420ad65f1b1c1d299ac0eb95fbb8b50a52409

James Johnston authored 9 years ago and Brad King committed 9 years ago

The following applies to any KWSys console app on Windows or UNIX
(e.g. cmake.exe):  The default behavior of such an app when Ctrl+C is
pressed is to call ExitProcess or _exit.  If the user has a
subprocess open (e.g. by way of cmake --build) when this happens, the
subprocess will be orphaned because the kwsys-based program will
immediately exit.  This can lead to odd behavior such as the orphaned
subprocess continuing to run and mix output with the operating system
shell.  We prevent this behavior on Windows by tracking all
subprocesses and waiting for their termination when Ctrl+C is pressed
before allowing the call to ExitProcess to proceed.  On UNIX, we reap
every single child process and then call _exit.

Change-Id: Iebd2eedb1c06719e9797dd5b1309d473145476a8

James Johnston authored 9 years ago and Brad King committed 9 years ago

Change-Id: I821de08dd10b5f1f4af6287a5d7dc6e03e2c1e78

When enabled, ignore all stderr pipe configuration options and
just give the child a copy of stdout as its stderr.

Change-Id: I87a64657cc701b706da78f7bfc56ad0071383372

Consolidate logic to prepare stdin/stdout/stderr in the same way
before starting any processes.  This will simplify alternative
approaches to select the child pipes.

Change-Id: I36175a8cfc2578543103297420908a539ad71a3a

Ben Boeckel authored 10 years ago and Brad King committed 10 years ago

Clang 3.5.0 errors out on the implicit void* -> T* cast.

Change-Id: Ie0b0dd25a32e1a5692900d9f1035a423a056c413

In ProcessUNIX.c, testProcess.c, and testCommandLineArguments1.cxx, add
assert() calls to tell Clang scan-build that we do not expect certain
pointers to be NULL.

Change-Id: I4a2b035cf58198606b4698c9d0e2048a66f15fd0

When we kill a child we send SIGSTOP first so that we can traverse its
child processes recursively.  On unwinding the recursion we then send
SIGKILL.  Current Cygwin has trouble when both signals are sent in quick
succession by the parent process.  Add a usleep(1) after sending the
first signal to give up our time slice and give Cygwin a chance to
process the first signal before sending the second.

Change-Id: I75ab55cf969a0ea6104a9798c761c0ba1fcd1dbc

If a group of processes needs to be terminated recursively the entry in /proc
doesn't need to be kept open during the recursion as all the interesting
information was already read from it. Especially in case of deeper recursion
this lowers the memory pressure.

Change-Id: I95b969f42c8dd68b57cdaf8fc1b705f358f1dc58

Paul Kunysch authored 12 years ago and Brad King committed 11 years ago

The Single UNIX (R) Specification, Version 2 defines "FD_SETSIZE", but
does not specify the effects if it's (re)defined by an application.

Cygwin's newlib headers document that FD_SETSIZE may be defined
by the user [1] and should be >= NOFILE. [2]  Setting it to 16384
uses a value from Cygwin's poll() implementation. [3]

[1]: http://cygwin.com/cgi-bin/cvsweb.cgi/src/newlib/libc/include/sys/types.h?cvsroot=src
[2]: http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/cygwin/include/sys/param.h?cvsroot=src
[3]: http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/cygwin/poll.cc?cvsroot=src

Change-Id: Idc43fc28a398979da1e9289e1080a9fc1090c605

Alan Hourihane authored 12 years ago and Brad King committed 12 years ago

Change-Id: I4e44d61c175e1deb4cecdebfdba5fa05cbdd1e6b