- Mar 04, 2016
-
-
David C. Lonie authored
-
David C. Lonie authored
-
- Mar 03, 2016
-
-
David C. Lonie authored
-
David C. Lonie authored
-
David C. Lonie authored
Otherwise use the array dispatchers. Adapted worker to use vtkDataArrayAccessors for fallbacks on non-dispatchable arrays, and enable optimizations based on array stride.
-
David C. Lonie authored
Most of the changes to Abstract and DataArray were to fix up ambiguous references to 'id' and 'number' and clarify whether they refer to tuples or values. Many docstrings were removed for overridden virtuals. Doxygen will use the base class's docstring for the virtual, which prevents inconsistencies where one instance of the docstring changes but the others are left untouched. Also removed vtkSOADataArrayTemplate::Resizable. This can be reimplemented later in a more general way if needed.
-
David C. Lonie authored
Just copy vtkBuffer instances around, when possible. Added reference counting to vtkBuffer (add vtkObject base). Added test in TestDataArrayAPI. Also removed some unused ivars from vtkAOSDataArrayTemplate (SaveUserArray, DeleteMethod are stored in vtkBuffer).
-
David C. Lonie authored
-
David C. Lonie authored
VTK_ASSUME can be used to provide optimization hints to the compiler by specifying that certain non-obvious conditions are true. This is especially useful for fixing the number of components in an array; if an array is known to have 3 components, adding VTK_ASSUME(array->GetNumberOfComponents() == 3); can allow the compiler to perform advanced loop unrolling and vectorization in certain cases.
-
David C. Lonie authored
vtkDataArray subclasses now use ComponentValue --> TypedComponent TupleValue --> TypedValue for their type-specific methods. # Conflicts: # Rendering/Annotation/vtkScalarBarActor.cxx
-
David C. Lonie authored
While this branch was being developed, __int64 was removed and all supported compilers now provide 'long long'. See fcd6444a.
-
David C. Lonie authored
vtkDataArrayTemplate has been deprecated.
-
David C. Lonie authored
This was added in master while this branch was under development.
-
David C. Lonie authored
-
David C. Lonie authored
-
David C. Lonie authored
Test could not fail, and is superceded by the TestGenericDataArrayAPI.
-
David C. Lonie authored
Filters/Geometry/vtkGeometryFilter.cxx:760:55: warning: 'pixelConvert[4]' may be used uninitialized in this function [-Wmaybe-uninitialized] polys->InsertCellPoint(pts[pixelConvert[i]]);
-
David C. Lonie authored
There's a bug in the reader that result in invalid memory accesses from trying to read data out of an empty array. This patch prevents the invalid reads and prints a warning when the error state is detected.
-
David C. Lonie authored
This lets the PV AngularPeriodicFilter tests pass when mapped arrays are not included in the dispatch list.
-
David C. Lonie authored
This was a temporary benchmark with large memory reqs and no possibility of failure.
-
David C. Lonie authored
When interpolating bits with vtkDataArray::InterpolateTuple, the result passes through a double-type intermediate. The old implementation simply did a static_cast<int>(...) to convert the double to a boolean, which of course result in 'false' unless the interpolated value was exactly 1.0. Now, when the interpolated value falls in [0.0, 0.5) the result is false, while [0.5, 1.0] map to true.
-
David C. Lonie authored
-
David C. Lonie authored
-
David C. Lonie authored
-
David C. Lonie authored
-
David C. Lonie authored
The old syntax means the referrer type (not the referee type) should be const, which is not valid. The new typedef provides the intended behavior.
-
David C. Lonie authored
Add fallback worker implementations to vtkDataArray.cxx and enable API tests for arrays that are not included in the vtkArrayDispatch array list.
-
David C. Lonie authored
The heavy templating was causing compilation issues (excessive memory usage and compile times). This patch resolves those issues.
-
David C. Lonie authored
While this is somewhat nonsensical, it's required to properly export instantiations of the template on older clang versions. Without it, undefined symbol errors were produced from: $ clang --version Apple clang version 3.1 (tags/Apple/clang-318.0.58) (based on LLVM 3.1svn) Target: x86_64-apple-darwin11.4.2 Thread model: posix when linking to vtkCommonCore.
-
David C. Lonie authored
-
David C. Lonie authored
vtkArrayDownCast will downcast a vtkAbstractArray to a more derived class using FastDownCast, if available. If FastDownCast is not supported by the the array, the slower SafeDownCast is used instead. The vtkArrayDownCast_FastCastMacro and vtkArrayDownCast_TemplateFastCastMacro are used to tell vtkArrayDownCast when FastDownCast is available for a given array (or set of templated arrays).
-
David C. Lonie authored
The Test function call here was being resolved to some other 'void Test()' function, but only on MSVC (tested on 2010), rather than the intended member function. Changing the name to DoTest gets this code compiling again.
-
David C. Lonie authored
-
David C. Lonie authored
We'll now include all extern template declarations in vtkAoSDataArrayTemplate, as there are now places (such as the vtkArrayDispatchArrayList header) that just include vtkAoSDataArrayTemplate.h, but need to be able to find the existing instantiations in vtkCommonCore.
-
David C. Lonie authored
vtkFloatArray no longer inherits TypedDataArray, so some adjustments were needed. Moved some logic from vtkPeriodicDataArray into vtkAngularPeriodicDataArray, since the restriction to vectors/tensors isn't required for the superclass.
-
David C. Lonie authored
vtkTypeTemplate was causing link issues on some platforms with the new AoS/SoA data array split, and the new macro is cleaner and more consistent with the regular style. The direct use of typeid(typename).name() is more efficient than the older local-static string cache used by vtkTypeTemplate. On GCC release builds, GetClassNameInternal now compiles to mov %eax, <static address in RO memory> ret
-
David C. Lonie authored
-
David C. Lonie authored
Also fix some bad error messages in TestDataArrayAPI.
-
David C. Lonie authored
- TypedDataArray is now a subclass of vtkGenericDataArray, rather than vtkDataArray. - !! Changes to TypedDataArray virtual API: - New typedefs: - ValueType inherited from Superclass. - ReferenceType also inherited from Superclass. - Several methods made const to match GenericDataArray: - GetValue - GetTupleValue - - New virtual methods: - GetComponentValue - SetComponentValue - Allocate - Resize - GetValue return type changed to ReferenceType. - GetValueReference return type changed to ReferenceType. - Update FastDownCast / GetArrayType system.
-
David C. Lonie authored
Also remove vtkGenericDataArrayMacros.
-