Brad King authored 5 years ago and Kitware Robot committed 5 years ago

5d8af0d6 SystemTools: Optimize range loop in RelativePath method
815cc593 SystemTools: Optimize range loop in FindProgramPath method
ac8d2033 SystemTools: Optimize range loop in FindLibrary method
c7e3ab12 SystemTools: Optimize range loop in FindProgram method
8c9ca162 SystemTools: Optimize range loop in FindProgram method
9992f69b SystemTools: Optimize range loop in FindName method
d6235796 SystemTools: Optimize iterator lifetime in JoinPath
00a3a436 SystemTools: Update buffered env value string only on a change

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !138

In `SystemToolsStatic::GetEnvBuffered` a pointer to the data of an internal
`std::string` is returned.  This string should only be updated on a change to
keep already emitted pointers valid as long as possible.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

9e8e9ba0 DynamicLoader: avoid the min/max macros from windows.h
efb006b9 DynamicLoader: include stdio.h for _snprintf

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Brad King <brad.king@kitware.com>
Merge-request: !137

Brad King authored 6 years ago and Kitware Robot committed 6 years ago

92334e76 SystemTools: CopyFileAlways: avoid copying file over self

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !136

Ben Boeckel authored 6 years ago and Kitware Robot committed 6 years ago

971809c5 DynamicLoader: test the SearchBesideLibrary flag
40d9e482 DynamicLoader: support loading sibling libraries on Windows
d17291ad DynamicLoader: support loading libraries using flags
cf6b5f69 DynamicLoader: use Encoding::ToWindowsExtendedPath for the libname
30198dbc DynamicLoader: fix error reporting on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Brad King <brad.king@kitware.com>
Merge-request: !135

Since commit 228c60b8 (SystemTools: CopyFileAlways: try to create a
cheap CoW clone first, 2018-12-07) on Linux copying a file over itself
by specifying `.` as the destination leaves behind an empty file.  This
has long occurred on Windows too.  Move our existing same-file check
to after we know the real destination file.

This converts the path to a format suitable for passing to Windows APIs.

Windows was reporting errors in `wchar_t` which was not reinterpreted as
UTF-8 which is expected from kwsys errors. This basically made error
messages appear as truncated since the UCS-2 byte array had embedded
byte NUL characters.

Brad King authored 6 years ago and Kitware Robot committed 6 years ago

8b58389c SystemTools: Move private ReplaceString method to SystemToolsStatic class
7512ab8c SystemTools: Move private FindIsFullPath method to SystemToolsStatic class
a1271fea SystemTools: Move private FindName method to SystemToolsStatic
d9db985f SystemTools: Move private GetEnvImpl method to SystemToolsStatic
9e32eecd SystemTools: Move private type definitions to SystemToolsStatic
67eb2674 SystemTools: Move SystemTools::TranslationMap to SystemToolsStatic
706919be SystemTools: Move SystemTools::PathCaseMap to SystemToolsStatic
7c273c83 SystemTools: Move SystemTools::EnvMap to SystemToolsStatic
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !134

The new private class SystemToolsStatic is supposed to hold all static
SystemTools variables in a single singleton class.  Static SystemTools
variables will be moved to SystemToolsStatic in following commits.  This patch
only adds the class skeleton type, its allocation and deletion.

Brad King authored 6 years ago and Kitware Robot committed 6 years ago

db462838 SystemTools: Revert "Use copyfile(3) to clone files on macOS"

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !133

Revert commit 7c71e879 (SystemTools: Use copyfile(3) to clone files on
macOS, 2019-03-05) because it changed the semantics of the copy
operation w.r.t. the timestamp left on the new file.  Further
investigation is needed to use `copyfile` while preserving semantics.

Brad King authored 6 years ago and Kitware Robot committed 6 years ago

7c71e879 SystemTools: Use copyfile(3) to clone files on macOS

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !131

This makes file copying a O(1) COW operation on AFPS and
macOS 10.13.

Brad King authored 6 years ago and Kitware Robot committed 6 years ago

363bf5ab Configure: Drop Large File Support macro definitions

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !130

Historically we have defined macros like

* `_LARGEFILE_SOURCE`
* `_LARGEFILE64_SOURCE`
* `_LARGE_FILES`
* `_FILE_OFFSET_BITS`

in `Configure.h` to activate large file support in system headers.  This
requires consuming projects to include the header at the beginning of
every translation unit in order to get the macros defined consistently.

Instead these macros should be defined by the build system on the
compiler command line.  Drop them from KWSys in favor of that approach.
The macros are not needed as often as they once were anyway.

Brad King authored 6 years ago and Kitware Robot committed 6 years ago

6090d36b Glob: Use the default copy constructor and assignment operator

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !126

Brad King authored 6 years ago and Kitware Robot committed 6 years ago

95ced423 hashtable: delete assignment operator instead of poisoning it

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !125

Albert Astals Cid authored 6 years ago and Brad King committed 6 years ago

No need to write ones that do what the default one does, makes sure that
if a new field is introduced it won't be forgotten in any of the two.