Cory Quammen authored 4 months ago and Lucas Givord committed 3 months ago

Previously, only float values were accepted as time values, preventing
"time" or "TimeValue" nodes with dtype of double or int from being
used to define time. Fixed by checking that an that the dtype is a
number instead.

(cherry picked from commit eab43cc0)

The VTKHDF File Format contains a bug and has been bump to 2.3. The
vtkHDFReader has been updated to fix this issue too.

and other minor fixes

- This commit is a first step to getting the widget to deserialize
correctly because during deserialization a different renderer
is assigned as the default renderer.
- When another renderer is provided, this commit carefully removes
the previous reorientation observer. If the widget was previously
enabled, it replaces the older renderer in the render window with the
new renderer. Otherwise, upon deserialization, the render window had
an extra renderer which originated from the constructor of
`vtkCameraOrientationWidget``.
- Updated baseline images which used the camera orientation widget
  because the widget now resizes itself to correct proportions

It was not producing the correct point IDs for meshes with polyhedrons only.
Also fast path was added when no polyhedrons are present. Additionally,
documentation was added about why copying happens, and the code was simplified.

Mickael PHILIT authored 5 months ago and Mathieu Westphal (Kitware) committed 4 months ago

(cherry picked from commit c0b29bb1)

Mickael PHILIT authored 5 months ago and Mathieu Westphal (Kitware) committed 4 months ago

(cherry picked from commit a7bdf2ee)

Jean Fechter authored 5 months ago and Mathieu Westphal (Kitware) committed 4 months ago

(cherry picked from commit d9ae0820)

Jean Fechter authored 5 months ago and Mathieu Westphal (Kitware) committed 4 months ago

The wrong copy constructor of Node was called, taking the ownership of data it should not.
Therefore, the data was freed too early.

(cherry picked from commit 7bd1f0b3)

Mickael PHILIT authored 5 months ago and Mathieu Westphal (Kitware) committed 4 months ago

(cherry picked from commit 5c4687d6)

Ben Boeckel authored 5 months ago and Mathieu Westphal (Kitware) committed 4 months ago

The header has a method which returns a deprecated type. MSVC warns
about such usage, so suppress it.

(cherry picked from commit 700f5d1e)

Ben Boeckel authored 5 months ago and Mathieu Westphal (Kitware) committed 4 months ago

(cherry picked from commit 35c93c98)

Ben Boeckel authored 5 months ago and Mathieu Westphal (Kitware) committed 4 months ago

(cherry picked from commit 230a3254)

Ben Boeckel authored 5 months ago and Mathieu Westphal (Kitware) committed 4 months ago

The macro goes after the `struct` keyword.

(cherry picked from commit cf3e8667)

Ben Boeckel authored 5 months ago and Mathieu Westphal (Kitware) committed 4 months ago

(cherry picked from commit 6fea24e9)

Previously, only float values were accepted as time values, preventing
"time" or "TimeValue" nodes with dtype of double or int from being
used to define time. Fixed by checking that an that the dtype is a
number instead.

Léon Victor authored 5 months ago and Jean Fechter committed 4 months ago

The tetrahedron reading logic used a non-tetrahedron-specifc `vtkUnstructredGrid::InsertNextCell` call which performed poorly due to a large amount of time spent managing a `std::set`, and struggling with memory allocation previsions.

With this change we instead handle the cell ID uniqueness ourselves and use the tetrahedron-specific API, resulting in a 2~3x speedup on a large dataset.

The logic is also refactored a bit for readability

Fix an int overflow that could occur when seeking a very large offset (it did happen in the geometry file)

Overall performance improvements

Reader regarding overlappingAMR can have an overflow issue due to his
offset. Few places in the writer should rely on vtkIdType instead of int
too.

INFO log messages will be logged by default to stdout, but this
logging level was used in a number of places throughout VTK, leading
to unexpected output messages. VTK should not print messages to stdout
by default except when reporting a warning or error condition. This
commit changes messages that do not report warnings/errors to TRACE so
messages will be logged only when the logging level is specifically
requested to be more verbose.

Since vtkIOEnSightCxxTests-MPI is optional, it is not necessary
to explicitly list ParallelMPI in TEST_DEPENDS.

Make sure to test temporal overlappingAMR for the version 2.2 and 2.3

The VTKHDF File Format contains a bug and has been bump to 2.3. The
vtkHDFReader has been updated to fix this issue too.