There's some case where a worker thread wakes up and doesn't see that it
needs to bail properly. Ensure that each thread wakes up at least once a
second to force a re-check.

Fixes: #18612

Timothee Chabat authored 2 years ago and Kitware Robot committed 2 years ago

483bdd41 Replace InteractionWidgetsCxx-TestLineWidget2 baseline
f2e5e191 Add line constraint for vtkHandleRepresentation
a8ecab7d Cleanup code in InteractionWidgets module

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !9336

Spiros Tsalikis authored 2 years ago and Kitware Robot committed 2 years ago

4e0ba002 vtkTableBasedClipDataSet: Support again GenerateClipScalars
d7900fa7 vtkTableBasedClipDataSet: Avoid promoting conversion to float
2123f764 vtkGeometryFilter: Initialize BaseThread local member
be82071b vtkGeometryFilter: Deallocate MemoryPools as soon as they are not needed
496348cc vtkGeometryFilter: Use 64bits only when they are available
ec63ac73 vtkGeometryFilter: Use wholeExtent and fix face orientation
51d217a1 vtkGeometryFilter: Handle Piece Invariant

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Yohann Bearzi <yohann.bearzi@kitware.com>
Merge-request: !9367

Sean McBride authored 2 years ago and Kitware Robot committed 2 years ago

1dc35f76 Added missing libraries to SimpleCocoaVTK Xcode project

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: David Gobbi <david.gobbi@gmail.com>
Merge-request: !9351

Sean McBride authored 2 years ago and Kitware Robot committed 2 years ago

1dc35f76 Added missing libraries to SimpleCocoaVTK Xcode project

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: David Gobbi <david.gobbi@gmail.com>
Merge-request: !9351

Ben Boeckel authored 2 years ago and Kitware Robot committed 2 years ago

1f6423d3 vtkComposite*Pass: avoid string shenanigans
2cb09006 vtkMFIXReader: simplify string shenanigans
19b1daec vtkAbstractArray: remove unnecessary `void` argument
75856f4f vtkScatterPlotMatrix: simplify iterator declaration
25a865e3 vtkExodusIIReader: make `GetPartName` return valid memory
486ccb9f vtkArrayWriter: remove unnecessary overload
3df7b6a8 vtkNamedColors: use `find_first_of('c')`
88045cea clang-tidy: avoid unnecessary copies
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !9374

Yohann Bearzi (Kitware) authored 2 years ago and Kitware Robot committed 2 years ago

658b6d36 vtkFeatureEdges: fix behavior with ghost cells.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Spiros Tsalikis <spiros.tsalikis@kitware.com>
Merge-request: !9366

Yohann Bearzi (Kitware) authored 2 years ago and Kitware Robot committed 2 years ago

658b6d36 vtkFeatureEdges: fix behavior with ghost cells.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Spiros Tsalikis <spiros.tsalikis@kitware.com>
Merge-request: !9366

Instead, just use the stringstream directly.

The use of `strcpy` and `strncpy` were blatently unsafe here. Simplify
the code.

The return uses an implicit `const char*` operator which returns
`.c_str()`. Since the backing memory is gone, we need to make it safe
for at least the caller. Still very thread-unsafe.

The basic `T` overload handles this case already.

It performs better than the `find_first_of("c")` overload because it can
be optimized to only search for one character.

The test hasn't been used in a long time.

The header should be present in IDEs.

Andrew Maclean authored 2 years ago and Kitware Robot committed 2 years ago

7e1fe828 Using unsigned char instead of int when returning std::tolower()

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: David Gobbi <david.gobbi@gmail.com>
Merge-request: !9375

David Gobbi authored 2 years ago and Kitware Robot committed 2 years ago

2002a12c Null vtkCocoaGLView to vtkCocoaRenderWindow pointer in dtor

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Sean McBride <sean@rogue-research.com>
Merge-request: !9372

David Gobbi authored 2 years ago and Kitware Robot committed 2 years ago

2002a12c Null vtkCocoaGLView to vtkCocoaRenderWindow pointer in dtor

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Sean McBride <sean@rogue-research.com>
Merge-request: !9372

This functionality was accidentally removed in a previous commit.

Same code as vtkDataSetSurfaceFilter

Sean McBride authored 2 years ago and David Gobbi committed 2 years ago

vtkCocoaGLView keeps a pointer to the vtkCocoaRenderWindow that created it.
When vtkCocoaRenderWindow (a C++ object) is deallocated, the vtkCocoaGLView
(an Objective-C object) doesn't get notified. Therefore vtkCocoaGLView's
pointer to the vtkCocoaRenderWindow can eventually reference a deallocated
object.

So, now, in the vtkCocoaRenderWindow destructor, check if it was the
vtkCocoaRenderWindow that created the vtkCocoaGLView (something we already
keep track of) and if so null out the relationship.