The boolean member `Destroying` needs to be atomic because there is one
location in the code that uses it without mutex
protectionThreadedCallbackQueue, fixing race condition

The boolean member `Destroying` needs to be atomic because there is one
location in the code that uses it without mutex protection

Yohann Bearzi (Kitware) authored 9 months ago and Kitware Robot committed 9 months ago

e2bd81d2 Particle tracer: make it inherit vtkTemporalAlgorithm

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Spiros Tsalikis <spiros.tsalikis@kitware.com>
Merge-request: !10852

Jaswant Panchumarti (Kitware) authored 9 months ago and Kitware Robot committed 9 months ago

88b437d7 ci: upgrade wasm jobs to run tests in chrome binaries on windows and linux
bc3e52b6 Prep VTK C++ tests to run in browsers
b6c6dfbf Add option to enable 64-bit and threads with emscripten
82f050fe Fix -Wformat warning in vtkX3DExporterXMLWriter
37da2e72 Fix -Wformat warning in vtkUnstructuredGridToCellGrid
892c78c5 Fix -Wformat warning in vtkMNITagPointWriter
692ccae8 Fix -Wformat warning in vtkDebugLeaks
49fd1072 Fix -Wunused-but-set-variable warning in vtkDGRenderResponder
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !11099

Louis Gombert authored 9 months ago and Kitware Robot committed 9 months ago

0e3ea80f VTKHDF Support writing Partitioned data in external files

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Lucas Givord <lucas.givord@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11101

- refactored the previous webassembly job into dedicated architecture and platform relevant jobs
- add wasm{32,64}_emscripten_{linux,windows}_chrome build and test jobs
- right now, rendering tests which require OpenGL are disabled on linux.
- updates node to 22.0.0 in order to use wasm64 experimental feature
- adds new scripts to download chrome-for-testing binaries.
- adds new scripts to download emsdk tarballs.
- move wasm32-emscripten-windows-chrome into quick stage

Sankhesh Jhaveri authored 9 months ago and Kitware Robot committed 9 months ago

26865c14 Release note for component names in vtkImageAlgorithm
a52c76af ImageAlgorithm: Ensure that component names are copied downstream

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Acked-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11107

Jaswant Panchumarti (Kitware) authored 9 months ago and Kitware Robot committed 9 months ago

54b89bbd Exclude marshalling of context parameters in Cocoa, Win32 OpenGL render window
b9475734 Keep objects created during serialization alive
4ddf1f83 Exclude pointer parameters in X opengl render window from serialization
5041d73b Automate marshalling code generation for vtkCollection
f18c03f7 WrapSerDes: Add support for C-style enums and scoped enums
86101207 WrapSerDes: Extend code generation to more types of properties
5155fb14 Adapt marshal macro annotation script to convert from auto to manual.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !11139

Louis Gombert authored 9 months ago and Kitware Robot committed 9 months ago

c04b0dce AxisActor2D: clamp number of labels to VTK_MAX_LABELS

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Reviewed-by: Nicolas Vuaille <nicolas.vuaille@kitware.com>
Merge-request: !11153

Mathieu Westphal (Kitware) authored 9 months ago and Kitware Robot committed 9 months ago

d7f0efdc HTG: Fix an issue in distributed with vtkRandomHyperTreeGridSource

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Louis Gombert <louis.gombert@kitware.com>
Reviewed-by: Thomas Galland <thomas.galland@kitware.com>
Merge-request: !11152

The new UseExternalComposite option writes individual vtkPartitionedDatasets in different VTKHDF files for vtkPartitionedDataSetCollection and vtkMultiBlockDataSet. The main file containing the assembly uses external links to reference them.

- enablesr Rendering{Core, OpenGL}CxxTests in browser with vtk.wasm.
- upgrades to CI can be found in the next commit.
- all C++ tests are run with a python script Testing/WebAssembly/runner.py. This script coordinates the entire wasm testing process.
- the runner.py script generates a html file per unit test at runtime, serves the html, js and wasm files with a http server and opens the URL in a browser. It implements some usefule POST/GET actions which enable C++ tests to preload/dump files and forward stdout/stderr/exit codes to the python process.
- this commit introduces vtkEmscriptenTestUtilities which can load data files and baseline images required by a c++ unit test from a browser sandbox.

- this API works in wasm64 and web-workers
- the version of sdl2 ported by emscripten did not.
- deprecates vtkSDL2OpenGLRenderWindow for 9.4
- include vtkOpenGLOptions at the top of root CMakeLists.txt
  so that vtk_module_scan sees VTK_OPENGL_USE_GLES

- this works in wasm64 and web workers
- the version of sdl2 ported by emscripten did not work in 64-bit and web workers.
- cleaned up cmake code path taken VTK_USE_SDL2 is enabled. vtkSDL2RenderWindowInteractor should still build when enabled.

`vtkTemporalAlgorithm` embeds time series managenement that is
compatible with stock VTK or in situ using Catalyst. The particle
tracers subclassing `vtkParticleTracerBase` managed time in
a very convoluted way, causing a memory leak when running in situ.
Time management is now entirely delegated to its superclass, which
makes the code more maintainable and easier to understand.

The P filters have been deprecated. MPI logic is now embedded
in the base classes.

Some API has been deprecated, specifically the API letting someone to
change the start time or termination time of the simulation. It was not
tracktable to add this logic layer in `vtkTemporalAlgorithm`, and one
can already subsample the time series by modifying the information key
`TIME_STEPS` in `RequestInformation`.

`vtkParticlePathFilter` seemed not to work at all. ParaView has its own
custom version of this filter (`vtkInSituParticlePath`), which can now
be replaced by the VTK`s one, as it now works as expected.

Sankhesh Jhaveri authored 9 months ago and Kitware Robot committed 9 months ago

f4cd4d43 use smart pointer to manage lifetime of vtkPolyData object
748e3f98 fix incorrect light updates
00ed4773 fix vtkAnariCameraNode not updating the ANARIFrame correctly
530ee040 further cleanups
771a0bc0 fix leaked volume in vtkAnariVolumeMapperNode
e2cd2ae1 remove redundant code paths in vtkAnariRendererNode
ac0012ae fix surface object leak
9283cca3 do not include ANARI headers in any VTK headers
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !11021

- Objects created when serializing properties through RHS getter function are kept alive by the context.
- They will get cleaned up by vtkObjectManager when unused objects get pruned.

- Display* and Window types are not supported

- the vtkWrapSerDes tool can now generate code for properties
that resemble collection of vtkObjects.

- Finishes the implementation to tackle both kinds of enums.
- Paraphrased enum detection code from vtkWrapPython

- adds new ADD_NODISCARD and REMOVE_NODISCARD property type
for int AddItem(type) and bool RemoveItem(type) methods
- serialize properties of type GET_RHS and GET_MULTI
- refactors out common functions to detect method types into
vtkParseMethodType.h

Mathieu Westphal (Kitware) authored 9 months ago and Kitware Robot committed 9 months ago

f4779a1b BUG: DICOMParser: UT uses 4-byte value lengths, not 2-byte ones

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: David Gobbi <david.gobbi@gmail.com>
Merge-request: !11149

Mathieu Westphal (Kitware) authored 9 months ago and Kitware Robot committed 9 months ago

a4cb38ae Fix vtkXMLUnstructuredGridReader not importing .vtu with NULL cell array

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11148