Ben Boeckel authored 3 months ago and Kitware Robot committed 3 months ago

a3db6c62 ci: exclude geometry shader issues on macOS tests
647bda9d gitlab-ci: update to Xcode 16.1

Acked-by: Kitware Robot <kwrobot@kitware.com>
Rejected-by: buildbot <buildbot@kitware.com>
Merge-request: !11772

Ben Boeckel authored 4 months ago and Kitware Robot committed 4 months ago

82980672 matplotlib: use kwargs for `FontProperties` arguments

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11773

This has been deprecated and will be removed in a future release.
Migrate to kwargs instead.

Ben Boeckel authored 4 months ago and Kitware Robot committed 4 months ago

6c68c368 vtkTesting: clamp negative SSIM values
f053b934 vtkTesting: handle SSIM's [-1,1] range
7a07dd33 vtkTesting: fix typos in log string and comment
a450694a vtkTesting: fix string allocation
9692d102 TestIOSSExodusParallelWriter: fix compilation without MPI
5b1ff455 IO/IOSS/Testing: remove stray comma in source list
f0c476fa Relaxed overly tight floating-point comparison
b95a6030 ci: exclude floating point precision issues
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !11675

When SSIM returns a negative value, the histogram bucketing ends up
writing to out-of-bounds memory. Don't do that and instead shift the
buckets to account for the full range of values that are possible.

Finally, add commentary on the code.

See commit cd75f4b9618cb62e623c4adf88c5da0b346e2a83 which applied this
to `master` and `release`.

Co-authored-by: Spiros Tsalikis <spiros.tsalikis@kitware.com>

`newFileName` is deleted using `delete[]`, so allocate it with `new[]`.

Sean McBride authored 11 months ago and Ben Boeckel committed 4 months ago

This fixes a test failure on arm64 Macs, with default compiler options (that is, without `-ffp-model=strict`), where the dist2 value is not exactly zero but very tiny (due to fma, fused multiply add).

Specifically, in the UnitTestCells test it previously output:

```
Testing EvaluatePosition in/out test...cell center failed inOut: 1 point: -1.04083e-17, 0, 0-> pcoords: 0, 0, 0: closestPoint: -1.04083e-17, 0, 0 dist2: 1.08334e-34 weights: -0.0625 -0.0625 0.5625 0.5625
vtkCubicLine FAILED
```

Also fixed unrelated spelling/typo.

Co-authored-by: David Gobbi <david.gobbi@gmail.com>
(cherry picked from commit d204cfba)

New Xcode defaults to `-ffp-contract=on` which allows for fusing
floating point operations. This changes effective precision which these
tests are sensitive to. See referenced issue for details.

See: #19418
(cherry picked from commit 5adcac19)

(cherry picked from commit ee16c509)

(cherry picked from commit 45b5fbb3)

(cherry picked from commit 23c47aa0)

(cherry picked from commit 5f574baf)

(cherry picked from commit 9da16ff1)

Clang (rightly) detects that the `PyCFunction` cast is between invalid
function pointer types. Ignore the warning in-code because we know it is
fine due to the `METH_KEYWORDS` flag for the method.

(cherry picked from commit e83f01c9)

Found with Xcode 15.4 as a warning.

(cherry picked from commit 03b9afcd)

Ben Boeckel authored 4 months ago and Kitware Robot committed 4 months ago

d7ff50a9 Fix #19552.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: David Thompson <david.thompson@kitware.com>
Merge-request: !11739

David Thompson authored 4 months ago and Ben Boeckel committed 4 months ago

This also forces all inclusions of the `Singleton.h` header
to use angle brackets (since in theory third-party libraries
may be in system paths and even when provided by VTK should
use `-isystem` instead of `-I`).

(cherry picked from commit 615c9f21)

Ben Boeckel authored 4 months ago and Kitware Robot committed 4 months ago

9eb732a5 gitlab-ci: remove `dependencies` from jobs

Acked-by: Kitware Robot <kwrobot@kitware.com>
Rejected-by: buildbot <buildbot@kitware.com>
Reviewed-by: Ryan Krattiger <ryan.krattiger@kitware.com>
Merge-request: !11721

Lucas Givord authored 4 months ago and Kitware Robot committed 4 months ago

93abfb56 vtkSocket: fix win32 error handling
cd00a057 vtkHyperTreeGridAxisCut: add test with coincident plane
ffbe4bd9 vtkHyperTreeGridAxisCut: fix floating point number comparison
1fa1ebf3 TableBasedClipDataSet add test
1fcd274d TableBasedClipDataSet scalars deleted array fix
9ec20c8a ScatterPlot: Fix an issue with active plot not updating
de5bd541 vtkConduitToDataObject: accept all numbers as time values
dabeeb0d fix: add QEvent::HoverMove event to interaction

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Reviwed-by: Nicolas Vuaille <nicolas.vuaille@kitware.com>
Merge-request: !11704

Historically, `needs` specifies the jobs which need to complete
successfully and `dependencies` specifies the jobs which provide
artifacts which should be used. Modern GitLab discourages using both as
`needs` now supports an `artifacts` key to say "depend on but do not use
artifacts", so remove `dependencies` and use `needs:artifacts` where
necessary.

See: https://docs.gitlab.com/ee/ci/yaml/#needsartifacts

Lucas Givord authored 4 months ago and Kitware Robot committed 4 months ago

27afa562 vtkHDFReader: fix the ovelappingAMR regarding array naming
3a34dba4 fix(VTKHDF data): version of the overlappingAMR was incorrect
1f8d1201 VTKHDF: bump minor version to 2.3 for temporal OverlappingAMR

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Reviewed-by: Louis Gombert <louis.gombert@kitware.com>
Merge-request: !11701

Previously when encountering an error during a Receive() call, server
hangs indefinitely as only WSAENOBUFS was checked.

For WSAECONNABORTED we cannot know if the disconnection is expected or
not so we don't output an error but log a trace for debugging purpose.

(cherry picked from commit c86e3aaa)

Thomas Galland authored 5 months ago and Lucas Givord committed 4 months ago

(cherry picked from commit 8ec1d44d)

Thomas Galland authored 5 months ago and Lucas Givord committed 4 months ago

Fix a bug where the cut plane wasn't considered as intersecting HTG cells due to precision
loss during floating point comparison.

(cherry picked from commit 08a5f4aa)

Jean Fechter authored 5 months ago and Lucas Givord committed 4 months ago

(cherry picked from commit e6f61ea5)

Jean Fechter authored 5 months ago and Lucas Givord committed 4 months ago

(cherry picked from commit facca32c)

Mathieu Westphal (Kitware) authored 5 months ago and Lucas Givord committed 4 months ago

(cherry picked from commit 0692322c)

Cory Quammen authored 5 months ago and Lucas Givord committed 4 months ago

Previously, only float values were accepted as time values, preventing
"time" or "TimeValue" nodes with dtype of double or int from being
used to define time. Fixed by checking that an that the dtype is a
number instead.

(cherry picked from commit eab43cc0)

Raimund Schlüßler authored 5 months ago and Lucas Givord committed 4 months ago

(cherry picked from commit 2617ad04)

The VTKHDF File Format contains a bug and has been bump to 2.3. The
vtkHDFReader has been updated to fix this issue too.

The VTKHDF spec allows temporal overlappingAMR since 2.2. This dataset
has a version of 2.1, updated to follow correctly the spec

Few datasets name are inconsistents between temporal OverlappingAMR and
other vtk datasets as we miss an 's' for the plural.

It concerns:
- NumberOfBox -> NumberOfBoxes
- AMRBoxOffset -> AMRBoxOffsets
- Point/Cell/FieldDataOffset -> Point/Cell/FieldDataOffsets

Its fix in the VTKHDF File Format version 2.3.