Skip to content
Snippets Groups Projects
  1. Jun 09, 2021
  2. Jun 08, 2021
  3. Jun 07, 2021
  4. Jun 04, 2021
  5. Jun 02, 2021
  6. May 29, 2021
  7. May 28, 2021
  8. May 27, 2021
  9. May 25, 2021
  10. May 24, 2021
  11. May 21, 2021
  12. May 20, 2021
  13. May 19, 2021
  14. May 18, 2021
  15. May 14, 2021
  16. May 13, 2021
  17. May 12, 2021
    • Brad King's avatar
      Ninja: Restore support for Fortran in a symlinked build tree · 3a715344
      Brad King authored
      Since commit f3eed2c4 (cmGlobalNinjaGenerator: use P1689 dependency
      file format for Fortran, 2019-03-12, v3.20.0-rc1~454^2), Fortran stopped
      working in a build tree whose path contains a symlink.  The reason is
      that the P1689r3 format's `work-directory` field gets populated with the
      realpath (via `getcwd`) of the build tree instead of the logical path to
      the build tree used for generating relative paths in `build.ninja`.
      This causes the `Fortran.dd` file to get absolute (real)paths to `.o`
      files, and Ninja does not match them with the relative `.o` file paths
      in `build.ninja`.
      
      Fix this by dropping use of the `work-directory` field.  This restores
      our prior approach of generating paths in the dyndep file using the same
      forms of paths received from the buildsystem generator.  The P1689r3
      paper's format may need to be revised to account for this.
      
      Fixes: #21683
      3a715344
    • Robert Maynard's avatar
  18. May 11, 2021
  19. May 10, 2021
  20. May 08, 2021
    • Craig Scott's avatar
      ExternalProject: Ensure git fetch if updating to hash we don't have yet · 5e941a54
      Craig Scott authored
      In ac6a4d48 (ExternalProject: Improve robustness of update step,
      2020-10-17), the method used to check whether we already have a
      commit or not was changed from using git rev-list to git rev-parse.
      The new logic assumed rev-parse would output nothing if given a commit
      hash it didn't know about, but it simply prints the hash again without
      raising an error in this scenario. Amend that logic by adding ^{commit} to
      the ref to ensure we do get an error if that ref is not currently known.
      
      Fixes: #22166
      5e941a54
Loading