- Feb 21, 2025
-
-
Adds __attribute() for icc, __inline and __forceinline for MSVC. Since these are used in vtkSetGet.h, it's necessary for the wrappers to be able to handle them. (cherry picked from commit 71a07324)
-
Cory Quammen authored
This fixes a compilation error on Intel Classic compilers. (cherry picked from commit 5ff030e5)
-
- Feb 11, 2025
-
-
18a38103 XdmfValuesHDF: Print error when there is a ranks mismatch f6c748e2 vtkPiecewiseFunction: actually assign a fallback SearchMethod 382c038e vtkImageToStructuredPoints: fix improper bounds alignment 6d8305b9 vtkPostgreSQLDatabase: factor out clamping 7204b5be vtkAxis: fix clamping assignment 788628b4 vtkImplicitModeller: factor out clamping 523e1f61 vtkSelectionSource: factor out clamping 2bb8a912 vtkCamera: clamp ViewAngle before updating ... Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
buildbot <buildbot@kitware.com> Reviewed-by:
Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com> Reviewed-by:
Nicolas Vuaille <nicolas.vuaille@kitware.com> Merge-request: !11909
-
- Feb 10, 2025
-
-
(cherry picked from commit 780a8baa)
-
The `type` value that was just verified as out-of-range is still set after the block, so instead update it so the single assignment at the end is shared. (cherry picked from commit 9c6c952e)
-
(cherry picked from commit 2e9d08b6)
-
(cherry picked from commit 8f114753)
-
(cherry picked from commit e14e3a4a)
-
(cherry picked from commit e641ea55)
-
Clamping in the condition and again in the assignment is just error-prone. Clamp once and store the result. (cherry picked from commit ac81ee5c)
-
If the angle is different, but ends up being clamped to the current value, an unnecessary `Modified` event is generated. (cherry picked from commit 80c48cd5)
-
(cherry picked from commit acd3a1d8)
-
(cherry picked from commit 9b89398b)
-
on line 85 there is an error when tests are run with libc++ hardness mode with the debug setting on line 82 we reserve space for the vector this does not change n though so when we access it on line 85 there is an error n=0, to fix this we reserve and initalize the vector (cherry picked from commit e1d59512)
-
This change ensures that the camera orientation widget handles are updated at build time. This allows arbitary calls to BuildRepresentation to yield updated handles. (cherry picked from commit 8bad31f2)
-
(cherry picked from commit 147500ad)
-
(cherry picked from commit 2ac151e6)
-
Fixes overflows for large number of cells which can cause integer math to overflow. (cherry picked from commit 814eba3a)
-
(cherry picked from commit 4d7281e6)
-
- Jan 16, 2025
-
-
406cceb9 AMReXParticlesReader: handle inexact division of grids among MPI ranks 1d4baf0d AMReXGridReader: Use std::size_t or vtkIdType instead of long where necessary 2715c463 AMReX - continue reading particle file when top level header does not exist 905c2586 Fix vtkPlotBar::GetBounds logic when log scale is enabled 72fb8a68 doc: Fix typo LogScaling -> LogScale in vtkAxis header fefb1764 Fix cell coloring for thick lines on apple silicon Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
buildbot <buildbot@kitware.com> Reviewed-by:
Cory Quammen <cory.quammen@kitware.com> Merge-request: !11834
-
- Jan 13, 2025
-
-
Jaswant Panchumarti (Kitware) authored
- this commit fixes the grid-process assignment logic robust when the number of grids cannot be exactly divided among the number of MPI ranks (pieces in this code) - this commit also adds MPI awareness to an existing unit test. - the unit test TestAMReXParticlesReader is run with MPI, when enabled, on 3 nodes. It passes only when the sum of the number of points across all nodes is equal to a known value. - without the change in vtkAMReXParticlesReader, the unit test will faill with MPI (cherry picked from commit de94dced)
-
Jaswant Panchumarti (Kitware) authored
- this commit should allow opening files larger than 2GB on windows. - it uses `size_t`/`vtkIdType` instead of `long` when doing stream operations like `seekg`, `tellg`. earlier, it passed `long` (32-bit in windows) to `seekg`. As a result, arrays beyond the 2GB offset could not be read into the buffer. - see user report https://github.com/AMReX-Codes/amrex/issues/4167 and https://discourse.paraview.org/t/potential-length-overflow-for-large-data/15516 (cherry picked from commit d9d40248)
-
Jaswant Panchumarti (Kitware) authored
- address paraview/paraview#22835 (cherry picked from commit 2f2329d0)
-
Jaswant Panchumarti (Kitware) authored
- address paraview/paraview#22733 - This commit fixes the logic in the `vtkPlotBar::GetBounds(double*, bool unscaled)` method to scale the bounds only if `unscaled` is false. Previously, it returned unscaled bounds even when `unscaled` was false and returned scaled bounds when `unscaled` was true. (cherry picked from commit 6d90695f)
-
Jaswant Panchumarti (Kitware) authored
(cherry picked from commit c6c3a83d)
-
Jaswant Panchumarti (Kitware) authored
- address paraview/paraview#22594 - address paraview/paraview#21832 - Thick lines were drawn by expanding a line to 2 triangles stacked on their longest side using a geometry shader. When coloring by cell scalars, this worked everywhere except on apple silicon. - There seems to be a bug related to geometry shaders in Apple's OpenGL driver that caused thick lines to not correctly pick up cell colors. - It looks like the value written to `gl_PrimitiveID` is overwritten implicitly by `EmitVertex` and incremented each time a vertex is emitted from the geometry shader. - This commit works around it by fixing the usage of `gl_PrimitiveID` in fragment shader when drawing thick lines. (cherry picked from commit 62466099)
-
- Jan 08, 2025
-
-
bb974e2a vtkTableBasedClipDataSet: Add check to avoid nullptr access 6bf984f9 vtkHigherOrderTetra: Add size check edbb983b vtkGenericCell: Return when cell is nullptr aeeb3225 Fixed out of bounds string access found by ASan 7ce34755 vtkHDF: fix overflow issue 9480cd6e Numerically sort folder contents b9b37da4 vtkTextureObject: Check for context before binding texture Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
buildbot <buildbot@kitware.com> Reviewed-by:
Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com> Reviewed-by:
Nicolas Vuaille <nicolas.vuaille@kitware.com> Merge-request: !11810
-
- Jan 07, 2025
-
-
(cherry picked from commit e3db3c76)
-
(cherry picked from commit 1ab742b0)
-
(cherry picked from commit 5d987d5b)
-
Check length of offset before taking adrees of a range like `&string[n - 8]`. Looked for similar cases and also reordered another case to check length first, may or may not have been a problem, but safer this way. ASan would catch this *during* VTK builds, while generating the wrappings. (cherry picked from commit ccbda30c)
-
Lucas Givord authored
Reader regarding overlappingAMR can have an overflow issue due to his offset. Few places in the writer should rely on vtkIdType instead of int too. (cherry picked from commit fd2e7a9a)
-
This is for correctly sorting names that have numeric components without leading zeros, e.g. [f.0, f.10, f.5] -> [f.0, f.5, f.10]. (cherry picked from commit 7cd880e2)
-
(cherry picked from commit 4b476ba1)
-
- Dec 20, 2024
-
-
c5f888fc OSPRay: ambient light switch status Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
buildbot <buildbot@kitware.com> Reviewed-by:
Cory Quammen <cory.quammen@kitware.com> Merge-request: !11780
-
Sankhesh Jhaveri authored
The OSPRay renderer node avoids ambient lighting if there is an existing ambient light in the scene. However, this would fail if the existing light was switched off. This new check ensures that OSPRay uses ambient illumination even if existing ambient light is switched off.
-
- Dec 19, 2024
-
-
af084bd3 Added release note for light widget path tracing 0a6e6b0f Added test for light widget 890c60e2 Support ray-traced rendering of light widget/representation f60d1dc2 Support positional light attenuation with ray tracing Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
buildbot <buildbot@kitware.com> Reviewed-by:
Cory Quammen <cory.quammen@kitware.com> Merge-request: !11757
-
f5b8061a Added release note for rectilinear grid cell data support 21fa50d7 Fix volume rendering support for rectilinear grid celldata Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
buildbot <buildbot@kitware.com> Reviewed-by:
Cory Quammen <cory.quammen@kitware.com> Merge-request: !11764
-
- Dec 18, 2024
-
-