Brad King authored 4 years ago and Kitware Robot committed 4 years ago

88ad02f1 VS: Restore .sln support for VS Version Selector

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4765

Since commit 3b51343e (VS: Emit UTF-8 BOM for generated solution files,
2019-08-19, v3.16.0-rc1~237^2) the `.sln` file does not work with the
VS Version Selector.  Add a newline after the BOM to restore support.

Fixes: #20725

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

a9f4f58f cmGeneratorTarget: Clear AllConfigSources in ClearSourcesCache

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4751

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

3719ddd3 Help: Add 3.16.7 release note for FindPkgConfig '-isystem' fix

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4752

Add a release note for the change in commit 4d446c68 (FindPkgConfig:
also handle "-isystem" prefixes for include directories, 2020-04-30).

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

13ea1907 Help: Add 3.17.3 release note for Objective C/C++ compiler selection
16bf978e Merge branch 'backport-3.16-objc-env-vars' into objc-env-vars
67b9f55d Objective C/C++: Honor CC and CXX env vars to select compiler
ab9be666 Help: Document OBJC and OBJCXX env vars for Objective C/C++ compilers

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4746

In commit 40aa6c05 (cmGeneratorTarget: Add method to collect all
sources for all configs, 2017-04-10, v3.9.0-rc1~268^2~5) we forgot to
update `ClearSourcesCache` to also clear `AllConfigSources`.  This leads
to subtle cases where code paths like PCH handling that add sources
during generation break depending on ordering.

Suggested-by: Christian Fersch
Fixes: #20712, #20702

Port the 3.16.7 release note for 3.17.3 too.

If the `OBJC` or `OBJCXX` environment variable is not set to specify an
Objective C or C++ compiler, check `CC` or `CXX` too.

Fixes: #20703

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

0199dd9f ExternalProject: expose _ep_cache_args_script to the caller

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4710

This is needed so that the caller can add a dependency on the cache
file.

Fixes: #20668

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

6b2fb4ff VS: Fix using PCH from source with COMPILE_OPTIONS

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4734

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

6c2514da MSVC: Use 'pragma system_header' in PCH only on cl 19.13 and above

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4736

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

f7a94cf2 XL: Install our Fortran 'cpp' helper script with execute permission

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4735

Merge-request: !4736

VS 2017 15.6 introduced support for this pragma.  Older MSVC versions
warn that it is unknown.

Fixes: #20692

This script was added by commit 19f267c7 (XL: Add support for Ninja
and XL Fortran, 2019-11-21, v3.17.0-rc1~368^2) but does not have a `.sh`
extension so our existing install rules neglect to give it execute
permission.  Our test suite works on XL Fortran in the build tree but
the script is broken without execute permission on installation.

Fixes: #20695

Merge-request: !4734

If a source file gets per-source flags from both PCH and custom
`COMPILE_OPTIONS`, combine them correctly.

Fixes: #20694, #20456

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

5ab137b7 FindGTK2: Add harfbuzz target for dependency from pango

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4725

Merge-request: !4725

Since commit effafca7 (FindGTK2: Add harfbuzz to GTK2_INCLUDE_DIRS,
2019-10-01, v3.16.0-rc1~22^2), pango's dependency on harfbuzz has been
captured, but only for the `GTK2_INCLUDE_DIRS` and `GTK2_LIBRARIES`
variables.  Add the `GTK2::harfbuzz` imported target and update the
`GTK2::pango` target to depend on it.

Issue: #19531

Merge-request: !4718

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

7a1c7736 PCH: Fix REUSE_FROM in multi-config generators

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4717

Andreas Schönle authored 4 years ago and Brad King committed 4 years ago

Since commit a55df204 (Multi-Ninja: Add precompile headers support,
2020-01-10, v3.17.0-rc1~136^2) the re-used PCH file object is added
once for each configuration to flags used for all configurations.
Put it in the flags for only the corresponding configuration instead.

Fixes: #20680

Fixes: #20674

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

e9d93c37 Help: Add 3.17 release note for FindPkgConfig '-isystem' fix
dfaaae67 Merge branch 'backport-3.16-FindPkgConfig-isystem'
4d446c68 FindPkgConfig: also handle "-isystem" prefixes for include directories

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4693

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

5b304a75 CheckLanguage: Fix forwarding of CMAKE_CUDA_HOST_COMPILER

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Robert Maynard <robert.maynard@kitware.com>
Merge-request: !4711

Merge-request: !4693

Fixes: #20652

Merge-request: !4711

Fix the condition added by commit fada8cbf (CheckLanguage: Report
CMAKE_CUDA_HOST_COMPILER if needed for compilation, 2019-05-31,
v3.15.0-rc1~12^2) to activate CUDA-specific logic.  The old condition
had worked in our test suite only by accident because the loop variable
used in the test happened to be the name and value that the old
condition used!  Update the test to use a different name.

Fixes: #19013

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

a1e04be9 FindBoost: Update MinGW compiler tag for Boost 1.73

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Boris Basic <baljci@hotmail.com>
Merge-request: !4706