Fix logic from commit bbf1c2d2 (ENH: More improvements and add
logging, 2006-01-02, v2.4.0~712) to append to the accumulated tag string
instead of overwriting it for each type of message.

Issue: #19610

A condition in `ComputeTestListForRerunFailed` contained an extra layer
of parentheses.  Remove them.  The condition itself is correct because
an empty list means "all tests" so we want to include the current test.

Issue: #19610

The ownership semantics of the 'testRun' variable are subtle and
may fool static analysers.  Add comments explaining them for now.
Later some refactoring could be done to clarify the code.

Issue: #19610

Directly compare two boolean values instead of spelling out accepted
combinations.

Issue: #19610

The logic checking `CMAKE_WARN_DEPRECATED` contained an unnecessary
layer of parentheses.  The condition is of the form `!IsSet || IsOn`
which is correct because the documentation says that the behavior is
enabled unless the variable is explicitly set to a false value.

Issue: #19610

For our use case we do not actually need to copy these.
Mark the operations as `= delete` to simplify the code.

Fix the SmartBSTR copy constructor and copy assignment operator added by
commit 18c8278b (VS: Add helper class to interact with Visual Studio
Installer, 2016-12-14, v3.8.0-rc1~93^2~4) to use the string from the
source of the copy.

Issue: #19610

Fix the order of logic added by commit 7740ccd1 (ENH: some cleanup of
the makefile generator, 2006-02-14, v2.4.0~517) to check for allocation
failure ('new' returns null) before using the pointer.

Issue: #19610

In commit 0b9906c2 (Windows: Use wide-character system APIs,
2013-12-04, v3.0.0-rc1~254^2) several buffer size computations had to be
updated to multiply by `sizeof(wchar_t)`, but for RegEnumKeyExW we were
already computing the correct number of characters with a division which
was accidentally converted to a multiplication.  Use `cm::size` to
compute the number of characters in the buffer instead.

Issue: #19610

In commit 0b9906c2 (Windows: Use wide-character system APIs,
2013-12-04, v3.0.0-rc1~254^2) several buffer size computations had to be
updated to multiply by `sizeof(wchar_t)`, but some for RegQueryValueExW
were incorrect because the number of bytes was already computed.

Issue: #19610

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

6ab28b94 cmCommand refactor: cmStringCommand
36f32d36 cmCommand refactor: cmSetPropertyCommand
7c83c192 cmCommand refactor: cmSetDirectoryPropertiesCommand
9413952c cmCommand refactor: cmCMakePolicyCommand
07ea93de cmCommand refactor: cmWriteFileCommand
ca3b9186 cmCommand refactor: cmVariableWatchCommand
b1acc711 cmCommand refactor: cmRemoveCommand
413a9603 cmCommand refactor: cmCMakeHostSystemInformationCommand
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3673

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

d3310212 clang-tidy: isolate declarations for readability

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3704

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

0148f1a8 FindBoost: Add note about header-only libs in warning msg

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3712

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

5edceff3 FindBZip2: Add Windows library names emitted from bzip2 1.0.6 makefile

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3711

Braden McDaniel authored 5 years ago and Brad King committed 5 years ago

As of release 1.0.6, the bzip2 distribution includs a makefile for nmake
on Windows that emits library names of the form `libbz2.lib`.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

bb6e95ca source_group: Improved generated filters tests

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3675

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

d1758090 cmExportInstallFileGenerator: improve error message
a1810089 cmInstallExportGenerator: add a method for the file destination

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3703

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

be780747 cmDefinitions: Reduce allocation of keys and values in MakeClosure
e07e2bc8 bootstrap: Compile cm::String
c1787cb5 cpack.cxx: Re-order include blocks to follow our conventions
141e3074 cmConfigure.h: Tell windows.h not to define min/max macros

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3669

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

891e670e install: print reason of failure

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Alex Turbov <i.zaufi@gmail.com>
Merge-request: !3696

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

66654135 ccmake: Fix form.h include with CMAKE_USE_SYSTEM_FORM

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3683

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

3b51343e VS: Emit UTF-8 BOM for generated solution files

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3705

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

2dfc5267 cmAlgorithms: Add cmContains

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Sebastian Holtermann <sebholt@web.de>
Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de>
Merge-request: !3700

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

1c87bc60 ProcessorCount: Fix virtual processor count on Solaris

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3694

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

76b76a7f FindCUDA: Fix support for backslashes in CUDA_NVCC_INCLUDE_DIRS

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3679

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

c55fb044 cmBuildNameCommand: Implement as free function
86bf1eef cmState: Support free function disallowed commands

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3688

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

31b8b28f FindMPI: Restore MPI_<LANG>_COMPILE_FLAGS and MPI_<LANG>_COMPILE_OPTIONS

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3710

Merge-request: !3710

Robert Maynard authored 5 years ago and Brad King committed 5 years ago

In commit e374b9f1 (FindMPI: Restore MPI_<LANG>_COMPILE_FLAGS as a
command-line string, 2018-09-10, v3.12.3~6^2) we tried to restore the
compile flags but accidentally inverted the arguments to `list(JOIN)`
causing both `MPI_<LANG>_COMPILE_FLAGS` and `MPI_<LANG>_COMPILE_OPTIONS`
to be empty.

Issue: #18349