Add some controls to qtReferenceItem.

Errors:

• commit a82bd0ad is not allowed because the following files are not formatted according to the 'clang-format-3.8' check: smtk/extension/qt/qtReferenceItem.cxx, smtk/extension/qt/qtReferenceItemData.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Warnings:

• please consider adding a changelog entry in a file ending with .md in doc/release/notes.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

Do: test

This merge request has been queued for testing. Test results may be viewed on:

• CDash (master)
• Buildbot (master) (only visible from inside Kitware)

Branch-at-master: a82bd0ad

added 1 commit

• ccb05f8e - Highlight reference item membership on hover.

Compare with previous version

Errors:

• commit a82bd0ad is not allowed because the following files are not formatted according to the 'clang-format-3.8' check: smtk/extension/qt/qtReferenceItem.cxx, smtk/extension/qt/qtReferenceItemData.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
• commit ccb05f8e is not allowed because the following files are not formatted according to the 'clang-format-3.8' check: smtk/extension/qt/qtReferenceItem.cxx, smtk/view/Selection.cxx, smtk/view/Selection.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Warnings:

• please consider adding a changelog entry in a file ending with .md in doc/release/notes.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

added 2 commits

• 277abac0 - Fix some buggy behavior TJ noticed.
• 657baaf9 - Improve qtReferenceItem usability.

Compare with previous version

Errors:

• commit a82bd0ad is not allowed because the following files are not formatted according to the 'clang-format-3.8' check: smtk/extension/qt/qtReferenceItem.cxx, smtk/extension/qt/qtReferenceItemData.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
• commit ccb05f8e is not allowed because the following files are not formatted according to the 'clang-format-3.8' check: smtk/extension/qt/qtReferenceItem.cxx, smtk/view/Selection.cxx, smtk/view/Selection.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
• commit 277abac0 is not allowed because the following files are not formatted according to the 'clang-format-3.8' check: smtk/extension/qt/qtReferenceItem.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
• commit 657baaf9 is not allowed because the following files are not formatted according to the 'clang-format-3.8' check: smtk/extension/qt/qtReferenceItem.cxx, smtk/extension/qt/qtReferenceItemData.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Warnings:

• please consider adding a changelog entry in a file ending with .md in doc/release/notes.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

Do: reformat

This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

added 4 commits

• 4ab5fae7 - Add some controls to qtReferenceItem.
• a5aa399f - Highlight reference item membership on hover.
• 8dc11625 - Fix some buggy behavior TJ noticed.
• 0f6ba828 - Improve qtReferenceItem usability.

Compare with previous version

Warnings:

• please consider adding a changelog entry in a file ending with .md in doc/release/notes.

The warnings do not need to be fixed, but it is recommended to do so.

added 1 commit

• 1cb35097 - Add a release note.

Compare with previous version

Do: test

This merge request has been queued for testing. Test results may be viewed on:

• CDash (master)
• Buildbot (master) (only visible from inside Kitware)

Branch-at-master: 1cb35097

@tjcorona Would you mind reviewing?

Note: the behavior you saw earlier (copy to selection appearing to fail) is a feature! The selection is being filtered and toolbar showed volumes were not allowed.

It is an easy fix (do not accept default arguments for the call to modifySelection()), but I'm not sure what the best behavior is... maybe if we filter we should let users know what got filtered out? Or maybe the selection should be unfiltered?

This is progress on (if not completion of) these issues: #177 #190 #194 #195 . Also, this CMB issue is a duplicate but is probably also affected: cmb#198 .

+1

looks great!

assigned to @tjcorona

added 11 commits

• 1cb35097...e68160fc - 6 commits from branch cmb:master
• 5c4db951 - Add some controls to qtReferenceItem.
• 8d1dbb15 - Highlight reference item membership on hover.
• ffb82d68 - Fix some buggy behavior TJ noticed.
• f1a1a05b - Improve qtReferenceItem usability.
• 93887933 - Add a release note.

Compare with previous version

Do: test

This merge request has been queued for testing. Test results may be viewed on:

• CDash (master)
• Buildbot (master) (only visible from inside Kitware)

Branch-at-master: 93887933

Do: merge

mentioned in commit e79f369d

merged

mentioned in issue #195