Skip to content
Snippets Groups Projects

Convert Helper header into class and replacing inline with static

Closed Haocheng LIU requested to merge haocheng.liu/cmb:MoveInlineFunctionIntoSourceFile into master
All threads resolved!

In MR 5d71090d, some dashboard warnings are fixed by making the function inline. This MR converts the helper headers into classes for better clarity.

Addresses issue #114 (closed) .

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Haocheng LIU Added 1 commit:

    Added 1 commit:

    • 979c387e - Convert Helper header into class and replacing inline with static

    Compare with previous version

  • Haocheng LIU Resolved all discussions

    Resolved all discussions

  • Basic content checks passed!

    Changes since last check: compare

    Branch-at: 979c387e
    Acked-by: @kwrobot

  • Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

    Branch-at: 979c387e

  • Haocheng LIU Status changed to closed

    Status changed to closed

  • Please register or sign in to reply
    Loading