Skip to content
Snippets Groups Projects

bindexplib: fix constants symbols export

Merged Mikhail Paulyshka requested to merge Mixaill/cmake:bindexplib-consts into master
All threads resolved!

This patch fixes bindexplib to add constants to .def file.

Note about testcase:

_declspec(dllimport) is needed because <something> DATA emits only _imp_<something> in .lib file ( https://docs.microsoft.com/en-us/cpp/build/importing-using-def-files )

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added os:windows label

  • added 1 commit

    • afb21342 - bindexplib: fix constants symbols export

    Compare with previous version

  • Brad King resolved all discussions

    resolved all discussions

  • Thanks!

    Do: test

  • added workflow:in-review and removed workflow:wip labels

  • Brad King changed milestone to %3.9.0

    changed milestone to %3.9.0

  • assigned to @brad.king

  • This merge request has been queued for testing. Test results may be viewed on CDash or Buildbot (only visible from inside Kitware).

    Branch-at: afb21342

  • Do: stage

  • Do: merge

  • Brad King mentioned in commit 34a083a1

    mentioned in commit 34a083a1

  • merged

  • Brad King mentioned in merge request !1041 (merged)

    mentioned in merge request !1041 (merged)

  • mentioned in issue #17045 (closed)

  • Unfortunately this causes a regression and so needs to be reverted for the 3.9 release pending further investigation. See #17045 (closed) and !1041 (merged).

  • Brad King mentioned in issue #18365

    mentioned in issue #18365

  • Please register or sign in to reply
    Loading