Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 4,165
    • Issues 4,165
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMakeCMake
  • CMakeCMake
  • Merge requests
  • !6923

Help: Drop incorrect versionadded for try_compile result variable

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged friendlyanon requested to merge friendlyanon/cmake:help-try-compile-result-var into master Jan 30, 2022
  • Overview 6
  • Commits 1
  • Pipelines 3
  • Changes 2

In !5481 (merged) we accidentally added versionadded markup suggesting that the first argument to try_compile was fixed as RESULT_VAR prior to CMake 3.14. This was probably due to misinterpreting the change from !3013 (merged).

The result variable has never been fixed. Drop the incorrect markup.

Original Description

The first argument has not been fixed for at least 15 years, well before 3.0 - or 3.14 for that matter - has been released.

Is this intentional? Was this just overlooked? Was it an "undocumented" feature?
If possible, this should also be backported to the old versions' reference documentation on the CMake website.

The git history says that it was practically never fixed to anything and the commit that added the note is a massive commit that just adds a bunch of these version notes, so it's extra confusing.
Came across this when writing my own Check module.

Backport: release

Edited Jan 31, 2022 by Brad King
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: help-try-compile-result-var