Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4,105
    • Issues 4,105
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMakeCMake
  • CMakeCMake
  • Merge requests
  • !6781

VS: Revert "Add missing label in C# project-build events"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Brad King requested to merge brad.king/cmake:vs-csproj-scripts into master Dec 02, 2021
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 7

Revert !6485 (merged). The change broke cases using multiple successful custom commands. Revert it pending further investigation into the interaction of the generated script code with Microsoft.Common.CurrentVersion.targets, and whether this is needed for all managed projects or just C# projects.

Also add a test covering the case that was broken.

Fixes: #22964 (closed)
Issue: #21440 (closed)
Backport: release

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: vs-csproj-scripts