Negative indices are specified relative to the current maximum vertex
position.  (-1 references the last vertex defined). This makes it easy
to describe the points in a face, then the face, without the need to
store a large list of points and their indexes.

Change tests from using ExternalData_add_test to vtk_add_test_cxx.
Added baselines for the tests. Ghe OBJImport tests were not being run.

Change tests from using ExternalData_add_test to vtk_add_test_cxx.
Added baselines for the tests. Ghe OBJImport tests were not being run.

The original code assumed that each material could only be used by one
actor (group). There is no mention of this restriction in the
Wavefront obj specification. The solution is to use a map of vectors
to map between material and actors.
New test added.

BUG: vtkOBJImporter fails if vt are present but texture indices not present
Another bug was discovered while addressing the original issue. If
texture coordinates are present via "vt" command but texture indices
are not defined for the faces, the actor was skipped. The solution is
to add a boolean variable that indicates whether texture indices are
defined. If there are no texture indices, do not add TCoords to the
PointData.

The original code assumed that each material could only be used by one
actor (group). There is no mention of this restriction in the
Wavefront obj specification. The solution is to use a map of vectors
to map between material and actors.

BUG: vtkOBJExporter fails if vt are present but texture indices not present
Another bug was discovered while addressing the original issue. If
texture coordinates are present via "vt" command but texture indices
are not defined for the faces, the actor was skipped. The solution is
to add a boolean variable that indicates whether texture indices are
defined. If there are no texture indices, do not add TCoords to the
PointData.

If an mtl file refers to a texture map file more than once, the
generated texture filename consists of the original name dupilcated n
times.

For example:
newmtl material0
map_Ka abc.png
map_Kd abc.png
map_Ks abc.png

will try open a fileabc.pngabc.pngabc.png

Update to allow numbers as texture names

Kitware Robot authored 6 years ago and Brad King committed 6 years ago

Populate a script with `map_<md5>=<sha512>` variable settings and
then run the following to convert the content link files:

    git ls-files -- '*.md5' | while read f; do
      md5="$(cat "$f")"
      sha512="$(eval echo \${map_$md5})"
      rm "$f"
      echo $sha512 > ${f%.md5}.sha512
    done

now allows for textures to be in BMP format

also allows the obj file to start with a BOM

154 occurances of ;;\n

This required some clean up, because the automatic changes borked a couple of files, but mostly resulted in stupid whitespacing. A few find/replace fixed things up.

There are now some duplicate semis because it did changes like:

  ~AMRIndexIterator() override{};
to
  ~AMRIndexIterator() override= default;;

Note there was a pointless semi before, which clang-tidy didn’t expect / account for.

My next commit will remove them.

I was surprised how many there were.  But no bugs at least, as best as I could tell.

Removed a few useless semi-colons that were nearby.

The old MapDataArrayTGoMultiTexture relied on
being able to lock dowwn a specific texture unit
which cannot be guaranteed as external code
or render passes may bne uising that texture unit.

Instead we support the method having the name of a texture
along with the matching ethod in vtkProperty to name
a texture. Between these two users can assign texture
coordinate arrays to specific textures.

Deprecated the old index and unit based methods.
Removed a no longer needed vtkTexture.h include
which may bite some folks who are using vtkTexture
but not including the header (which they shoudl do)

Found via `codespell -q 3 -I ../vtk-whitelist-words.txt --skip="./ThirdParty,./Utilities"`

The parser had a .c extension which caused some
warnings on one system as it contained c++ code.

Also fix a minor performance issue.

also add a new exporter designed to work with
obj file although it will work with any scene
in vtk.

The new exporter takes all the actors in a scene
and stores them as a single vtp file. It also takes
all the texturs and combines them into a single texture.
The exporter is designed to take OBJ files that may
consist of mulitple parts each with their own texture
and convert them into a singlke vtp file so that they are
easier to work with in ParaView/etc.

Found via `codespell`

The property isn't used anymore by the wrapping tools.

Now that Tcl wrapping is gone, all wrapping tools now use
`WRAP_EXCLUDE_PYTHON` instead.

For now, vtkTypeBool is just a typedef for int, but one day it can become a real bool.

Found with a regex:

vtkBooleanMacro.*int\)

Now that instantiators are gone, nothing cares about the ABSTRACT
property.

After reading the docs for some of the warnings, I think many are obsolete and can be unsuppressed.

Now that VTK requires a C++11 compiler we can ditch using custom typedefs to
wrap =delete;

Now that VTK requires a C++11 compiler we can ditch using custom typedefs

Adding in functionality to allow inserting vtkNew objects into
stl containers of vtkSmartPointer objects as well as comparisons
between vtkNew objects and raw pointers. Also removing Get() and
GetPointer() calls from vtkNew objects since in most instances we
can just pass in the vtkNew<> object instead of having to use the
Get() or GetPointer() methods to get the raw pointer.

The old scalar material mode was largely unused or used in
an inappropriate manner and yet adds complexity and cost
to the code. Thsi topic removes it and replaces it with
an implementation that is similar to
VTK_MATERIALMODE_AMBIENT_AND_DIFFUSE so that scalar colors
are used for ambient and diffuse colors but the ambient
and diffuse intensities are still respected.

seems some mtl files have a three character utf BOM
also handle spaces after the material name better

Mark as legacy for now, delete later on

fixes for MPI ADIOS and VRML

This topic is the result of running clang-tidy to
modernize our usage of NULL and 0 to nullptr. It also
includes some manual and semi manual changes where
clang-tidy would not be expected to work (such as in
comments, or classes not compiled on this build)

There are definitely many comments and occurances that
this topic misses that we will need to fix over time.