Skip to content
Snippets Groups Projects
  1. Jan 08, 2019
  2. Jan 03, 2019
  3. Jan 02, 2019
  4. Dec 20, 2018
  5. Dec 19, 2018
  6. Dec 18, 2018
  7. Dec 14, 2018
    • Laurent Rineau's avatar
      Fix ASAN error use-after-free in vtkSEPReader · 8a7f62ed
      Laurent Rineau authored
      The previous implementation os vtkSEPReader had a use-after-free.
      
      The function `vtkSEPReader::ReplaceFileName(..)` started with:
      
      ```c++
        delete[] this->FileName;
      ```
      
      And that means that the string pointed by `FileName` was
      destroyed. Even if the value of `FileName` was stored in the local
      variable `fileName`, in `vtkSEPReader::RequestData`, the string
      pointed by it was destroyed!
      
      The patch of this commit is a lot simpler: both the string pointed by
      `FileName` and the one that will replace it already exist in memory,
      and will not be modified during the run of `RequestData`. So we can
      just swap the pointers, without any need to memory
      allocation/deallocation to copy the strings.
      8a7f62ed
  8. Dec 12, 2018
  9. Dec 10, 2018
  10. Dec 06, 2018
  11. Dec 05, 2018
  12. Dec 04, 2018
  13. Dec 03, 2018
  14. Nov 30, 2018
  15. Nov 29, 2018
  16. Nov 28, 2018
Loading