Robert Maynard authored 8 years ago and Brad King committed 8 years ago

When we are on OSX and we are launching cmake-gui from a symlink, the
application will fail to launch as it can't find the qt.conf file which
tells it what the name of the plugin folder is. We need to add this path
BEFORE the application is constructed as that is what triggers the
searching for the platform plugins

Policy CMP0026 deprecated the LOCATION property, and we have long
provided a $<TARGET_FILE:...> generator expression.  However, if
a project tries to use $<TARGET_PROPERTY:...,LOCATION> we should
at least not crash.

The compatibility implementation of the LOCATION property uses
cmGlobalGenerator::CreateGenerationObjects to create the structures
needed to evaluate the property before generation starts.  The
implementation assumed that accessing the property could only be done
during configuration (via the typical get_property command use case).
The $<TARGET_PROPERTY:...,LOCATION> genex causes the LOCATION property
to be accessed during generation.  Calling CreateGenerationObjects
during generation blows away all the objects currently being used for
generation and is not safe.  Add a condition to call it only when
configuration is not finished.

Alexander Stein authored 8 years ago and Brad King committed 8 years ago

If e.g. libc.a is passed before any objects the linker raises the follwing
warning: cannot resolve archive libc.a to a compatible library, as no
input files have been encountered
In the end the library is skipped and missing symbols occur.

Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>

Release versions do not have the development topic section of
the CMake Release Notes index page.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

98eafa9b Help: Organize and revise 3.6 release notes
c5df7483 Help: Consolidate 3.6 release notes

Add section headers similar to the 3.5 release notes and move each
individual bullet into an appropriate section.  Revise a few bullets.

Move all development release notes into a new version-specific document:

 tail -q -n +3 Help/release/dev/* > Help/release/3.6.rst
 git rm -- Help/release/dev/*

except the sample topic:

 git checkout HEAD -- Help/release/dev/0-sample-topic.rst

Reference the new document from the release notes index document.
Add a title and intro sentence to the new document by hand.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

bcf39688 UseJava: Fix grammar error in documentation

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

bd4fef64 cmSourceFileLocation: Fix typo in comment
814e774e cmSearchPath: Fix typo in comment

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

20e55e4b CPackRPM and CPackDeb documentation improvements

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

d4e58dd9 CTestCustom: Suppress scanbuild warning on unsigned left shift
154fa2c5 CTestCustom: Suppress warnings about rand() on OpenBSD
e4a361bb CTestCustom: Suppress Windows manifest unrecognized element warning

The Clang scanbuild tool warns:

    Utilities/cmliblzma/liblzma/simple/x86.c:106:23: warning:
    The result of the '<<' expression is undefined
      src = dest ^ ((1u << (32 - i * 8)) - 1);
                     ~~~^~~~~~~~~~~~~~~

AFAIK overflow of a left shift on an unsigned type is well-defined.

We first suppressed this in commit v3.1.0-rc1~647^2 (CTestCustom:
Suppress warnings about rand() and srand() on OpenBSD, 2014-04-12).
Add another variant of the warning wording.

Our `cmake.version.manifest` file uses a "compatibility" element for
Windows 10 support.  Older MS tools warn about it being unknown, so
suppress the warning.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

27ead963 Remove unnecessary local copies.
618fb23f Pass arguments that are not modified as const&.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

1b2bb933 Remove redundant c_str() calls.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

cffe0ed7 OS X: Drop warning about SDK and deployment target version mismatch

Run clang-tidy's readability-redundant-string-cstr checker.
Ignore findings in kwsys.

Use clang-tidy's performance-unnecessary-copy-initialization checker.
After applying the fix-its (which turns the copies into const&), revise
the changes and see whether the copies can be removed entirely by using
the original instead.

Use clang-tidy's performance-unnecessary-value-param checker to find
value parameter declarations of expensive to copy types that are not
modified inside the function.  Ignore findings in kwsys.
After applying the fix-its, manually change `const T&` to `T const&`.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

8479dc46 liblzma: Avoid possible overflow on signed left shift

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

d256ba07 try_compile: Optionally forward custom platform variables to test project
fb4791b3 cmCoreTryCompile: Refactor forwarding of variables to test project

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

75e3e0d3 cmVariableWatch: Fix potential memory leak

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

3acc29fc CPack/DragNDrop: Optionally disable `/Applications` symlink

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

81e73b72 FindCUDA: Add support for finding the cublas_device library