Skip to content
Snippets Groups Projects
Select Git revision
  • prefer-back-data-over-rbegin-begin
  • master default protected
2 results
Search by author
  • Any Author
  • Artur Ryt Artur Ryt R2RT
  • buildbot buildbot buildbot
2 authors
  1. Sep 07, 2018
  3. Aug 07, 2018
  5. Aug 01, 2018
  7. Jul 12, 2018
  9. Jul 10, 2018
  11. Jul 09, 2018
    • Brad King's avatar
      XL: Restore suppression of infinite loop warning in process test · aebe4597
      Brad King authored 
      Our use of the `-qsuppress=` flag to suppress this warning was removed
by commit 51e95ba7 (XL: Fix compatibility with newer clang-based XL on
Linux, 2017-04-28) because XL 13.1.[1-6] for Linux does not support the
flag.  XL 16.1 restores support for the flag.  Restore our use of it for
this version.  Suppress the warning on intermediate versions by blocking
all warnings with `-w`.
      aebe4597
  13. Jun 22, 2018
  15. Jun 21, 2018
  17. Jun 14, 2018
  19. Jun 13, 2018
    • Marian Klymov's avatar
      SystemInformation: Avoid use of dangling pointers on Solaris · 61501133
      Marian Klymov authored and Brad King's avatar Brad King committed 
      `ParseValueFromKStat` was constructing local `std::string` instances in
a loop and passing their `.c_str()` to `RunProcess` after destruction.
Preserve the strings in a vector to avoid dangling pointers.

While at it, simplify some logic by using standard algorithms.
      61501133
  21. Jun 12, 2018
  23. Jun 09, 2018
  25. Jun 01, 2018
  27. May 31, 2018
    • Kitware Robot's avatar
      Revise C++ coding style using clang-format-6.0 · 828b6837
      Kitware Robot authored and Brad King's avatar Brad King committed 
      Run the `clang-format.bash` script to update all our C and C++ code to a
new style defined by `.clang-format`.  Use `clang-format` version 6.0.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.
      828b6837
    • Brad King's avatar
      Empty commit at end of history preceding clang-format-6.0 style transition · b7a341cf
      Brad King authored 
      This is an empty commit that precedes an automatic application of
clang-format-6.0 to update the C++ style of our entire source tree.
This may be helpful to rebase a topic branch that was originally
based on a commit preceding the transition.  One may first rebase
the topic on this commit.  Then use one of the following approaches.

*   Rewrite the topic, including this commit, using `git filter-branch`
    `--tree-filter` with `clang-format.bash` to update the style in
    every commit.  Rebase the revised topic, excluding the rewrite of
    this commit, on the style transition commit.

OR

*   Add a `.git/info/grafts` entry to change the parent of the first
    commit in the topic from this commit to the style transition commit.
    Rewrite the topic using `git filter-branch --tree-filter` with
    `clang-format.bash` to update the style in every commit.  Then
    remove the graft, which was resolved by the filter.

See `git help filter-branch` and `git help repository-layout` for
details.
      b7a341cf
    • Brad King's avatar
      clang-format.bash: update to clang-format-6.0 · 6b9c233c
      Brad King authored 
      Update `.clang-format` with configuration to make the 6.0 format as
close as possible to what 3.8 produced before.  Then revise the style:

* Indent preprocessor directives (a feature new since 3.8)
* Add a newline and indentation before inheritance `:` and `,`
      6b9c233c
  29. May 18, 2018
    • Brad King's avatar
      Merge topic 'getline-fixes' · 5357cfc4
      Brad King authored and Kitware Robot's avatar Kitware Robot committed 
      
898dc6b9 SystemTools: Fix GetLineFromStream to avoid libc++ bug on OS X 10.7

Acked-by: default avatarKitware Robot <kwrobot@kitware.com>
Merge-request: !100
      5357cfc4
    • Peter Wu's avatar
      SystemTools: Fix GetLineFromStream to avoid libc++ bug on OS X 10.7 · 898dc6b9
      Peter Wu authored and Brad King's avatar Brad King committed 
      LLVM libc++ as included with Mac OS X 10.7 suffers from an issue where
the trailing character is discarded when the delimiter (LF) is not found
within the given buffer size (1024).  The returned length is also 1024
rather than 1023.

This issue results in truncated reads as observed with CMake 3.11.0 on
Mac OS X 10.7 and `cmake -E cmake_link_script link.txt`.

Solve this by replacing `istream::getline` by `std::getline` which does
not trigger the buffering issue.  There is one edge case that I decided
to leave up to the callers though: a file containing `\0` previously
resulted in line truncation, but is now included in the result.

Tested with Mac OS X 10.7 and 10.11:

    -DCMAKE_OSX_DEPLOYMENT_TARGET=10.7 -DCMAKE_CXX_FLAGS=-stdlib=libc++

and `./kwsysTestsCxx testSystemTools`.

Issue: cmake/cmake#15039
      898dc6b9
  31. May 15, 2018
  33. May 12, 2018
  35. May 11, 2018
  37. May 09, 2018
  39. Apr 24, 2018
  41. Apr 23, 2018
  43. Apr 19, 2018
  45. Apr 12, 2018
  47. Apr 11, 2018
  49. Mar 29, 2018
  51. Mar 28, 2018
  53. Mar 09, 2018
  55. Mar 08, 2018
  57. Mar 07, 2018
  59. Mar 06, 2018