Brad King authored 3 years ago and Kitware Robot committed 3 years ago

f71e7b81 Help/dev/review: mention `--pretty=reference`

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5994

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

06e69813 cmake-presets: Make generator and binaryDir fields optional

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5946

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

82e40607 ctest: Display test "WAITING" messages only in extra-verbose mode
80da23f2 Tests: Add RunCTest helper option to control CTest verbose flag

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !5990

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

d6da6784 FindThreads: Reduce amount of false positive error logging

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5988

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

3953dfcb Restore support for backslashes in initial language-wide flags

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5995

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

3953dfcb Restore support for backslashes in initial language-wide flags

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5995

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

8e38985d Makefiles: Fix dependency extraction with CUDA < 10.2 and host compiler

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Raul Tambre <raul@tambre.ee>
Acked-by: Robert Maynard <robertjmaynard@gmail.com>
Merge-request: !5992

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

8e38985d Makefiles: Fix dependency extraction with CUDA < 10.2 and host compiler

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Raul Tambre <raul@tambre.ee>
Acked-by: Robert Maynard <robertjmaynard@gmail.com>
Merge-request: !5992

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

9ef82d95 FindBLAS: Fix detection of OpenMP as dependency of BLA_STATIC

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5993

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

9ef82d95 FindBLAS: Fix detection of OpenMP as dependency of BLA_STATIC

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5993

Refactoring in commit bdc40742 (CMakeDetermineCompilerId: Test without
COMPILER_ID_FLAGS if REQUIRE_SUCCESS, 2021-02-27, v3.20.0-rc3~6^2) added
an extra macro layer through which flag strings are passed.  That caused
an extra level of argument re-parsing, and broke flags with backslashes.
Pass flags to the helper macro through variable names instead.

Fixes: #22041

This was added in Git 2.25 (13 Jan 2020).

Update the change from commit f7f3d898 (FindBLAS: Add dependency of
OpenBLAS on OpenMP for BLA_STATIC, 2020-11-10, v3.20.0-rc1~492^2):

* If C is not enabled, find CXX OpenMP libraries instead.

* Do not use BLA_STATIC's custom CMAKE_FIND_LIBRARY_SUFFIXES for OpenMP.
  It can break projects that already call `find_package(OpenMP)` and
  expect a shared library.  Whether OpenMP is static is orthogonal to
  whether BLAS is static.

Fixes: #22039
Issue: #16221

Since commit 2c71d051 (Makefiles Generators: use compiler for
dependencies generation, 2020-10-18, v3.20.0-rc1~392^2) we invoke `nvcc`
for CUDA < 10.2 a second time in order to generate a depfile.  When
`CMAKE_CUDA_HOST_COMPILER` is set, the second invocation is missing its
`-ccbin=` option, even after refactoring in commit 8981e3e7
(NVIDIA-CUDA: rely on new capabilities for deps generation, 2020-12-02,
v3.20.0-rc1~362^2).

Ideally we should move the `-ccbin=` flag into `Compiler/NVIDIA-CUDA`,
but that will add `CMAKE_CUDA_HOST_COMPILER` support on Windows in
command-line generators but not the Visual Studio generators.
For now, add the flag to the depfile command specifically.

Fixes: #22037

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

4d786dfc BinUtils: Avoid clobbering a variable named without a private prefix

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5986

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

4d786dfc BinUtils: Avoid clobbering a variable named without a private prefix

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5986

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

4aed96e2 Apple: Set CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG on non-macOS too

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5980

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

4aed96e2 Apple: Set CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG on non-macOS too

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5980

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

cd48433e FindHDF5: add compiler-specific module search paths
78287ec0 FindHDF5: track the "main" library for each language
3654068e FindHDF5: find include directories after the library

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5977

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

e8ddc1e2 Autogen: Fix a bug in setting the UIC source group
7f0151dc Help: Document the AUTOUIC_SOURCE_GROUP property
f6c47dd0 Help: Fix a typo in the AUTOGEN_SOURCE_GROUP help

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Alexey Edelev <alexey.edelev@qt.io>
Merge-request: !5978

Refactoring in commit b12aec6c (BinUtils: prefer bin utils matching
the compiler version extension, 2020-12-11, v3.20.0-rc1~171^2)
accidentally leaked a `TOOL` variable.  Name temporary variables with a
private prefix.

Fixes: #22035

In v3 of the presets, generator and buildDir can be omitted to fall
back to regular cmake behavior when these values are not explicitly
provided by the user.

Fixes: #21987

When a CMake based project fails, users start looking at
CMakeError.log and think that the FindThread output is
the problem, but it is a false positive.

Now FindThreads only logs to `CMakeError.log` when it fails
to find a suitable flag, reducing the amount of false positives in `CMakeError.log`.

Fixes #16540, Fixes #19344

These messages are incidental scheduling output.  Avoid cluttering
the normal verbose output showing tests starting and finishing.

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

c6a45968 ci: Enable jq-based tests on Linux builds
8ca8b74a ci: add jq and DevIL to Debian and Fedora base images

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !5987