Clinton Stimpson authored 11 years ago and Brad King committed 11 years ago

Change-Id: I96564a95f1ee6111edc58bdd85a933ace7502a73

Clinton Stimpson authored 11 years ago and Brad King committed 11 years ago

SystemTools still had uses of kwsys_ios::ofstream that need changed
to kwsys::ofstream to support utf-8 encoding of filenames.

Change-Id: I308e9cc055295881405b1b079d0653dab37b8d3d

Ådne Hovda authored 11 years ago and Brad King committed 11 years ago

Some older versions of HP-UX do not define CPU_IA64_ARCHREV_0, but
CPU_HP_INTEL_EM_1_0 resolves to the same constant (in
/usr/include/sys/unistd.h).

Change-Id: I20f9a161ef62277069a5ba0d339ca09d972a9bae

If a group of processes needs to be terminated recursively the entry in /proc
doesn't need to be kept open during the recursion as all the interesting
information was already read from it. Especially in case of deeper recursion
this lowers the memory pressure.

Change-Id: I95b969f42c8dd68b57cdaf8fc1b705f358f1dc58

Change-Id: I9a6ce9af30dae548e860636ad64164200ba91f49

The WindowsFileExists function was originally created to avoid
duplication by the Cygwin and Windows implementations of FileExists.
Now that we use the ANSI API on Cygwin and the Wide API on Windows, one
of the two overloads is always left unused.  Drop the helper functions
and inline the implementations at their respective (single) call sites.

Change-Id: I4d25f98b8b11f0fdce2f360f5f425e0b159b22e5

The KWSys "String.h" is not needed by "Encoding.hxx" and may not
be available in projects that do not enable the KWSys String API.

Change-Id: I50ff9a89fc3d43b59f6958e09423862bf104d904

Sean McBride authored 11 years ago and Brad King committed 11 years ago

A single quote in an inline assembly comment is confusing gcc:

 .../SystemInformation.cxx:256:24: warning: invalid suffix on literal;
 C++11 requires a space between literal and identifier [-Wliteral-suffix]
 ; optimiser doesn't know about <<CPUID>>, and so doesn't expect
                  ^

Avoid it by changing "doesn't" to "does not".

Change-Id: Ic4caaeaabfdb99aa486ec09b23d670ec1b125069

Clinton Stimpson authored 11 years ago and Brad King committed 11 years ago

Create a KWSYS_ENCODING_DEFAULT_CODEPAGE setting that can be used
by parent projects to configure the default code page.  Default
to CP_ACP (ANSI Code Page) so that our narrow->wide conversions
used to access wide Windows APIs are equivalent to direct use of
the narrow Windows APIs.

Change-Id: I02ce362dbdc6127f42b7af7e620e46b7829cbc64

Change-Id: Icb357202c5591819b9f44b4e4f1376e7c4f7b7b3

Uses wide APIs on Windows for fstream.

Change-Id: I159da88196027665b520895a0c5aa881f7e4b125

The 8 bit encoding is UTF-8.

Change-Id: If54262c09777effcbffac30481405e56c6605dd7

Cleans up a smidge of global namespace pollution. Allows using this
header file in the same compilation unit with other header files
that may also contain a mode_t typedef, possibly with a different
underlying type.

Actually encountered in the wild when trying to compile a class that
uses both log4cpp and VTK.

Change-Id: Iba5592778fc21d66946026847537d914e56f332b

Raphael Kubo da Costa authored 11 years ago and Brad King committed 11 years ago

This was probably broken for a long while, but the problem was not apparent
because the check for execinfo.h would fail by default because
-I/usr/local/include was not being passed to the compiler when making the
checks for the header's existence.

Now that very recent FreeBSD versions (ie. 10-CURRENT) have NetBSD's
libexecinfo in base (and it is thus installed into /usr), the
backtrace-related checks would pass, but the required headers were not being
included in SystemInformation.cxx.

Change-Id: I3b91ed7ac0e6878035aee202b3336c536cc6d2ff

Adrien Destugues authored 11 years ago and Brad King committed 11 years ago

No need to use a different path from the BeOS one, which still works.

Change-Id: I7fe3e53ac6aaa7971eb22650935e80fa0bd41daa

Adrien Destugues authored 11 years ago and Brad King committed 11 years ago

Haiku does not define __BEOS__ anymore, so there is no need to guard
these BeOS specific workaround for Haiku.  The workarounds themselves
are not needed for Haiku as it has much better POSIX compatibility than
BeOS did.

Change-Id: I91a1598df764abe0febc9c3828e8bfd47e089cee

Fixes the following truncation warnings from g++ 4.8:

kwsys/SystemInformation.cxx: In member function 'int cmsys::SystemInformationImplementation::GetFullyQualifiedDomainName(std::string&)':
kwsys/SystemInformation.cxx:1738:31: warning: conversion to 'socklen_t {aka unsigned int}' from 'long unsigned int' may alter its value [-Wconversion]
         = (fam==AF_INET?sizeof(struct sockaddr_in):sizeof(struct sockaddr_in6));
                               ^
kwsys/SystemInformation.cxx:1738:58: warning: conversion to 'socklen_t {aka unsigned int}' from 'long unsigned int' may alter its value [-Wconversion]
         = (fam==AF_INET?sizeof(struct sockaddr_in):sizeof(struct sockaddr_in6));
                                                          ^
kwsys/SystemInformation.cxx: In member function 'bool cmsys::SystemInformationImplementation::QueryLinuxMemory()':
kwsys/SystemInformation.cxx:3839:33: warning: conversion to 'int' from 'long unsigned int' may alter its value [-Wconversion]
     char *r=fgets(buffer, sizeof(buffer), fd); // Skip "total: used:..."
                                 ^

Change-Id: I1016a7e31325ee550322dde7a21ffc92d6ca49dc

Patrick Gansterer authored 11 years ago and Brad King committed 11 years ago

Change-Id: Ifc21dc8ab53867abae9758e6408fef8eac6e4a33

Patrick Gansterer authored 11 years ago and Brad King committed 11 years ago

Move the code for parsing the given key to its own function.

Change-Id: I05eddba48cf7fabd3c48f2175a16457910a47583

Add supprt for C++ name demangling during call stack
introspection. This will be enabled at compile time
if the required system libraries,header files, and
compiler features are detected. Add a method so that
the stack trace may be obtained on demand not just
from within the stack trace signal handler.

Change-Id: Ie829f4b24ab331e39b97f54e63564df70f129b7e

Suppressed because the methods in question are meant to reproduce
STL (ex: std::auto_ptr) signatures exactly.

Change-Id: I3705f8383872c3c4c3787f5ae458e840298c7df1

Honor the DASHBOARD_TEST_FROM_CTEST environment variable as
well as DART_TEST_FROM_DART.

Change-Id: I8b57f3d50e887dfc96820684f6706336a14d96bd

The loop condition "while ( path.size() > dir.size() )" assumes that
eventually path will be no longer than dir but "c:/" will always be
longer than "/" and loop forever.  Simplify the implementation to avoid
the loop and the assumption.

Change-Id: I5613c7554ebd05b12cfe4882ac3bec4ecaa6e0ae
CMake-Issue: 14283

Sean McBride authored 11 years ago and Brad King committed 11 years ago

Also adjust nearby whitespace.

Change-Id: I83a17103c3e5c896c30226fc4d9d8b5b94c66e59

If the path passed to MakeDirectory() pointed to an existing file (not
directory), it would return true indicating that the directory was
successfully created even though creation of the directory failed.
Now it returns true only when the existing path is a directory and
returns false otherwise.

Change-Id: Ieb3e6352d63868c824df35f19187a8d396f75296

A ".." after the root component of a full path should just be the root
component itself.

Change-Id: I01b4ecc7d9ad0a0a267fa3451ab59e4078be8454
CMake-Issue: 14186

On Windows use CreateFile (with FILE_FLAG_BACKUP_SEMANTICS so it works
for directories), GetSystemTimeAsFileTime, and SetFileTime to touch.  On
other platforms prefer utimensat, then utimes, then utime.

Change-Id: Ie85fe3766661803e66f39975a147cd6f7320ea59
CMake-Issue: 14020

Replace use of COMPILE_FLAGS with COMPILE_DEFINITIONS for the
SystemTools.cxx source file property and spell out each definition on
its own line.

Change-Id: I213326b25fc7510107b78a8e233a3198862d9309

Allocate a buffer large enough to hold the input path when removing a
trailing slash.  Use a local stack buffer when it is large enough and
fall back to heap allocation otherwise.

Change-Id: Ibc4b4c96c7b0fafae9f4b5cd7ea894bdd605a098

Change-Id: Ib8b8b5d406e5123ac9c280bb5d2948916f5a997b

.../kwsys/SystemInformation.cxx: In member function ‘int cmsys::SystemInformationImplementation::GetFullyQualifiedDomainName(std::string&)’:
.../kwsys/SystemInformation.cxx:1475:31: warning: conversion to ‘int’ from ‘long unsigned int’ may alter its value [-Wconversion]
         = (fam==AF_INET?sizeof(struct sockaddr_in):sizeof(struct sockaddr_in6));
                               ^
.../kwsys/SystemInformation.cxx:1475:58: warning: conversion to ‘int’ from ‘long unsigned int’ may alter its value [-Wconversion]
         = (fam==AF_INET?sizeof(struct sockaddr_in):sizeof(struct sockaddr_in6));

POSIX says the type of the second argument to getnameinfo() should be
socklen_t so use that as the variable type here. Chances are high that this
has the same size as size_t so the warning would go away.

Change-Id: Ie2816b401a8fe7d615fa17a58b611e2cad14e4ea

This should fix this compiler warning observed with aCC:

Warning 863: ".../kwsys/testSystemInformation.cxx", line 93 # Result of operator << is widened from int to long.
        if (info.DoesCPUSupportFeature(1 << i))

Change-Id: Ie33521c354b11e3e852c801537c0c82f82c7041c

Andreas Mohr authored 11 years ago and Brad King committed 11 years ago

Change-Id: If6fc66bb0800c21a19dd06e41afc1eafa305b24e

Do not strip the trailing slash from root components like "c:/" before
passing to stat().

Suggested-by: Patrick Spendrin <ps_ml@gmx.de>
Change-Id: If8fffd6b1178f0edcd6984a8b865c697dae081c7

Paul Kunysch authored 12 years ago and Brad King committed 12 years ago

The Single UNIX (R) Specification, Version 2 defines "FD_SETSIZE", but
does not specify the effects if it's (re)defined by an application.

Cygwin's newlib headers document that FD_SETSIZE may be defined
by the user [1] and should be >= NOFILE. [2]  Setting it to 16384
uses a value from Cygwin's poll() implementation. [3]

[1]: http://cygwin.com/cgi-bin/cvsweb.cgi/src/newlib/libc/include/sys/types.h?cvsroot=src
[2]: http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/cygwin/include/sys/param.h?cvsroot=src
[3]: http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/cygwin/poll.cc?cvsroot=src

Change-Id: Idc43fc28a398979da1e9289e1080a9fc1090c605

Sean McBride authored 12 years ago and Brad King committed 12 years ago

Commit 857bda17 (SystemInformation: Report more information, 2012-05-29)
added use of __GNUG__ which is equivalent to __GNUC__ && __cplusplus.
Since this is a C++ source file and we use __GNUC__ elsewhere it is more
consistent and less redundant to use the latter.

Change-Id: I6428e2601310dd35c14ac643dcec199b01977842

Remove the abort() from the internal Getcwd implementation.  All callers
check the return value already.  Fix one caller's "else" behavior to
avoid crashing.

Change-Id: I3450c4942ffa108b2313877c9472820f6b465baa