Ben Boeckel authored 3 months ago and Kitware Robot committed 3 months ago

a3db6c62 ci: exclude geometry shader issues on macOS tests
647bda9d gitlab-ci: update to Xcode 16.1

Acked-by: Kitware Robot <kwrobot@kitware.com>
Rejected-by: buildbot <buildbot@kitware.com>
Merge-request: !11772

Ben Boeckel authored 3 months ago and Kitware Robot committed 3 months ago

82980672 matplotlib: use kwargs for `FontProperties` arguments

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11773

Ben Boeckel authored 3 months ago and Kitware Robot committed 3 months ago

82980672 matplotlib: use kwargs for `FontProperties` arguments

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11773

This has been deprecated and will be removed in a future release.
Migrate to kwargs instead.

Ben Boeckel authored 3 months ago and Kitware Robot committed 3 months ago

6c68c368 vtkTesting: clamp negative SSIM values
f053b934 vtkTesting: handle SSIM's [-1,1] range
7a07dd33 vtkTesting: fix typos in log string and comment
a450694a vtkTesting: fix string allocation
9692d102 TestIOSSExodusParallelWriter: fix compilation without MPI
5b1ff455 IO/IOSS/Testing: remove stray comma in source list
f0c476fa Relaxed overly tight floating-point comparison
b95a6030 ci: exclude floating point precision issues
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !11675

When SSIM returns a negative value, the histogram bucketing ends up
writing to out-of-bounds memory. Don't do that and instead shift the
buckets to account for the full range of values that are possible.

Finally, add commentary on the code.

See commit cd75f4b9618cb62e623c4adf88c5da0b346e2a83 which applied this
to `master` and `release`.

Co-authored-by: Spiros Tsalikis <spiros.tsalikis@kitware.com>

`newFileName` is deleted using `delete[]`, so allocate it with `new[]`.

Vicente Bolea authored 3 months ago and Kitware Robot committed 3 months ago

0ee8f335 java: copy the native libraries when creating native jars

Acked-by: Kitware Robot <kwrobot@kitware.com>
Rejected-by: buildbot <buildbot@kitware.com>
Reviewed-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !11754

Mathieu Westphal (Kitware) authored 3 months ago and Kitware Robot committed 3 months ago

8772ce67 Fix Python UMR on round(x) for reference type

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11737

Sean McBride authored 11 months ago and Ben Boeckel committed 3 months ago

This fixes a test failure on arm64 Macs, with default compiler options (that is, without `-ffp-model=strict`), where the dist2 value is not exactly zero but very tiny (due to fma, fused multiply add).

Specifically, in the UnitTestCells test it previously output:

```
Testing EvaluatePosition in/out test...cell center failed inOut: 1 point: -1.04083e-17, 0, 0-> pcoords: 0, 0, 0: closestPoint: -1.04083e-17, 0, 0 dist2: 1.08334e-34 weights: -0.0625 -0.0625 0.5625 0.5625
vtkCubicLine FAILED
```

Also fixed unrelated spelling/typo.

Co-authored-by: David Gobbi <david.gobbi@gmail.com>
(cherry picked from commit d204cfba)

New Xcode defaults to `-ffp-contract=on` which allows for fusing
floating point operations. This changes effective precision which these
tests are sensitive to. See referenced issue for details.

See: #19418
(cherry picked from commit 5adcac19)

(cherry picked from commit ee16c509)

(cherry picked from commit 45b5fbb3)

(cherry picked from commit 23c47aa0)

(cherry picked from commit 5f574baf)

(cherry picked from commit 9da16ff1)

Clang (rightly) detects that the `PyCFunction` cast is between invalid
function pointer types. Ignore the warning in-code because we know it is
fine due to the `METH_KEYWORDS` flag for the method.

(cherry picked from commit e83f01c9)

Found with Xcode 15.4 as a warning.

(cherry picked from commit 03b9afcd)

Ben Boeckel authored 3 months ago and Kitware Robot committed 3 months ago

Originally uncovered and fixed as a problem at all in
04661f4b (via !11367), this commit "solved" the
issue by clamping the SSIM values to be in `[0,1]` instead of `[-1,1]`. This
fixed the `hist` out-of-bounds accesses for negative values, but skews the
results in an unknown way. Instead, if the values have a negative range, shift
the values up and rescale to fit into the histogram range. This has an unknown
effect on what is actually being computed, but without comments guiding the
rationale of the original code, it is hard to tell.

Discovered as part of !11675.

13e0d68f vtkImageSSIM: handle SSIM's [-1,1] range
40064c9a vtkTesting: fix typo in log string
4271d352 vtkTesting: fix string allocation
c2eb7685 TestIOSSExodusParallelWriter: fix compilation without MPI
bee7e8bb IO/IOSS/Testing: remove stray comma in source list

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !11744

Jaswant Panchumarti (Kitware) authored 3 months ago and Kitware Robot committed 3 months ago

5d49f7b5 Fix deserialization when number of items in collection have not changed

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !11677

Ben Boeckel authored 3 months ago and Kitware Robot committed 3 months ago

7b53f2f4 ci: exclude tests with macOS M4 geometry shader issues
86a549c3 ci: remove trailing whitespace
85a2fc42 gitlab-ci: use Xcode 16.1

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Ryan Krattiger <ryan.krattiger@kitware.com>
Merge-request: !11746

Ben Boeckel authored 3 months ago and Spiros Tsalikis committed 3 months ago

When SSIM returns a negative value, the histogram bucketing ends up
writing to out-of-bounds memory. Don't do that and instead shift the
buckets to account for the full range of values that are possible.

Finally, add commentary on the code.

The clamping is still preserved as enabled by default in vtkTesting,
because we want to treat the anti-correlated images (negative values)
in the same way as not similar.

Mathieu Westphal (Kitware) authored 3 months ago and Kitware Robot committed 3 months ago

0a6eb5d5 Doc: Adding .md file
55d13873 Cocoa: Fix BackSpace keysym as it was incorrect

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Acked-by: Sean McBride <sean@rogue-research.com>
Reviewed-by: David Gobbi <david.gobbi@gmail.com>
Merge-request: !11738

Mathieu Westphal (Kitware) authored 3 months ago and Kitware Robot committed 3 months ago

4b476ba1 vtkTextureObject: Check for context before binding texture

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Michael Migliore <mcmigliore@gmail.com>
Merge-request: !11740

David Gobbi authored 3 months ago and Kitware Robot committed 3 months ago

8f56fb68 Silence "bad X server" warning during autodetection

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Jaswant Panchumarti (Kitware) <jaswant.panchumarti@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11742

Vicente Bolea authored 3 months ago and Kitware Robot committed 3 months ago

4276a14f Merge topic 'maven-update-classifier'
d3f338f9 Merge topic 'fix-java-artifacts'
d01e259c Merge topic 'fix-java-artifacts-cache-vars'
76466c7b Merge topic 'fix-pom-xml-artifacts'
a97de571 Merge topic 'correct-maven-artifacts-variable'

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Sebastien Jourdain <sebastien.jourdain@kitware.com>
Merge-request: !11736