Brad King authored 3 years ago and Kitware Robot committed 3 years ago

cf3bc271 Help: Clarify details passed to ExternalProject configure and build

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6135

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

b00a171b Help: Clarify calling cmake_minimum_required() inside a function

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6129

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

929c8a78 INTERFACE_POSITION_INDEPENDENT_CODE must be transitive for OBJECT library

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6127

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

caea48ee CMakeParseImplicitIncludeInfo: remove needless variable expansions

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6125

Fixes: #22116

Fixes: #21519

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

bb9c69ed Utilities/Sphinx: Update man page config for Sphinx 4

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6126

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

bb9c69ed Utilities/Sphinx: Update man page config for Sphinx 4

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6126

Fixes: #22174

Sphinx 4 by default generates `man/#/foo.#`, but older versions generate
`man/foo.#` as our install rules expect.  Update our Sphinx config file
to tell Sphinx 4 to use the old layout.

Fixes: #22192

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

f6d4fa63 cmStateDirectory: Comment relative path top directory selection approach
f0ffb1e2 cmGlobalGenerator: Simplify relative path conversion in AddRuleHash
d346805e cmLocalCommonGenerator: Select work directory semantically
15fa3200 cmLocalGenerator: Factor out relative path conversion helpers
1879f1bc cmLocalCommonGenerator: Factor out relative path conversion helper
1d1d88d3 cmMakefileTargetGenerator: Clarify name of relative path conversion helper
ec1ea130 cmDependsFortran: Simplify relative path conversion helper
ba7b9398 cmStateDirectory: Rename ConvertToRelPathIf{Not => }Contained
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6122

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

c7aa3bde Tests/include_external_msproject: Check C# project reference
65b58b03 VS Generator: Properly reference included external C# projects

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6123

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

5d32ce32 FetchContent: Use private local variables in FetchContent_MakeAvailable

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Craig Scott <craig.scott@crascit.com>
Merge-request: !6114

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

f78b167a cmCommandLineArgument: Provide more information syntax error messages
5aa0dec6 cmake: `--build` and `--install` error out when encountering bad flags
928cdb17 cmCommandLineArgument: Correctly record parsing failures

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6119

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

f78b167a cmCommandLineArgument: Provide more information syntax error messages
5aa0dec6 cmake: `--build` and `--install` error out when encountering bad flags
928cdb17 cmCommandLineArgument: Correctly record parsing failures

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6119

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

db8e0bee cmGlobalNinjaGenerator: Clarify semantics of Fortran scanning info
bd12b97d cmScanDepFormat: Drop unused "outputs", "inputs", and "depends" fields

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !6115

Revert commit 204aecdf (cmGlobalGenerator: Port configure-time code to
cmMakefile., 2015-08-02, v3.4.0-rc1~234^2~8).  `AddRuleHash` is
generate-time code.

Most calls to `MaybeConvertToRelativePath` use one of our common work
directories (e.g. top of the build tree) as the local path.  Add helpers
for each of the common cases to simplify and clarify call sites.

Revert commit 8377d9e0 (Fortran: Inline conversion to relative path,
2016-10-04, v3.8.0-rc1~494^2~4).  The inline implementation is still
identical to what was previously called.  Restore the call again.

They seem to actually cause trouble, like an error reported on IRC where some
but not all CMake invocations may end up with an error like this:

   CMake Warning (dev) at /usr/share/cmake/Modules/CMakeParseImplicitIncludeInfo.cmake:74 (if):
     Policy CMP0054 is not set: Only interpret if() arguments as variables or
     keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy
     details.  Use the cmake_policy command to set the policy and suppress this
     warning.

     Quoted keywords like ")" will no longer be interpreted as keywords when the
     policy is set to NEW.  Since the policy is not set the OLD behavior will be
     used.
   Call Stack (most recent call first):
     /usr/share/cmake/Modules/CMakeParseImplicitIncludeInfo.cmake:179 (cmake_parse_implicit_include_line)
     /usr/share/cmake/Modules/CMakeDetermineCompilerABI.cmake:119 (cmake_parse_implicit_include_info)
     /usr/share/cmake/Modules/CMakeTestCXXCompiler.cmake:26 (CMAKE_DETERMINE_COMPILER_ABI)
     CMakeLists.txt:24 (project)
   This warning is for project developers.  Use -Wno-dev to suppress it.

   CMake Error at /usr/share/cmake/Modules/CMakeParseImplicitIncludeInfo.cmake:74 (if):
     if given arguments:

       "GNU" "STREQUAL" "SunPro" "AND" "(" ")" "MATCHES" "-D__SUNPRO_C" "OR" ")" "MATCHES" "-D__SUNPRO_F" ")"

I suspect that the line ends up being just ")", which then causes this error.

Fixes #22186

Use `optional<>` instead of `unique_ptr<>` to hold optional value.

These fields are specified by our `P1689r3` paper, but are not actually
needed.  The dependencies of the scanning results themselves can be
captured via normal depfile logic.  Avoid saving this possibly-large
information in the scanning results.  It is not needed by later steps.

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

08db1341 find_*: ensure consistent behavior for cache variables
f5fa6d53 class cmake: Store working directory at cmake launch
b1729200 find_*: refactor cache variable handling

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6110

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

3a715344 Ninja: Restore support for Fortran in a symlinked build tree

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6120

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

3a715344 Ninja: Restore support for Fortran in a symlinked build tree

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6120