The source was searched with "grep -l [^ -~]" to find characters outside
of the printable ASCII range 0x20 to 0x7e.  The worst offender is the
en-dash character, which is visually indistinguishable from the minus
character in most code editors.  Several tabs were also found, which
is surprising since they should be blocked by the commit hooks.

KWSys is now hosted on Kitware's GitLab instance.

The KWSys `.gitattributes` file now defines custom attributes.
Git does not support these in a subdirectory where we are about
to place the content, so comment them out during import.

Kunda authored 8 years ago and Cory Quammen committed 8 years ago

doxy and misc. typos pt2

Comments at the top of the script file describe what it does and how
to use it.

When building with Python 3 and VTK_PYTHON_FULL_THREADSAFE enabled
we need to ensure we have the GIL locked before calling PyType_Ready(...)

This is similar to what is already done in ITK and SimpleITK.

The new vtkTargetLinkLibrariesWithDynamicLookup.cmake file is slightly modified copy from
ITK/CMake/itkTargetLinkLibrariesWithDynamicLookup.cmake
The explanation of what this patch tries to achieve is documented in this file.

A new argument is introduced, called OPTIONAL_PYTHON_LINK.
When used, the module will be optionally be linked against libpython.
In the module.cmake files, most vtkPython dependencies were moved to COMPILE_DEPENDS, so that libpython is not added to the target_link_libraries() call.

The vtkPython is explicitely linked against the python libraries, as this is a python executable.

Also, the find_package calls for the PythonLibs were made optional when possible.

The XDMF3 project was not updated, this will need to be done separately if weak linking is wished for that project.

Fixes: #16068

VTK has several Borland-specific workarounds, but I’m
fairly sure they are all for ancient compilers.
So this changes makes them all apply to older-than-newest
versions only.
This will make it easier to remove them entirely one day,
as currently it’s impossible to know if they are needed for all, old, or new versions.

Recent versions of lcov generate messages:
geninfo: Argument "=====" isn't numeric

Also, suppress /usr/include/ warnings.

generated via:
cd $VTKSRC
perl Utilities/Doxygen/doc_header2doxygen.pl --to ~/tmp/vtkheaders .
cp -r ~/tmp/vtkheaders/* .

move to entirely this style:
/**
 * something
*/
meanwhile, avoid tabs and end of line whitespace and cut down
on excessive doxygen groups resulting from multiline but
single item declarations

keep it around though, will be handy for other projects

The current dependency relationship in vtk is unclear and misleading.
This MR tries to rewrite them based on header files inclusion of headers
and source files in each module. Corner cases are considered and
modules are sorted in alphabetical order to facilitate future reference.
See details in my gitlab python based script project. In future we can continue
using this script to clean the VTK Dependency easily from
time to time.

One of the VTK dashboards had problems evaluating PYTHON_VERSION,
so stick with PYTHON_MAJOR_VERSION and PYTHON_MINOR_VERSION instead.
Also, change SEND_ERROR to FATAL_ERROR.

We will be removing support for Python 2.6 and Python 3.2 in the near
future, so add deprecation warnings for these.  For older versions of
Python, generate an error.  This deprecation is due in part to the
fact that WebPython now requires Python 2.7 or 3.3+.

There wasn't much left.

Notably, don't #define vtkstd at all anymore.

This reverts commit 772cc086.

Needs more work to build with VTK_KITS_ENABLED and to build
with ParaView.

vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;

vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;

vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;

(operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
to
\1 VTK_DELETE_FUNCTION;

After that, this finds basically nothing:

operator.*implemented

then manually reverted changed files in VPIC and KWSys folders.

These files will eventually need vtkConfigure.h
for eventual VTK_DELETE_FUNCTION usage.

Making the code a little less obfuscated.

Even though this utility is not designed to convert K&R braces to Allman
braces, it should indent their closing braces the same way.

This fixes some tricky issues with how VTK uses macros, specifically the
use of code blocks within the argument of vtkTemplateMacro(), and it also
tweaks the handling of case labels (yet again).

Any flow control keyword (if, while, etc.) should increase the indent
level, even if not followed by the opening brace that VTK style requires.
I've also created a short exception list, so that vtkParse.tab.c and
lex.yy.c (which are generated files) are not re-indented.

If this option is used, then vtk_reindent_code will print a warning
for each file with incorrect brace indentation.  It will also print
the line numbers for the incorrect braces.

Six files in the VTK source required vtk_reindent_code.py to be called
twice in order for the indentation to be corrected (all other files only
required it to be called once).  The problem with those six files was
nested blocks where all source lines between the beginning of the outer
block and the beginning of the inner block were comments.  There is
probably a way to fix the script so that it properly deals with this
situation, but simply re-processing the file until no futher changes
occur is a robust solution that gives the correct result.

Headers installed by the Qt and QtOpenGL modules in GUISupport use this
header naming convention. This allows the script to identify that including
QVTKWidget.h means you depend on the vtkGUISupportQt module, for instance

patch courtesy of Tim Rowley for adding width and height
options to the TimingTest

This is similar to what is already done in ITK and SimpleITK.

The new vtkTargetLinkLibrariesWithDynamicLookup.cmake file is slightly modified copy from ITK (things have been renamed from ITK to VTK). The explanation of what this patch tries to achieve is documented in this file.

A new argument is introduced, called OPTIONAL_PYTHON_LINK. When used, the module will be optionally be linked against libpython. In the module.cmake files, most vtkPython dependencies were moved to COMPILE_DEPENDS, so that libpython is not added to the target_link_libraries() call.

The vtkPython is explicitely linked against the python libraries, as this is a python executable.

Also, the find_package calls for the PythonLibs were made optional when possible.

This fixes the following bug: http://www.vtk.org/Bug/view.php?id=16068

Kitware Robot authored 8 years ago and David Gobbi committed 8 years ago

Perl was used to remove all the BTX and ETX markers from the code.
The specific command that was run on all "vtk*.h" files was this:
    perl -0777 -i -pe 's/(\n* *\/\/ *[BE]TX *\n+)+/\n\n/g'

This regex replaces each BTX/ETX line, plus any leading or trailing
blank lines, with a single blank line.

First automatically removed lines with only BTX/ETX
from .h files with the following regexes:

^ *// *BTX\r
^ *// *ETX\r

and replaced occurances with nothing. Committed that, then manually
removed various remaining cases of BTX/ETX, and related comments, and parsing stuff,
then trashed the first commit.

Changed some operator= from returning void to returning *this.