This commit replace a bunch of stat() usage by Stat
which is more robust especially on windows.

Kunda authored 8 years ago and Cory Quammen committed 8 years ago

doxy and misc. typos pt2

This is similar to what is already done in ITK and SimpleITK.

The new vtkTargetLinkLibrariesWithDynamicLookup.cmake file is slightly modified copy from
ITK/CMake/itkTargetLinkLibrariesWithDynamicLookup.cmake
The explanation of what this patch tries to achieve is documented in this file.

A new argument is introduced, called OPTIONAL_PYTHON_LINK.
When used, the module will be optionally be linked against libpython.
In the module.cmake files, most vtkPython dependencies were moved to COMPILE_DEPENDS, so that libpython is not added to the target_link_libraries() call.

The vtkPython is explicitely linked against the python libraries, as this is a python executable.

Also, the find_package calls for the PythonLibs were made optional when possible.

The XDMF3 project was not updated, this will need to be done separately if weak linking is wished for that project.

Fixes: #16068

Reverse the IsA test because dobj is a vtkStructuredPoints
and object a vtkImageData.

These are all new warnings vs the previous version, 1.76.1

No real bugs found/fixed here.

Most are either overwriting a never-read variable value,
usually only at intialiazation, or a useless comparison.

In a couple of places, threw in a const or did other minor reworking.

In some cases, when server closes unexpectendly
the client may try to send data to the server
while it's socket has already been destroyed,
provoking a segfault.
This fixes it.

vtkDebugLeaks registers instance by class name, which worked well for
many years. However, now that we have more templated code, this is
becoming difficult. For instance, "template <typename T> vtkBuffer<T>"
would be identified as "vtkBuffer<T>" when registering with
vtkDebugLeaks, but deregistered with the compiler dependent
typeid(vtkBuffer<T>).name() string returned from GetClassName().

This patch moves vtkDebugLeaks registrations to the method
vtkObjectBase::InitializeObjectBase(), which must be called after the
vtkObjectBase is instantiated. This ensures that objects are
registered using the same string as when they are destroyed. In
general, a call to "new vtkSomeClass" must be followed by a call to
InitializeObjectBase on the new instance. The common ::New()
implementation macros in vtkObjectFactory will ensure that
registration happens correctly.

Two notable exceptions are vtkCommand and vtkInformationKey
subclasses. These do not require any specific handling for
vtkDebugLeaks registration.

See discussion at:

http://vtk.1045678.n5.nabble.com/Proposal-Simplify-vtkDebugLeaks-registration-td5740222.html

I used perl regex to find any groups that spanned a protected: or
private: access specifier.

Kitware Robot authored 8 years ago and David Gobbi committed 8 years ago

This commit reindents the code with the following utility:
Utilities/Maintenance/vtk-reindent-code.py

This utility changes the positions of the braces so that they are no
longer indented relative to the code block they reside in.

The bash command line used was the following:

for d in Charts Common Deprecated Domains Examples Filters GUISupport \
         Geovis IO Imaging Infovis Interaction Parallel Rendering \
         Testing Views Web Wrapping; do
  for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
    find "${d}" -name "*.${e}" -exec \
      python Utilities/Maintenance/vtk_reindent_code.py {} +
  done
done

generated via:
cd $VTKSRC
perl Utilities/Doxygen/doc_header2doxygen.pl --to ~/tmp/vtkheaders .
cp -r ~/tmp/vtkheaders/* .

The current dependency relationship in vtk is unclear and misleading.
This MR tries to rewrite them based on header files inclusion of headers
and source files in each module. Corner cases are considered and
modules are sorted in alphabetical order to facilitate future reference.
See details in my gitlab python based script project. In future we can continue
using this script to clean the VTK Dependency easily from
time to time.

vtkCommunicator::GatherV() required the destination process to know what
data types to expect. This was unnecessary. There's enough information
in the marshalled data object received from  the sender side to deduce
that. Adding new vtkCommunicator::Gather() and
vtkMultiProcessController::Gather() methods that provide a simpler
interface.

Updating GenericCommunicator test to test for the new API.

If vtkCommunicator::GatherV(vtkDataObject*,...) was passed a NULL, it
would just skip. That could cause deadlocks in parallel is all ranks
didn't have NULL datasets. This change ensures that the communication
doesn't deadlock for NULL datasets.

This addresses paraview/paraview#16779.

Several vtkCommunicator and vtkMultiProcessController methods are
duplicated for `vtkIdType` and `long long` when in fact only the latter
is necessary.  All these APIs are overloaded for all basic integer
types, so the proper one can be chosen by the compiler for use with
callers that have a `vtkIdType`.

This reverts commit 772cc086.

Needs more work to build with VTK_KITS_ENABLED and to build
with ParaView.

vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;

vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;

vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;

(operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
to
\1 VTK_DELETE_FUNCTION;

After that, this finds basically nothing:

operator.*implemented

then manually reverted changed files in VPIC and KWSys folders.

This is similar to what is already done in ITK and SimpleITK.

The new vtkTargetLinkLibrariesWithDynamicLookup.cmake file is slightly modified copy from ITK (things have been renamed from ITK to VTK). The explanation of what this patch tries to achieve is documented in this file.

A new argument is introduced, called OPTIONAL_PYTHON_LINK. When used, the module will be optionally be linked against libpython. In the module.cmake files, most vtkPython dependencies were moved to COMPILE_DEPENDS, so that libpython is not added to the target_link_libraries() call.

The vtkPython is explicitely linked against the python libraries, as this is a python executable.

Also, the find_package calls for the PythonLibs were made optional when possible.

This fixes the following bug: http://www.vtk.org/Bug/view.php?id=16068

Kitware Robot authored 8 years ago and David Gobbi committed 8 years ago

Perl was used to remove all the BTX and ETX markers from the code.
The specific command that was run on all "vtk*.h" files was this:
    perl -0777 -i -pe 's/(\n* *\/\/ *[BE]TX *\n+)+/\n\n/g'

This regex replaces each BTX/ETX line, plus any leading or trailing
blank lines, with a single blank line.

Using SystemTools and Directory can be very inefficient
when dealing with a large number of processes. These classes
are esentially wrappers for SystemTools and Directory such
that only process 0 does any file system introspection and
then broadcasts that information out to other processes.

SafeDownCast performs a series of virtual calls and string comparisons,
which is quite slow, especially when used in worker functions.

vtkArrayDownCast will switch between SafeDownCast and the more
efficient FastDownCast (only available for common vtkAbstractArray
subclasses) depending on whether or not FastDownCast is defined for
the specific array type.

Kitware Robot authored 9 years ago and Dan Lipsa committed 9 years ago

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

The way algorithms were updated (made to execute) with
request meta-data (such as update extent) was very error
prone and counter-intuitive. Added new methods to make
updating with meta-data easier. I also deprecated a number
of methods to set request meta-data. This will encourage
developers to migrate to the new API which is less error-
prone.

VTK no longer supports any compilers that do not provide this type.
Therefore all code conditional on VTK_TYPE_USE_LONG_LONG can be made
unconditional.  Leave the macro defined to tell dependent projects that
APIs using the type are available in case they still support versions of
VTK that make it conditional.

Bill Lorensen authored 9 years ago and Ben Boeckel committed 9 years ago

These tests purposefully trigger errors in order to test that they
occur. Use vtkTestErrorObserver to catch these errors rather than
printing them as output and causing the test to fail.

VTK no longer supports compilers that do not understand `template <>`
for full template specialization.  Drop our compatibility layer for
this case.

Fix a few issues related to selecting None as a rendering
backend.

This makes the python wrappers ignore WRAP_EXCLUDE, and instead use
the new property WRAP_EXCLUDE_PYTHON that excludes fewer classes.
The WRAP_SPECIAL flag, which used to act as a whitelist for python,
has been removed.

Because this change causes classes to be wrapped in python by default,
some third-party VTK packages might break until they modify their own
CMakeLists.txt files to add WRAP_EXCLUDE_PYTHON where necessary.

We no longer need this compatibility layer for the compilers we support.
Use the following commands to switch to standard header and namespace:

 git grep -l vtksys/ios/ | xargs sed -i 's|vtksys/ios/||'
 git grep -l vtksys_ios | xargs sed -i 's|vtksys_ios|std|g'

In the early days of VTK, support for stl was not portable. vtksys_stl
and vtksys_ios provided a portable implementation of the stl. Now, all
of the VTK supported compilers have portable stl implementations.

This patch:
  1) Replaces the vtksys_ios:: with std::.
  2) Replaces the vtksys_stl:: with std::.
  3) Removes "using" statements for stl