[upgrade] Restore branding.cmake

Application/branding.cmake

+# Every Brand related names / resource paths should be declared here
+
+# Software Name / Vendor
+set(SOFTWARE_NAME   "LidarView")
+set(SOFTWARE_VENDOR "Kitware, Inc.")
+
+# Software LOGO / ICON # Must be absolute to be used by packaging
+set(SOFTWARE_ICON_PATH "${CMAKE_CURRENT_LIST_DIR}/SoftwareInformation/logo.ico")
+#set(SOFTWARE_LOGO_PATH "${CMAKE_CURRENT_LIST_DIR}/logo.icns") #WIP no wish to use those in paraview_client_add() yet

CMakeLists.txt

@@ -5,6 +5,9 @@ project(LidarView)
 # add path to get all the needed modules used to config Lidarview
 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/LVCore/CMake")
 
+# Include branding.cmake
+include(Application/branding.cmake)
+
 # we include the module that allow us to configure the Lidarview project
 include(SetupLidarviewProject)
 

Superbuild/CMakeLists.txt

@@ -2,10 +2,6 @@ cmake_minimum_required(VERSION 3.20.3)
 
 project(LidarViewSuperBuild)
 
-#LidarView-based app Branding
-set(SOFTWARE_NAME   "LidarView")
-set(SOFTWARE_VENDOR "Kitware, Inc.")
-
 #-----------------------------------------------------------------------------
 # All the function and variable bellow are here because we rely on lidarview's
 # superbuild.

Superbuild/Projects/lidarview.bundle.common.cmake

@@ -4,6 +4,9 @@ set(LidarViewSuperBuild_SOURCE_DIR "${superbuild_source_directory}")
 set(LidarViewSuperBuild_CMAKE_DIR "${LidarViewSuperBuild_SOURCE_DIR}/lidarview-superbuild/CMake")
 set(LidarViewSuperBuild_LVCORE_CMAKE_DIR "${LidarViewSuperBuild_SOURCE_DIR}/../LVCore/CMake")
 
+# Make sure Branding is set early
+include(${LidarViewSuperBuild_SOURCE_DIR}/../Application/branding.cmake)
+
 # Trigger Crossplatform LidarView Bundling
 include(${LidarViewSuperBuild_CMAKE_DIR}/bundle/LidarviewBundleCommon.cmake)
 

Superbuild/Projects/lidarview.cmake

@@ -9,8 +9,6 @@ superbuild_add_project(lidarview
     -DBUILD_SHARED_LIBS:BOOL=ON
     -DBUILD_TESTING:BOOL=OFF
     -DLV_BUILD_ARCHITECTURE=${LV_BUILD_ARCHITECTURE}
-    -DSOFTWARE_NAME=${SOFTWARE_NAME}
-    -DSOFTWARE_VENDOR=${SOFTWARE_VENDOR}
     -Dsuperbuild_python_version=${superbuild_python_version}
     -DParaView_DIR:PATH=${SuperBuild_BINARY_DIR}/common-superbuild/paraview/build
     -DVTK_DIR:PATH=${SuperBuild_BINARY_DIR}/common-superbuild/paraview/build/VTK