Brad King authored 8 years ago and Kitware Robot committed 8 years ago

27ead963 Remove unnecessary local copies.
618fb23f Pass arguments that are not modified as const&.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

1b2bb933 Remove redundant c_str() calls.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

cffe0ed7 OS X: Drop warning about SDK and deployment target version mismatch

Run clang-tidy's readability-redundant-string-cstr checker.
Ignore findings in kwsys.

Use clang-tidy's performance-unnecessary-copy-initialization checker.
After applying the fix-its (which turns the copies into const&), revise
the changes and see whether the copies can be removed entirely by using
the original instead.

Use clang-tidy's performance-unnecessary-value-param checker to find
value parameter declarations of expensive to copy types that are not
modified inside the function.  Ignore findings in kwsys.
After applying the fix-its, manually change `const T&` to `T const&`.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

8479dc46 liblzma: Avoid possible overflow on signed left shift

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

d256ba07 try_compile: Optionally forward custom platform variables to test project
fb4791b3 cmCoreTryCompile: Refactor forwarding of variables to test project

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

75e3e0d3 cmVariableWatch: Fix potential memory leak

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

3acc29fc CPack/DragNDrop: Optionally disable `/Applications` symlink

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

81e73b72 FindCUDA: Add support for finding the cublas_device library

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

8e801eb5 cmSystemTools: Fix indentation typo

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

715e4cf5 FindMatlab: Add support for Matlab 2016a (9.0)

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

c9cebed5 GetPrerequisites: Look for VS tools using registry entries (#16108)

OS X supports using the SDK for any version equal to or newer than
the deployment target.  There is no reason to warn if the versions
do not match exactly.

Suggested-by: James Burgess <jamesrburgess@mac.com>
Suggested-by: Clinton Stimpson <clinton@elemtech.com>

Use an unsigned value to produce the needed mask.

Teach cmVariableWatch::AddWatch to own the Pair it allocates until
it needs to pass ownership to WatchMap.

Add a `CMAKE_TRY_COMPILE_PLATFORM_VARIABLES` variable to specify a list
of custom variables to be forwarded to a `try_compile` test project.
This will be useful for platform information modules or toolchain files
to forward some platform-specific set of variables from the host project
(perhaps set in its cache) to the test project so that it can build the
same way.

De-duplicate the logic that constructs the cmake `-D` flag used to pass
variables into the test project cache.  Also subsume variables that were
propagated by generating `set()` commands in the project and pass them
as cache entries instead.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

5784747d Improve string find: prefer character overloads.
5cec953e Use std::replace for replacing chars in strings.
2a1a2033 cmExtraEclipseCDT4Generator: use std::replace.
34bc6e1f cmCTestScriptHandler: don't call find repeatedly.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

6b190b5c FindCUDA: Add support for generator expressions in CUDA_NVCC_FLAGS

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

c1340827 Add a variable to specify language-wide system include directories
44199097 cmMakefile: Optimize AddSystemIncludeDirectories for empty set
a896043b GHS: Compute include directories consistently with other generators

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

7807b3a9 Help: Document CMAKE_<LANG>_STANDARD_LIBRARIES variable

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

25d1ef64 Use enums defined in cmOutputConverter using their fully qualified name.

Chuck Atkins authored 8 years ago and Brad King committed 8 years ago

Follow the configure_file by a file(GENERATE) so the resulting cmake
scripts used by FindCUDA for wrapping nvcc calls can now support
generator expressions in the CUDA_NVCC_FLAGS variable.

Create a `CMAKE_<LANG>_STANDARD_INCLUDE_DIRECTORIES` variable to specify
system include directories for for `<LANG>` compiler command lines.
This plays a role for include directories as the existing
`CMAKE_<LANG>_STANDARD_LIBRARIES` variable does for link libraries.

Daniel Pfeifer authored 8 years ago and Brad King committed 8 years ago

Mostly automated:

values=("RelativeRoot" "NONE" "FULL" "HOME" "START" "HOME_OUTPUT" "START_OUTPUT"
        "OutputFormat" "UNCHANGED" "MAKERULE" "SHELL" "WATCOMQUOTE" "RESPONSE"
        "FortranFormat" "FortranFormatNone" "FortranFormatFixed" "FortranFormatFree")
for i in "${values[@]}"; do git grep -l cmLocalGenerator::$i | xargs sed -i "s|cmLocalGenerator::$i|cmOutputConverter::$i|g"; done

Apply fix-its from clang-tidy's performance-faster-string-find checker.
Ignore findings in kwsys.

Find uses of `cmSystemTools::ReplaceString` where both `replace` and
`with` are string literals with a size of one.

Automate with:

git grep -l ReplaceString | xargs sed -i "s|cmSystemTools::ReplaceString(\([^,]*\), \"\(.\)\", \"\(.\)\");|std::replace(\1.begin(), \1.end(), '\2', '\3');|g"
git grep -l ReplaceString | xargs sed -i "s|cmSystemTools::ReplaceString(\([^,]*\), \"\(.\)\", \"\\\\\\\\\");|std::replace(\1.begin(), \1.end(), '\2', '\\\\\\\\');|g"
git grep -l ReplaceString | xargs sed -i "s|cmSystemTools::ReplaceString(\([^,]*\), \"\\\\\\\\\", \"\(.\)\");|std::replace(\1.begin(), \1.end(), '\\\\\\\\', '\2');|g"

Also, prefer the character overload.