Skip to content

Do not invoke GUI for off-screen rendering in cocoa

Jaswant Panchumarti (Kitware) requested to merge jaswant.panchumarti/vtk:cocoa-thread-safety into master

The pretext is that the render service creates an offscreen (UseOffscreenBuffers=true, ShowWindow=false) render window in a thread that's NOT the main thread. This MR introduces additional checks before invoking Cocoa GUI functions. The additional check: is the render window offscreen? I found this less intrusive than sprinkling thread-id comparisons all over the code.

Generally speaking, outside the context of threads, offscreen rendering should not need any GUI.

Edited by Jaswant Panchumarti (Kitware)

Merge request reports