Skip to content

Code review and fix of some vtkDataSetAttributes API comment errors

Sean McBride requested to merge seanm/vtk:cleanup-comments into master

After trying to confirm the behaviour described in some vtkDataSetAttributes API like GetScalars(), went down a bit of a rabbit hole and did a code review of a few classes:

  • reduced scope of some variables
  • prefer preincrement in for loops
  • corrected/improved some comments
  • changed some ints to bool or vtkTypeBool
  • use constexpr where possible
  • be more explicit in testing return value of strcmp

Ultimately, the GetScalars() comment return value description was wrong, and corrected.

Merge request reports