Skip to content

Fixed more warnings from cdash

Sean McBride requested to merge seanm/vtk:more-cdash-warnings into master

Specifically, fixes:

/Common/DataModel/vtkDataSet.cxx:1075:44: warning: constructor parameter 'BitSet' shadows the field 'BitSet' of 'IsAnyBitSetFunctor' [-Wshadow-field-in-constructor]
  IsAnyBitSetFunctor(vtkUnsignedCharArray* BitSet, int BitFlag)
                                           ^
/Common/DataModel/vtkDataSet.cxx:1075:56: warning: constructor parameter 'BitFlag' shadows the field 'BitFlag' of 'IsAnyBitSetFunctor' [-Wshadow-field-in-constructor]
  IsAnyBitSetFunctor(vtkUnsignedCharArray* BitSet, int BitFlag)

/Filters/General/vtkFiniteElementFieldDistributor.cxx:819:43: warning: comparison of integers of different signs: 'std::vector<std::vector<double>>::size_type' (aka 'unsigned long') and 'const int' [-Wsign-compare]
        reqInit |= (*hCurlMats)[i].size() != npts;
                   ~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/Filters/General/vtkFiniteElementFieldDistributor.cxx:820:42: warning: comparison of integers of different signs: 'std::vector<std::vector<double>>::size_type' (aka 'unsigned long') and 'const int' [-Wsign-compare]
        reqInit |= (*hDivMats)[i].size() != npts;
                   ~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~

/Filters/General/vtkFiniteElementFieldDistributor.cxx:1513:16: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
      coeffs = std::move(::GetEdgeAttributes(fieldName, oldCd, cellId));
               ^

/Filters/General/vtkFiniteElementFieldDistributor.cxx:1517:16: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
      coeffs = std::move(::GetFaceAttributes(fieldName, oldCd, cellId));
               ^

/IO/IOSS/vtkIOSSReader.cxx:192:26: warning: unused function 'Split' [-Wunused-function]

/Charts/Core/vtkChartParallelCoordinates.cxx:230:27: warning: comparison of integers of different signs: 'int' and 'std::vector<std::vector<float>>::size_type' (aka 'unsigned long') [-Wsign-compare]

/IO/Cesium3DTiles/TreeInformation.cxx:613:92: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]

/IO/Cesium3DTiles/TreeInformation.cxx:659:21: warning: comparison of integers of different signs: 'int' and 'std::vector<std::vector<unsigned long>>::size_type' (aka 'unsigned long') [-Wsign-compare]

/IO/Cesium3DTiles/TreeInformation.cxx:661:23: warning: comparison of integers of different signs: 'int' and 'std::vector<unsigned long>::size_type' (aka 'unsigned long') [-Wsign-compare]

/Rendering/Volume/Testing/Cxx/TestGPURayCastMapperShadows.cxx:46:20: warning: unused function 'idxToCoords' [-Wunused-function]

/Parallel/DIY/vtkDIYGhostUtilities.h:149:10: warning: 'vtkDIYGhostUtilities::DataSetInformation' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
  struct DataSetInformation
         ^
/Parallel/DIY/vtkDIYGhostUtilities.h:200:10: warning: 'vtkDIYGhostUtilities::GridInformation' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
  struct GridInformation : public DataSetInformation
         ^
/Parallel/DIY/vtkDIYGhostUtilities.h:217:10: warning: 'vtkDIYGhostUtilities::ImageDataInformation' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
  struct ImageDataInformation : public GridInformation
         ^
/Parallel/DIY/vtkDIYGhostUtilities.h:260:10: warning: 'vtkDIYGhostUtilities::RectilinearGridInformation' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
  struct RectilinearGridInformation : public GridInformation
         ^
/Parallel/DIY/vtkDIYGhostUtilities.h:309:10: warning: 'vtkDIYGhostUtilities::StructuredGridInformation' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
  struct StructuredGridInformation : public GridInformation

/Filters/Geometry/vtkGeometryFilter.cxx:2104:7: warning: field 'Strips' will be initialized after field 'VertsConnPtr' [-Wreorder-ctor]

/Charts/Core/vtkChartParallelCoordinates.cxx:234:23: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]

/Common/DataModel/vtkCellTreeLocator.cxx:315:9: warning: field 'Cnt' will be initialized after field 'Min' [-Wreorder-ctor]

/Common/DataModel/vtkCellTreeLocator.cxx:1227:22: warning: comparison of integers of different signs: 'int' and 'std::vector<std::pair<vtkBoundingBox, int>>::size_type' (aka 'unsigned long') [-Wsign-compare]
Edited by Mathieu Westphal (Kitware)

Merge request reports