vtkDIYGhostUtilities: loosen bounding boxes

If the input data sets have loose point positions (i.e. points across partitions that are supposed to match don't actually match), the ghost cells generator fails at binding those points. This is not a problem if the input does not have global ids. However, if it has global ids, points then match. If a partition A has a bounding box that doesn't include some neighbor's points while this neighbor's bounding box includes the ones of A, then, if some of those point's global ids match, there is a conflict on the topology between partitions, and, as a consequence, the process will fail. The issue is the lack of symmetry between blocks while running the algorithm.

To avoid such events, each bounding box of each partition is now inflated by a lot (0.1% of its max width). This will include more points when checking which points are to be transfered, but this will include any "decent" situation. From now on, the filter will fail for points whose precision is lower than 0.1% of the bounding box width with global ids attached to the points. Such an input can be deemed ill-formed.

Adresses paraview/paraview#21228 (closed)

requested review from @cory.quammen

assigned to @yohann.bearzi

Errors:

• commit fbca4183 is not allowed because the following files are not formatted according to the 'clang-format' check: Filters/ParallelDIY2/Testing/Cxx/TestGhostCellsGenerator.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

Errors:

• commit fbca4183 is not allowed because the following files are not formatted according to the 'clang-format' check: Filters/ParallelDIY2/Testing/Cxx/TestGhostCellsGenerator.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

added 1 commit

• f5008c2b - vtkDIYGhostUtilities: loosen bounding boxes

Compare with previous version

Errors:

• commit f5008c2b is not allowed because the following files are not formatted according to the 'clang-format' check: Filters/ParallelDIY2/Testing/Cxx/TestGhostCellsGenerator.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

Errors:

• commit f5008c2b is not allowed because the following files are not formatted according to the 'clang-format' check: Filters/ParallelDIY2/Testing/Cxx/TestGhostCellsGenerator.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

changed the description

Do: reformat

This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

added 1 commit

• 4284845e - vtkDIYGhostUtilities: loosen bounding boxes

Compare with previous version

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

added 1 commit

• 2b5f920a - vtkDIYGhostUtilities: loosen bounding boxes

Compare with previous version

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

added 1 commit

• 2f8914fb - vtkDIYGhostUtilities: loosen bounding boxes

Compare with previous version

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

added 1 commit

• 49419b52 - vtkDIYGhostUtilities: loosen bounding boxes

Compare with previous version