Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • VTK VTK
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 850
    • Issues 850
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 234
    • Merge requests 234
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTKVTK
  • VTKVTK
  • Merge requests
  • !7836

vtkCompositePolyDataMapper2: Fix infinitely growing 'RenderedList'

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Utkarsh Ayachit requested to merge utkarsh.ayachit/vtk:value-pass-fixes-release into paraview/release Apr 09, 2021
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 3

vtkCompositePolyDataMapper2Helper maintained a secondary data structure called "RendereredList" which was populate with same values available in another ivar called "Data". However, when items from "Data" were removed, the code didn't update "RendereredList" similary causing "RendereredList" to grow infinitely.

To reproduce, one could simply monitor the size of "Renderered" and end of vtkCompositePolyDataMapper2::Render for a time-varying dataset and you'd notice it kept growing.

Fixed by not keeping this duplicate datastricture in vtkCompositePolyDataMapper2Helper. When needed, the rendered list is now simply generated using the values in "Data".

(cherry picked from commit 18d10d0e)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: value-pass-fixes-release