avoid self intersection on close gaps

instead of taking the last point on a sepratrix to connect to the next critical point, we use the first one that is closer than dist (the distance in which the critical points are seeded). This allows to compute a segmentation later.

Errors:

• commit ae024758 is not allowed because the following files are not formatted according to the 'clang-format' check: Filters/FlowPaths/vtkVectorFieldTopology.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

Do: reformat

This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

added 1 commit

• 138dc9df - avoid self intersection on close gaps

Compare with previous version

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

assigned to @bujack and unassigned @mwestphal

Do: test --merged

This merge request has been queued for testing. Test results may be viewed on:

• Gitlab CI builders results can be viewed via the Pipelines for this merge request.
• CDash links are also available in the Pipelines page
• CDash (master)
• Buildbot (master) (only visible from inside Kitware)

Branch-at-master: 5e4582e9

+1 otherwise.

Is there something that I have to do?

added 1 commit

• c4af31b7 - enable unstructured grid input

Compare with previous version

Errors:

• commit c4af31b7 is not allowed because the following files are not formatted according to the 'clang-format' check: Filters/FlowPaths/vtkStreamSurface.cxx, Filters/FlowPaths/vtkVectorFieldTopology.cxx, Filters/FlowPaths/vtkVectorFieldTopology.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

Oh damn, I pushed that by accident. I originally wanted to put that into a different mere request once this one is though. Now I am not sure what to do. Can we merge those two changes in one request? Or how do we get this push out of here?

• create a branch with your second commit : git checkout -b second
• go back to initial branch : git checkout closeGaps
• rebase this branch against master : git rebase -i master
• remove the second commit from the list and close the editor
• force push : git push -f
• the will fix this MR.
• You can then create another MR with the second branch, ideally only containing the second commit.

added 112 commits

• c4af31b7...a35f2645 - 111 commits from branch vtk:master
• 2ce0db0a - avoid self intersection on close gaps

Compare with previous version

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

resolved all threads

Just running tests to be sure. I'll merge if they are clean.

Great :) Thank you!!!!! I opened a merge request for the second push here: !7149 (merged)

Do: test --merged

This merge request has been queued for testing. Test results may be viewed on:

• Gitlab CI builders results can be viewed via the Pipelines for this merge request.
• CDash links are also available in the Pipelines page
• CDash (master)
• Buildbot (master) (only visible from inside Kitware)

Branch-at-master: 8b99f8df

There is a remaining warning to fix.

added 1 commit

• 58e36d43 - fix warning of shadowed variable

Compare with previous version

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Do: test --merged

This merge request has been queued for testing. Test results may be viewed on:

• Gitlab CI builders results can be viewed via the Pipelines for this merge request.
• CDash links are also available in the Pipelines page
• CDash (master)
• Buildbot (master) (only visible from inside Kitware)

Branch-at-master: f9f164d1

dashboard is clean. Merging.

Do: merge

mentioned in commit 1d80c35b

merged