Skip to content

Fixed misc issues found by cppcheck 1.84

Sean McBride requested to merge seanm/vtk:cppcheck1.84-more into master

Also update suppressions.

This fixed issues were:

identicalInnerCondition,Wrapping/Tools/vtkWrapHierarchy.c:457,warning,Identical inner 'if' condition is always true.

missingOverride,IO/ADIOS/FunctionPointers.h:114,style,The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier.

uninitMemberVar,IO/Image/vtkMRCReader.cxx:133,warning,Member variable 'vtkInternal::header' is not initialized in the constructor.

uninitMemberVarPrivate,IO/Xdmf3/vtkXdmf3LightDataHandler.cxx:70,warning,Member variable 'vtkXdmf3LightDataHandler::CellArrays' is not initialized in the constructor. uninitMemberVarPrivate,IO/Xdmf3/vtkXdmf3LightDataHandler.cxx:70,warning,Member variable 'vtkXdmf3LightDataHandler::FieldArrays' is not initialized in the constructor. uninitMemberVarPrivate,IO/Xdmf3/vtkXdmf3LightDataHandler.cxx:70,warning,Member variable 'vtkXdmf3LightDataHandler::GridsCache' is not initialized in the constructor. uninitMemberVarPrivate,IO/Xdmf3/vtkXdmf3LightDataHandler.cxx:70,warning,Member variable 'vtkXdmf3LightDataHandler::MaxDepth' is not initialized in the constructor. uninitMemberVarPrivate,IO/Xdmf3/vtkXdmf3LightDataHandler.cxx:70,warning,Member variable 'vtkXdmf3LightDataHandler::NumProcs' is not initialized in the constructor. uninitMemberVarPrivate,IO/Xdmf3/vtkXdmf3LightDataHandler.cxx:70,warning,Member variable 'vtkXdmf3LightDataHandler::PointArrays' is not initialized in the constructor. uninitMemberVarPrivate,IO/Xdmf3/vtkXdmf3LightDataHandler.cxx:70,warning,Member variable 'vtkXdmf3LightDataHandler::Rank' is not initialized in the constructor. uninitMemberVarPrivate,IO/Xdmf3/vtkXdmf3LightDataHandler.cxx:70,warning,Member variable 'vtkXdmf3LightDataHandler::SetsCache' is not initialized in the constructor. uninitMemberVarPrivate,IO/Xdmf3/vtkXdmf3LightDataHandler.cxx:70,warning,Member variable 'vtkXdmf3LightDataHandler::SILBuilder' is not initialized in the constructor.

uninitMemberVarPrivate,IO/Geometry/vtkOpenFOAMReader.cxx:4424,warning,Member variable 'vtkOpenFOAMReaderPrivate::NumTotalAdditionalCells' is not initialized in the constructor. uninitMemberVarPrivate,IO/Geometry/vtkOpenFOAMReader.cxx:4424,warning,Member variable 'vtkOpenFOAMReaderPrivate::Parent' is not initialized in the constructor.

Merge request reports