Correcting Reflection Filter so all vectors are reflected

• This corrects an reflection implementation where only "Vectors" and "Normals" were reflected
• Now all 3/6/9 component vectors/tensors of signed type are reflected
• This also update the test so those reflections are tested

Will fix paraview/paraview#11716 (closed) once it is integrated.

changed the description

@berkgeveci @acbauer

Do: test

This merge request has been queued for testing. Test results may be viewed on CDash or Buildbot (only visible from inside Kitware).

Branch-at: a95e3686

@haocheng.liu

added 1 commit

• 5b56275d - Correcting Reflection Filter so all vectors are reflected

Compare with previous version

Do: test

This merge request has been queued for testing. Test results may be viewed on CDash or Buildbot (only visible from inside Kitware).

Branch-at: 5b56275d

Dashboard is clean, please review : @jpouderoux @pierre.guilbert @luciemacron @nicolas.vuaille

added 1 commit

• 0bd86e42 - Correcting Reflection Filter so all vectors are reflected

Compare with previous version

Hmm, maybe this is as simple as providing an option to either flip all non-scalar fields or none.

@acbauer allright with me.

Makes sense. I would say to have it on by default. It's not entirely backwards compatible behavior, but I think that is probably okay in this case.

@acbauer : all non-scalar fields ? you mean all 3 components array right ?

Sounds like a plan. With a specific use-case where this doesn't work you could improve this but until that situation arises I think we can skip it. I would argue that in VTK that it should be off by default for backwards compatibility but in PV (which I suspect is the driving force behind the change), the default setting there should be to have it on. PV user's will be able to easily see if they're getting what they want but VTK users may not notice the change and have it cause problems.