New Boolean and Intersection branch

This is code for a new Boolean, vtkBooleanOperationPolyDataFilter2, and a new Intersection, vtkIntersectionPolyDataFilter2. -vtkIntersectionPolyDataFilter2 is very similar to vtkIntersectionPolyDataFilter with bug fixes and the addition of cell and point data on the intersection lines that helps in vtkBooleanOperationPolyDataFilter2. -vtkBooleanOperationPolyDataFilter2 uses a method where the output Boolean is determined by sub-surfaces separated by the intersection lines rather than a signed distance function. This makes it operate much faster and more robustly for larger intersections. More details on these methods are found in this paper: http://www.sciencedirect.com/science/article/pii/S0965997816300230

Basic content checks passed!

Branch-at: bfb22fec
Acked-by: @kwrobot

Sorry for the confusion. New branch without tabs in files. @dgobbi @cory-quammen

To add the baseline images, move them into 'Filters/General/Testing/Data/Baseline/' in your VTK source tree, and then run cmake again. CMake will generate an md5 hash file for each baseline image. You will have to 'git add' each of the generated hash files, commit them, and push them. For example, see the following sample commit:

https://gitlab.kitware.com/dgobbi/vtk/commits/vtk-boolean_retry

Okay, thanks for the instructions David. I will do this.

Added 1 commit:

• 3f39d2d3 - Added md5 boolean2 baselines

Basic content checks passed!

Changes since last check: compare

Branch-at: 3f39d2d3
Acked-by: @kwrobot

Looks clean, so I'll run the tests.

Do: test

Testing commands handed to buildbot.

Branch-at: 3f39d2d3

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: 3f39d2d3

The "CDash" above shows the dashboard errors. The errors for TestSampleImplicitFunctionFilter are unrelated, but the HeaderTest error and all the warnings need to be fixed before merge.

Okay, I'll look at it. Thanks for letting me know!

Added 1 commit:

• 09b09b57 - Changes for warnings and errors on cdash

Basic content checks passed!

Changes since last check: compare

Branch-at: 09b09b57
Acked-by: @kwrobot

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: 09b09b57

More comments on code style (yes, I'll eventually get around to reviewing the algorithms... but I'm hoping that Cory will do the first pass on that).

The Verbose member seems redundant, because vtkObject already has a Debug member that serves much the same purpose. Verbose output is generally done with vtkDebugMacro(), which checks if Debug is true, and if so, it directs the output to wherever "debug output" is supposed to go (which is std::cout by default on linux).

vtkDebugMacro(<< "X is " << x);

There are similar macros for warnings and errors:

vtkWarningMacro(<< "X is " << x);
vtkErrorMacro(<< "X is " << x);

If you are curious the definitions of these ancient macros are in Common/Core/vtkSetGet.h.

Sounds good, I will change Verbose to the DebugMacro when I have the chance!

Hey David, I use an Impl class, so I cannot use vtkDebugMacro within the Impl functions. vtkGenenericWarning still prints when not in debug mode correct? Is there another way for me to print debug statements inside the Impl class?

The impl class needs have a pointer to the VTK object that it implements. Then, it can call the vtkDebugWithObjectMacro:

vtkDebugWithObjectMacro(objectPointer, << "X is " << x)

There is also a vtkErrorWithObjectMacro and vtkWarningWithObjectMacro.

The use of these macros makes it possible for an application to catch and redirect all the debug info or error info from a specific object. There's another macro, vtkGenericWarningMacro, which can generate global error information (i.e. error information that is not associated with a particular VTK object), but for obvious reasons its use is discouraged.

Okay, great. Thanks David.

Added 1 commit:

• 3f5e013c - Changed Verbose to DebugMacros