Skip to content

Inconsistency signature of vtkHDF5Helper::GroupExists

LE GARREC Vincent requested to merge bansan/vtk:master into master

When building vtk 9.3.0 with hdf5 1.8.23, I have an error about wrong signature:

I think the good signature is bool vtkHDF5Helper::GroupExists(hid_t, const char*).

/usr/bin/c++ -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -D_POSIX_C_SOURCE=200809L -Dkiss_fft_scalar=double -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/IO/ERF -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/IO/ERF -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/Common/Core -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/Common/Core -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/ThirdParty/token/vtktoken/token -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/ThirdParty/token/vtktoken/token -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/ThirdParty/token/vtktoken -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/ThirdParty/token/vtktoken -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/Common/DataModel -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/Common/DataModel -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/Common/Math -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/Common/Math -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/ThirdParty/kissfft/vtkkissfft -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/ThirdParty/kissfft/vtkkissfft -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/Common/Transforms -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/Common/Transforms -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/Common/ExecutionModel -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/Common/ExecutionModel -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/IO/HDF -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/IO/HDF -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/Filters/Core -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/Filters/Core -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/Common/Misc -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/Common/Misc -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/Common/System -I/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/Common/System -isystem /home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/Utilities/KWIML -isystem /home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/Utilities/KWIML -isystem /home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/Utilities/KWSys -isystem /home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/Utilities/KWSys -isystem /home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/ThirdParty/token -isystem /home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/ThirdParty/token -isystem /home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/ThirdParty/nlohmannjson -isystem /home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/ThirdParty/nlohmannjson -isystem /home/gitlab-runner/builds/hwsweng/pfrd/poc/pfrd_gui/CI/vcpkg_installed/x64-linux-release/include -isystem /home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/ThirdParty/kissfft -isystem /home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/ThirdParty/kissfft -isystem /home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/x64-linux-release-rel/ThirdParty/hdf5 -isystem /home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/ThirdParty/hdf5 -fPIC  -O3 -DNDEBUG -std=c++11 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -MD -MT IO/ERF/CMakeFiles/IOERF.dir/vtkHDF5Helper.cxx.o -MF IO/ERF/CMakeFiles/IOERF.dir/vtkHDF5Helper.cxx.o.d -o IO/ERF/CMakeFiles/IOERF.dir/vtkHDF5Helper.cxx.o -c /home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/IO/ERF/vtkHDF5Helper.cxx
/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/IO/ERF/vtkHDF5Helper.cxx:64:6: error: no declaration matches ‘bool vtkHDF5Helper::GroupExists(hid_t, const char*)’
   64 | bool vtkHDF5Helper::GroupExists(hid_t fileId, const char* groupName)
      |      ^~~~~~~~~~~~~
In file included from /home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/IO/ERF/vtkHDF5Helper.cxx:3:
/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/IO/ERF/vtkHDF5Helper.h:45:15: note: candidate is: ‘static bool vtkHDF5Helper::GroupExists(int64_t, const char*)’
   45 |   static bool GroupExists(int64_t fileId, const char* groupName);
      |               ^~~~~~~~~~~
/home/gitlab-runner/.cache/vcpkg/vcpkg-git/buildtrees/vtk/src/c70d5a3f7c-220683d54d.clean/IO/ERF/vtkHDF5Helper.h:23:23: note: ‘class vtkHDF5Helper’ defined here
   23 | class VTKIOERF_EXPORT vtkHDF5Helper
      |                       ^~~~~~~~~~~~~```

Merge request reports