Skip to content

OpenXRRemoting: Support building against Holographic.Remoting.OpenXr >= 2.9.3

Jean-Christophe Fillion-Robin requested to merge jcfr/vtk:vr-support-build-against-openxrremoting-2.9.3-and-above into master

Starting with Microsoft.Holographic.Remoting.OpenXr 2.9.3, the struct XrRemotingPreferredGraphicsAdapterMSFT is defined in openxr_msft_holographic_remoting.h and it requires the type LUID to be defined.

Since LUID is defined in windows.h (see OpenXR-SDK-Source/specification/registry/xr.xml), we include the corresponding VTK header and fixes the following error reported when building the vtkRenderingOpenXRRemoting module:

C:\path\to\\OpenXRRemoting-install\build\native\include\openxr\openxr_msft_holographic_remoting.h(405,14): error
C3646: 'adapterLuid': unknown override specifier

Reference

Version 2.9.3 (October 26, 2023)

  • Holographic Remoting using the OpenXR API now supports GPU Adapter selection through the XrRemotingPreferredGraphicsAdapterMSFT extension struct.

Source: https://learn.microsoft.com/en-us/windows/mixed-reality/develop/native/holographic-remoting-version-history#version-293-october-2026-2023-

As a side note, a pull-request has also been submitted to fix the incorrect header in the MicrosoftDocs/mixed-reality version history, see https://github.com/MicrosoftDocs/mixed-reality/pull/762

Edited by Jean-Christophe Fillion-Robin

Merge request reports