vtkHDFReader: add composite dataset support
Context
vtkHDF
file format doesn't support for now composite dataset such as partitioned dataset collection, this MR intends to support it.
Solutions
To support it, we proposed a new spec for composite dataset, initially done in discourse, the final version is available here.
Technical part
-
The documentation has been updated to fit the new file format for composite dataset.
-
The most important thing in this design is the
Assembly
group used to retrieve the hierarchy. Then we can, based on the hierarchy, append each already supported data type by calling the correctRead
method. -
vtkTestUtilities
has been improved to be able to check each block inside a pdc -
h5py
scripts used to generate vtkHDF file in the context of this work is available in this repository : https://gitlab.kitware.com/keu-public/vtkhdf-scripts
Merge request reports
Activity
assigned to @lucas.givord
Errors:
- commit 165784ea is not allowed because the following files are not formatted according to the 'clang-format' check:
Testing/Core/Testing/Cxx/TestDataObjectCompare.cxx
,Testing/Core/vtkTestUtilities.cxx
,Testing/Core/vtkTestUtilities.h
. Post a comment ending in the lineDo: reformat
to rewrite the MR source branch automatically. - commit 2b900b4c is not allowed because the following files are not formatted according to the 'clang-format' check:
IO/HDF/vtkHDFReader.cxx
,IO/HDF/vtkHDFReader.h
. Post a comment ending in the lineDo: reformat
to rewrite the MR source branch automatically.
Warnings:
- please consider adding a changelog entry in a file ending with
.md
inDocumentation/release/dev
. - the merge request is marked as a work-in-progress.
The warnings do not need to be fixed, but it is recommended to do so.
Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.
- commit 165784ea is not allowed because the following files are not formatted according to the 'clang-format' check:
Errors:
- commit 165784ea is not allowed because the following files are not formatted according to the 'clang-format' check:
Testing/Core/Testing/Cxx/TestDataObjectCompare.cxx
,Testing/Core/vtkTestUtilities.cxx
,Testing/Core/vtkTestUtilities.h
. Post a comment ending in the lineDo: reformat
to rewrite the MR source branch automatically. - commit 76adb175 is not allowed because the following files are not formatted according to the 'clang-format' check:
IO/HDF/vtkHDFReader.cxx
,IO/HDF/vtkHDFReader.h
. Post a comment ending in the lineDo: reformat
to rewrite the MR source branch automatically.
Warnings:
- the merge request is marked as a work-in-progress.
The warnings do not need to be fixed, but it is recommended to do so.
Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.
- commit 165784ea is not allowed because the following files are not formatted according to the 'clang-format' check:
@louis.gombert @keu-sciviz please review
@yohann.bearzi could you please take a look at the
vtkTestUtilities
part ?- Resolved by Lucas Givord
- Resolved by Lucas Givord
- Resolved by Lucas Givord
- Resolved by Lucas Givord
- Resolved by Lucas Givord
- Resolved by Lucas Givord
- Resolved by Lucas Givord
- Resolved by Lucas Givord